Follow-up from #700308: Allow separate theming of each individual outgoing email instead of caching the prepared newsletter

CommentFileSizeAuthor
#4 without_notices.patch11.79 KBberdir
#2 fix_and_test_multilanguage_newsletters.patch11.33 KBberdir

Comments

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Issue tags: +test candidate

Tagging as test candidate.

Related to
#1177640: Add own explicit base url to send reliably

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new fix_and_test_multilanguage_newsletters.patch11.33 KB

Ok, attaching a first patch.

- Added tests for creating and sending newsletters in different languages.
- Not perfect yet, but e.g. makes sure that categories are translated, the correct node is used and that url rewriting works.
- Fixed a few bugs related to this and also unifies the user/language context handling in the source class.

Status: Needs review » Needs work

The last submitted patch, fix_and_test_multilanguage_newsletters.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new without_notices.patch11.79 KB

Fixed those notices. Although it's strange that getLanguage() returns an empty string, should be the default language instead. Will need to have a look at that.

Note that the new tests are currently not executed by the testbot because they're in the SimplenewsI18nTestCase class, which needs i18n but the testbot currently doesn't support soft/test dependencies. The problem is that, although content translation works without i18n, taxonomy translation doesn't.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Active

Commited.

It might not be perfect yet, but it's quite an improvement, fixes the existing i18n tests, adds new ones and also fixes an unrelated bug (including test coverage for that one).

Keeping open to investigate the getLanguage() behavior.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Pushing...

  • Berdir committed 8532865 on 8.x-1.x 
    Issue #1374926 by Berdir: Fixed active language handling when building...