Comments

danepowell’s picture

Note that I originally proposed a different solution at #1143588: Machine name not automatically generated in some cases (feeds_ui.js), but the solution above is what was used by Features, so it's probably better (though I haven't tested it).

twistor’s picture

Title: Machine name not generated if feed name is pasted » Machine name not generated if feed name is pasted using the mouse
Status: Active » Needs review

It's definitely better than before, but there's one edge case that's not catching.

If you paste into the field using the mouse and then only click the create button, the machine name doesn't get generated. You have to click someplace else first.

danepowell’s picture

StatusFileSize
new689 bytes

Hmm really? Well maybe my solution in the other thread is better then. Here's the patch. It takes a slightly different approach, but I've confirmed that it will work if you paste into the field and then only click the create button.

twistor’s picture

Status: Needs work » Needs review

That patch has the same problem, at least in Chrome 16 and Firefox 8 on Fedora 15.

The only way I can see to get around it would be to bind to the button.

Edit: Added OS.

danepowell’s picture

Status: Needs review » Needs work

Huh... that's weird. I'm using Chrome 15 on Windows 7 and #3 works fine (pasting a name and then just clicking 'create'). I'd be surprised if the difference in behavior was just due to Chrome version. I guess more testing is needed.

twistor’s picture

Status: Needs review » Needs work
twistor’s picture

Status: Needs work » Closed (works as designed)

Cleaning up old issues. I guess nobody else was affected by this.

If you have your heart set on it, feel free to reopen.