add a signup_no_views.inc and move hard-coded UI stuff there

Hm, well as discussed in IRC, its a little strange when switching from no views to installing views. The no_view block disappears and you have to go back to admin blocks to "turn it on again". This only happens of course is you set up your signup block before installing/enabling views. Strange behavior for the average user but the greater good being done here is probably worth it. Would be nice to come up with a better way to inform the user what is happening.

The only other thing is that the current patch loses the user/N/signups link in the block so that should be added in just to lessen overall confusion. ;)

I like the UPDATE.txt addition. Was about to rtbc but there is some views weirdness? When I am on user/N/signups I am getting the Views edit/clone/export tabs and when I click on clone I get a "page not found" and on export I get View '<em>signup_current_signups</em>' not found.

hm, a number of problems popped up (I'm using views-5.x-1.6-beta5 and signup-5.x-2.x-dev). They seem like views problems:

Firstly in admin/build/views the page URL for the signups view is user/$arg/signups. When clicking on it from there, it takes the $ literally and so gives a 404.

Then I went in to Override the view and didn't change anything but just hit Submit. It got really pissy at that:

View successfully added.

    * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '= '1')' at line 1 query: SELECT count(node.nid) FROM node node WHERE (.status = '1') in /home/add1sun/public_html/includes/database.mysql.inc on line 172.
    * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '= '1') LIMIT 0, 20' at line 1 query: SELECT node.nid, node.title AS node_title, node.changed AS node_changed FROM node node WHERE (.status = '1') LIMIT 0, 20 in /home/add1sun/public_html/includes/database.mysql.inc on line 172.
    * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '= '1') LIMIT 0, 10' at line 1 query: SELECT node.nid, node.title AS node_title, node.changed AS node_changed FROM node node WHERE (.status = '1') LIMIT 0, 10 in /home/add1sun/public_html/includes/database.mysql.inc on line 172.

This user has not signed up for any content.

I am in as user 1 and I am signed up for an event right now. My "current signups" block and user/1/signups page were both working fine before the "override" but then the block suddenly disappeared when this error showed. This would be because now when I go to user/1/signups I don't have anything listed. But I am signed up when I look at the node. I also created a new signup node and signed up - no dice. It seems that overriding or editing the view broke it somehow even though it is identical since I didn't edit anything.

ah, OK, that helps. I had done that when I did the original install to get my block but didn't realize I needed to do it everytime I mucked with something.

The $arg in the page URL issue still is a problem though. On admin/build/views the user/$arg/signups link ends up going to user/%24arg/signups when clicked. The link from the block is fine.

Unfortunately the patch failed for me on latest HEAD so I have to do the changes by hand (chance to have a closer look on the code :-)).
I've tested it first without views and it works as expected.
With views enabled there was one thing I assume to be not wanted by you: in signup_views.inc #272 (function views_handler_arg_signup_uid(...)) you add a where clause to the filter query:
$query->add_where("signup.status = 1"); .
This causes the view to load only nodes with open signups, regardless whether this filter is set or not.
If you remove the line one could control this behaviour with the views filter.

With this small change its RTBC, I think.

greetings and good night,

Stefan

Are you sure you were starting from a clean checkout?

Jup. Tried right now and it failed again.
My directory structure:

contributions
 |- modules
 |  |- signup

If I change all occurences of modules/signup within the patch file (e.g. Index: modules/signup/INSTALL.txt) to signup the patch is working. Maybe its a windows problem with the path separator but now I know how to solve it.

Ah, silly windows :-)
I tried with patch.exe and it failed. If I try with cygwin and patch -p0 < ... it works. Good to know. So far it always worked.

borchert@hermine /cygdrive/d/webserver/cvs/drupal/contributions
$ patch -p0 < signup_no_views.patch_7.txt
patching file modules/signup/INSTALL.txt
patching file modules/signup/README.txt
patching file modules/signup/UPGRADE.txt
patching file modules/signup/signup.module
Hunk #4 succeeded at 1272 (offset -3 lines).
patching file modules/signup/signup_no_views.inc
patching file modules/signup/signup_views.inc

Btw: INSTALL.txt is missing the newer permissions ("email all signed up users" etc.). Should this be a separate patch or included with this one?