As stBorchert pointed out over at http://drupal.org/node/137911#comment-317292 (comment #17), the views_handler_arg_signup_uid() function is adding an inappropriate WHERE clause to the SQL query. It's forcing the argument to filter on nodes where signups are still open. That should be handled via the existing signup status filter, instead of being built-in to the UID argument handler.

CommentFileSizeAuthor
#3 signup_views_uid_handler_0.patch701 bytesstborchert
#1 signup_views_uid_handler.patch680 bytesstborchert

Comments

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new signup_views_uid_handler.patch680 bytes

Simply removed the appropriate line.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Needs work

I think we should remove the {signup} table from the query, too, then... Doesn't seem necessary if we're not implicitly filtering on signup.status. We'd want to remove this line, too:

$query->ensure_table('signup');

All of this requires a little more thoguht, investigation and testing, however. ;)

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new signup_views_uid_handler_0.patch701 bytes

Ok, I've removed both lines and tested if there any side effects. There aren't any :-)
The other code doesn't depend on table {signup} so there seems to be no problems and unused code.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

Confirmed, and committed to HEAD. My default "signup_current_signups" already had a filter for signups that were open, anyway, so this didn't even break http://drupal.org/node/137911. ;) Woo hoo. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)