Wrong response headers reported on 3xx requests in function http_request_get [#1380636]

Comment	File	Size	Author
#6	feeds-http_request_get-1380636-6.patch	937 bytes	emackn
#1	feeds-http_request_get-1380636-1.patch	721 bytes	gnucifer

Comment #1

gnucifer commented 23 December 2011 at 12:39

Status	File	Size
new	feeds-http_request_get-1380636-1.patch	721 bytes

Patch submitted.

Log in or register to post comments

Comment #2

gnucifer commented 23 December 2011 at 12:41

Status:

Active

» Needs review

Log in or register to post comments

Comment #3

emackn commented 27 December 2011 at 20:49

Can you provide me a feed that does this so I can check it out?

Also, can you explain a little about what you are doing with the lines you added?
It looks like you are splitting up all the headers, and then splitting again on the last set of headers for $header_lines.

Thanks.

Log in or register to post comments

Comment #4

gnucifer commented 28 December 2011 at 14:10

The feed is fetched from a webservice that required authentication, so can't give you give you an example. This is how the headers returned by curl looks like though.

HTTP/1.1 302 Found
Cache-Control: private
Content-Length: 195
Content-Type: text/html; charset=iso-8859-1
Location: /data/CBild/3UOQASUN/QGSBJG1J_q70_mFile_cmNone.jpg
Server: Microsoft-IIS/7.0
X-AspNet-Version: 1.1.4322
X-Powered-By: ASP.NET
Date: Thu, 22 Dec 2011 20:02:06 GMT

HTTP/1.1 200 OK
Content-Type: image/jpeg
Last-Modified: Thu, 22 Dec 2011 17:55:56 GMT
Accept-Ranges: bytes
ETag: "f81298f4d2c0cc1:0"
Server: Microsoft-IIS/7.0
X-Powered-By: ASP.NET
Date: Thu, 22 Dec 2011 20:02:06 GMT
Content-Length: 114477

The current code will return the header for the first resonse. To fix this I split the headerblocks on the separator (two \r\n) so that only the last one is parsed and included in the response-object.

Ideally I would also like the file to be saved as basename(/data/CBild/3UOQASUN/QGSBJG1J_q70_mFile_cmNone.jpg), the location of the last redirect) instead of the original request url. But have not figured out a way to do this in a clean way.

Log in or register to post comments

Comment #5

emackn commented 29 December 2011 at 18:10

Status:

Needs review

» Reviewed & tested by the community

Code works well. Were you checking the headers for some other processing that led you to this?

Log in or register to post comments

Comment #6

emackn commented 29 December 2011 at 18:13

Status	File	Size
new	feeds-http_request_get-1380636-6.patch	937 bytes

had to re-roll the patch since the some other things have been added to dev in the last week.

Log in or register to post comments

Comment #7

emackn commented 29 December 2011 at 18:14

Status:

Reviewed & tested by the community

» Patch (to be ported)

Log in or register to post comments

Comment #8

emackn commented 29 December 2011 at 18:18

committed to 7.x-2.x

Log in or register to post comments

Comment #9

gnucifer commented 30 December 2011 at 13:04

emackn: Yes, I was checking the headers primarily for mime-type checking etc as discussed in this issue: http://drupal.org/node/706908. I later dropped the idea of checking mime-type in headers in favor of downloading the file to perform mime-checking with fileinfo. The mime-type in the response can't be trusted anyway, so I don't see how it's usable besides giving an indication of what type of file to expect.