Comments

kevinquillen’s picture

Status: Active » Postponed

Not sure if I want to take this on. Feel free to submit patches to enable this- I will be working at VBO integration in this issue.

kevinquillen’s picture

Status: Postponed » Closed (won't fix)

Feel free to post patches for the Drupal 6 version, it is staying as-is, security fixes only.

socialnicheguru’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Closed (won't fix) » Active

sorry. I have moved onto Drupal 7 since then. does it work with fasttoggle?

kevinquillen’s picture

Status: Active » Postponed
StatusFileSize
new1.75 KB

Not too easily, it seems. Fasttoggle seems young still.

Here is a rough patch that seemed to work. I am not sure if I want to integrate directly into CPO or not, this seems a little edge case (vs Rules, Views, and Features) as it only seems 300 installations reported are using Fasttoggle. I understand the UX ability it provides, but I am not sure I want the additional overhead to maintain.

Anyway, I was able to see custom options appear in Fasttoggle and on node view. It probably won't work from the node admin content screen, because CPO is overriding it- I didn't see anything appear, anyway.

Beyond that more work would be needed to implement hook_fasttoggle_labels etc as well as throw in additional checks to see if the node viewed has the CPO option assigned to it, it shouldn't display if not. Kind of seems like a lot of code to include for this... feel free to use the dev (or 1.0 tomorrow) with this patch, it should get you going.

For now I'd like to get 1.0 up, collect feedback and let the dust settle on the full release, then I can see where we can go.

kevinquillen’s picture

Status: Postponed » Closed (won't fix)

I basically can't do this until Fasttoggle solidifies its base and provides integration hooks. The patch above worked when I posted it, but Fasttoggle has since changed I suppose, and I can't get the options to appear anymore.

I outlined the challenge(s) here: #785138: Support for Custom publishing options? (D6 and D7)

nigelcunningham’s picture

Status: Closed (won't fix) » Needs review
StatusFileSize
new3.61 KB

Please find attached a patch I've just prepared against current Fasttoggle 7.x-1.x. I've been working on making the API more integration-friendly, and did this patch as part of my testing.

Nigel (Fasttoggle maintainer)

kevinquillen’s picture

Assigned: Unassigned » kevinquillen

Nice work. I will get this rolled into a future release.

nigelcunningham’s picture

Thanks!

summit’s picture

Status: Needs review » Reviewed & tested by the community

Hi, is this finished to be rolled in now please?
Thanks a lot for doing this.
greetings, Martijn

socialnicheguru’s picture

Issue summary: View changes

Fasttoggle has changed a little.

I can't seem to get any type of views integration with my custom publishing options and fasttoggle.

nigelcunningham’s picture

Yeah - sorry. I keep working on it and trying to improve the API.

I'm currently working towards a 2.0 release. I've removed the need for the menu items and some of the functions have changed a little - I'm seeking to make the API as flexible as reasonably possible so that most if not all of the integration requirements with other modules can be easily met.

I'll seek to provide a new version soon... but I have been saying that for a few months now!

Regards,

Nigel

socialnicheguru’s picture

does this new patch replace the ones as part of this issue"

https://www.drupal.org/node/2297603#comment-8980879

nigelcunningham’s picture

StatusFileSize
new2.18 KB

Yes, the patch in https://www.drupal.org/node/2297603#comment-8980879 replaces this one.

I'll upload it here too and close the other issue.

deanflory’s picture

The existing patch fails with the most recent dev/1.4 of custom_pub. Needs a re-roll.

nigelcunningham’s picture

StatusFileSize
new2.29 KB

Here's an updated patch for 7.x.

Regards,

Nigel

deanflory’s picture

Thanks Nigel! I will check it out.

deanflory’s picture

vladimiraus’s picture

Assigned: kevinquillen » Unassigned
Status: Reviewed & tested by the community » Fixed

Thank you for contributions.
Commited.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.