Needs work
Project:
Hierarchical Select
Version:
7.x-3.x-dev
Component:
Code - Menu
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
28 Dec 2011 at 10:30 UTC
Updated:
18 Apr 2012 at 13:18 UTC
Jump to comment: Most recent file
Comments
Comment #1
firebird commentedThe attached patch adds Taxonomy Menu support to hs_menu.
Unfortunately, this patch conflicts with the patch (fix_hs_menu_array_warning-1304002-2.patch) described here: http://drupal.org/node/1304002 . This means that until one of the patches is committed to dev and the other patch edited accordingly, one of the patches needs to be applied manually.
Comment #2
firebird commentedRight. I guess I should've tested a bit more. The patch "works", but it doesn't exactly make the loading of the page faster. This is probably due to the pending performance issues in HS. Once loaded, the page works as it should, with the HS element.
Comment #3
wim leers#1304002: [explode() expects parameter 2 to be string, array given in menu_node_submit()] warning msg is now no longer necessary, since #1272538: Hierarchical Select Menu should also flatten on submit of node forms has been committed. Please reroll your patch accordingly.
Also:
- "submit callback", not "submit handler"
- due to #1271386: Hierarchical Select Menu should respect menu_options having been committed, you may also pass in a 'type' — I don't know if it's necessary, you'll have to look into that (I don't know how Taxonomy Menu works)
- please either reuse hs_menu_menu_edit_item_form_submit() or hs_menu_node_form_submit(), if not, please create a unifying alternative, with the exact location within the $form_state['values'] array being stored somewhere in $form_state['storage']['hs']['hs_menu']