There is a general settings page currently with two select fields to select the vocabulary and the taxonomy reference field to be used.

As the comment already states, I think we should drop that, I'm assuming that changing these values will result in weird errors and I don't really see a use case for them.

/**
 * Menu callback: Simplenews admin settings - General.
 *
 * @todo Delete this for if there is not more use for it.
 */
function simplenews_admin_settings($form, &$form_state) {

Patch follows.

Comments

berdir’s picture

Status: Active » Needs review
StatusFileSize
new3.57 KB

Attached patch removes that callback and updates hook_menu().

miro_dietiker’s picture

StatusFileSize
new5.29 KB

Retry patch.

Note that there was code for adding / removing fields automatically that missed the configurability (variable)...

Additionally, if you currently uncheck a nodetype to be used as newsletter, the field is automatically removed and thus all term assignments are lost. This is not an expected behaviour. Removing this behaviour.

Status: Needs review » Needs work

The last submitted patch, 1387820_remove_general_settings_2.patch, failed testing.

miro_dietiker’s picture

StatusFileSize
new6.6 KB

Retrying with updated tests.

miro_dietiker’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1387820_remove_general_settings_4.patch, failed testing.

miro_dietiker’s picture

Status: Needs work » Needs review
StatusFileSize
new6.55 KB

Committing this once confirmed.

miro_dietiker’s picture

Status: Needs review » Fixed

Committed. :-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.