Closed (fixed)
Project:
Simplenews
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Dec 2011 at 17:41 UTC
Updated:
17 Jan 2012 at 00:37 UTC
Jump to comment: Most recent file
There is a general settings page currently with two select fields to select the vocabulary and the taxonomy reference field to be used.
As the comment already states, I think we should drop that, I'm assuming that changing these values will result in weird errors and I don't really see a use case for them.
/**
* Menu callback: Simplenews admin settings - General.
*
* @todo Delete this for if there is not more use for it.
*/
function simplenews_admin_settings($form, &$form_state) {
Patch follows.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 1387820_remove_general_settings_6.patch | 6.55 KB | miro_dietiker |
| #4 | 1387820_remove_general_settings_4.patch | 6.6 KB | miro_dietiker |
| #2 | 1387820_remove_general_settings_2.patch | 5.29 KB | miro_dietiker |
| #1 | remove_general_settings.patch | 3.57 KB | berdir |
Comments
Comment #1
berdirAttached patch removes that callback and updates hook_menu().
Comment #2
miro_dietikerRetry patch.
Note that there was code for adding / removing fields automatically that missed the configurability (variable)...
Additionally, if you currently uncheck a nodetype to be used as newsletter, the field is automatically removed and thus all term assignments are lost. This is not an expected behaviour. Removing this behaviour.
Comment #4
miro_dietikerRetrying with updated tests.
Comment #5
miro_dietikerComment #7
miro_dietikerCommitting this once confirmed.
Comment #8
miro_dietikerCommitted. :-)