Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
javascript
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Dec 2011 at 06:13 UTC
Updated:
14 May 2015 at 09:48 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
johnalbinOne thing I've noticed from the new version's source is that it removed the IE js-based conditional comments (that's the
/*@cc_on@*/ bits from the old version. We need to double check if that means anything for Drupal's use of html5.js (I haven't looked at the details of how Drupal is using it.)Comment #2
johnalbinNeeds review, of course.
Comment #3
johnalbinI just looked at how HTML5.js is added over in the original issue #1077878: Add HTML5shiv to core. It looks like we are fine with the removal of the
/*@cc_oncomments since we are wrapping the HTML5.js in a conditional comment.Comment #4
jacineComment #5
catchThanks! Committed/pushed to 8.x.
Comment #7
sunhtml5shiv is moving pretty fast: https://github.com/aFarkas/html5shiv/tags
Whereas the minified release doesn't really follow as fast and also seems to contain weird changes:
http://code.google.com/p/html5shiv/source/browse/trunk/html5.js
(pre3.5 should never have been ended up in the released version)
However, the tagged downloads on github are plain tarballs from the original source, not the minified script.
Perhaps we should include it remotely, as suggested on the project page on http://code.google.com/p/html5shiv/ ?
Another difference I see is that we're including it with:
but the suggested code (as visible above) actually uses
lt IE 9. In terms of strict version comparison basics,lt IE 9can match versions thatlte IE 8is not able to match (typically development versions and so on; it depends on the exact version comparison algorithms of Internet Explorer whether it catches everything as intended or not).lt IE 9, as suggested on the html5shiv project page, looks more bullet-proof to me.Comment #9
jacineI agree
lt IE 9would be better. We should change that. Not sure if we should just do it here or create a new issue?As far as including the Shiv remotely, that's not a good idea.
Comment #10
sunRe-opening. We cannot release with an outdated version.
Comment #11
effulgentsia commentedSounds like we just need an updated minified file and an update to the browser version string.
Comment #12
nod_The html5shiv doesn't add or change functionality for core, it works today, not major.
Comment #13
hass commentedShouldn't we use the print version? https://github.com/aFarkas/html5shiv/blob/master/dist/html5shiv-printshi...
Comment #14
klonosI'm keeping an eye on this issue and on html5shiv versions (the current source header says 3.6RC1 actually).
I agree with Théodore's comment in #12. Instead of keep opening and closing this issue here as new html5shiv versions come out, let's just keep it open but leave it to normal priority (so that it doesn't interfere with the major tasks threshold). The tag to revisit suffices to make sure we don't loose track of this and that we'll ship with the latest version once D8 final is ready. Now, if one finds the time to update to the most current one from time to time as we go, it wouldn't hurt ;)
As for the printshiv Alexander mentions in #13, I think it was included with html5shiv at some point - I just cannot recall the exact version that started including it. I guess the code was separated later on (not on its own - you either choose html5shiv with or w/o printshiv). Anyways, if we want to support seamlessly both display and print preview with html5, then we should make sure we use the printshiv version.
Comment #15
hass commentedI looked into source and code size and the print one has a special section in the code. File size of the print version is nearly doubled. If print part is included i would wonder, but less kb are always better... Docs on the html5shim page are not really helpful to find out... Maybe someone else know better?
Comment #16
klonos3.6 final is out.
Comment #17
klonosWe should use html5shiv-printshiv.js instead. Updated the issue title to reflect that.
I'd like to also mention here #1341792: [meta] Ship minified versions of external JavaScript libraries where it was proposed/discussed that we should include both minified and non-minified versions of the libs. I don't know if it makes sense to do something similar here - just pointing it out for discussion. #1537198: Add a Production/Development toggle too.
BTW...
html5shiv.js ~9kb
html5shiv-printshiv.js ~15kb
html5shiv-min.js ~2.3kb
html5shiv-printshiv-min.js ~4kb
Comment #18
andrewmacpherson commentedBartik is now using the <main> element, but the version of html5.js currently in D8 does not include main.
<main> was added to the upstream library December 2012.
See https://github.com/aFarkas/html5shiv/issues/81
Comment #19
klonos...was about to update the issue myself. Thanx ;)
Comment #20
alanburke commentedDrupal 8 support has been dropped.
This shiv should be removed from core.
See #1999948: Add HTML5shiv for contrib support
Comment #21
alanburke commentedCorrect typo in title.
Comment #22
nod_Dries is not up for removing the shim #1993334-8: Add HTML5shiv to Stable and Classy only . I guess we're keeping it for now.
Comment #23
catchMarking this as duplicate.
Comment #24
hass commentedThere is still a need for this. My themes support all browsers back to IE6.
Comment #25
nod_Shim is already up to date. #1974422: The html5shiv in core is missing elements
Comment #26
hass commentedThis is not the html5shiv-printshiv. We need to remove the non-print one and replace it withe the print one.
Comment #27
nod_Well, IE8 and under anymore are "no longer fully supported": http://drupal.org/node/1569578. Also depending on #1993334: Add HTML5shiv to Stable and Classy only the shiv might not even make it in the final release.
If you'd like a specific version it can ship with your theme. It's pretty trivial to override a css or js file from the theme info file now.
Comment #28
hass commentedInternet Explorer 6, 7 and 8 no longer fully supported
No longer FULLY supported does not mean it's NOT supported. Don't overlook this small difference, please. This means it is still supported, but we do not waste years to get a theme running on it. :-)
I know that I can add it to the themes and I do this already, however suxxx D7 is missing #865536: drupal_add_js() is missing the 'browsers' option.
Comment #29
catch#1993334: Add HTML5shiv to Stable and Classy only
Comment #30
sunAdding to new meta issue.
Comment #31
mgiffordTitle change based on https://github.com/aFarkas/html5shiv/blob/master/src/html5shiv-printshiv.js
Comment #32
nod_Up to date now.