When clicking the configure icon on the right side of the Date field row on /admin/structure/types/manage/[contenttype]/display and selecting Repeat rule: Hide repeat rule and pressing Update, the summary of configuration still says Show repeat rule while it should say Do not show repeat rule.

When clicking Save, the repeat rules will actually be hidden, so that part works correctly. When clicking the configure icon, the selected option in the dropdown menu is Display repeat rule when it should be Hide repeat rule.

CommentFileSizeAuthor
#4 date-1389346-4.patch2.5 KBtim.plunkett

Comments

skap’s picture

skap
she/her
commented

Edit: My issue was similar, but seems to have resolved itself magically.

Edit 2: Now it's back. It is similar to yours, except that when I save the display settings, they continue to show the repeat rule. When I go back in and configure the view, it always says "Display Repeat Rule." I change it, save, and it reverts. I'm in 7.x-2.0-rc1 but I'm wondering if this isn't a Calendar Module problem instead.

Daedalon’s picture

Daedalon commented
Version: 7.x-2.0-alpha5 » 7.x-2.0-rc1

Got it in 7.x-2.0-rc1 as well. Not sure if I originally noticed this in 7.x-2.0-alpha5 or if I mislabeled this at first.

jsheffers’s picture

jsheffers commented

I'm getting this bug as well, but mine are not hiding regardless of whether I've selected hide repeat rule or show, once I click apply it always says Show Repeat Rule.

I have the latest Dev's of Date, Views, and cTools.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new date-1389346-4.patch2.5 KB

Here's a patch that fixes the problem. If someone could test it out, I'll commit it.

Status: Needs review » Needs work

The last submitted patch, date-1389346-4.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Version: 7.x-2.0-rc1 » 7.x-2.x-dev
Status: Needs work » Needs review

That ran against the wrong branch.

jsheffers’s picture

jsheffers commented

I see it now passed. I'm testing it now.

jsheffers’s picture

jsheffers commented

I am unable to make this patch work. It keeps asking which file to patch....

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

@jsheffers use patch -p1. or type in the file name.

There are two parts of the patch, one to date.api.php and one to date_repeat_field/date_repeat_field.module.

date.api.php wasn't in the rc1, it's only in dev, but that's just documentation. The important changes are to the module.

They're small enough you could change it manually.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Fixed

Committed: http://drupalcode.org/project/date.git/commit/97ff461

karens’s picture

karens commented

We probably could have left the terminology in the t() function alone, since changing strings breaks all the translations and that was a pretty minor change that might not have been necessary. Just a FYI as we near a release that we should be careful about altering strings unless they really don't make sense. Other than that, this looks fine, and it's already committed so don't worry about it. Thanks!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

There were two sets of strings, I just picked one. No new strings were added.

karens’s picture

karens commented

Ah, I missed that. Yes, that's a good catch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.