Multiple "Undefined index" notices

I am getting this same error with the newest (1.5) version. I applied the patch (manually) and it works now.

Jason

This could use another confirmation/review.

The !empty() didn't need to be added in addition to the original condition, it just need to replace it.

+++ b/www/cms/sites/all/modules/antispam/antispam.moduleundefined
@@ -992,23 +992,23 @@ function antispam_comment_presave($comment) {
-  if ($antispambot_rules['body']) {
+  if (!empty($antispambot_rules) && $antispambot_rules['body']) {

For example this should just be
if (!empty($antispambot_rules)) {

@cfinke: One thing to note:

• If someone else worked on the patch, it's important to give them credit. This can be fixed by reverting the commit, and then recommitting with the proper attribution (--author tag). This should definitely happen for #2379263: AKISMET service is not working with current 7.x DEV, possibly here, and wherever else. I mentioned that there, but as it's closed, you may not see it.

Still missing --author tag though?

The Drupal "commit messages" page says this about giving credit:

If others have contributed to the change you are committing, take the time to give them credit. Each commit message should contain at least one contributor name, even if it refers to yourself. Once a project has more than one maintainer, or is taken over by a new maintainer, it's very valuable to know who actually wrote or contributed a certain change.

To do this, append "by [username]:" to the issue number.

Is that not sufficient?

That's great for humans, but for drupal.org to automatically credit authors so that commits show up in their profile, maintainers need to use the --author option when committing. This is noteworthy from the link above:

The Credit & committing section of an issue will automatically format commit messages for you, including --author attribution, so that you can just edit the message (it defaults to the issue title) as needed.

This is pre-filled based on whoever submitted the last patch, but you may want to change it by selecting a different radio button if someone did more work in a previous patch, and you want to make him/her the author.

The --author flag does not control what shows up in the profiles. That would be the "credit" checkboxes, which are currently blank for this issue.

The project maintainer can select those checkboxes, and hit save.
No need to change the commit any futher.

#14: Correct! I forgot about that option because it's newer.