Views imBookFlip

welcome!

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 6.x-1.x branch:

• Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
• ./views_imBookFlip.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function views_imbookflip_menu() {
  

• Remove all old CVS $Id tags, they are not needed anymore.
  

  views_imBookFlip.info:1:; $Id$
  views_imBookFlip.module:2:// $Id$
  views_imBookFlip_style_plugin.inc:2:// $Id: views_imBookFlip_style_plugin.inc Exp $
  views_imBookFlip.views.inc:2:// $Id:  Exp $
  views-imBookFlip-view.tpl.php:2:// $Id: Exp $
  

• Run coder to check your style, some issues were found (please check the Drupal coding standards). See http://ventral.org/pareview/httpgitdrupalorgsandboxkentoro1329014git.
• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See http://ventral.org/pareview/httpgitdrupalorgsandboxkentoro1329014git.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

You can find more information about using foreign libraries (like your jq plugin) on the libraries API project page (http://drupal.org/project/libraries) and it's documentation (http://drupal.org/documentation/modules/libraries)

Please change the status back to needs review after you fixed that

OK, there are many style issues that need fixed. Included is a file of the Ventral output as well as from the command:
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme .

See if you can use phpcs on your dev environment as it will save time. Once those errors are cleaned up...

Also see:
http://drupal.org/coding-standards

There is a copyright statement in jquery.imBookFlip-0.6.js:

* 	 imBookFlip - a JQuery Plugin
 * 	 @author Les Green
 * 	 Copyright (C) 2009 Intriguing Minds, Inc.
 *   Version 0.6

The final reviews may have issue with this even though this plugin is under the GNU licencing.
Also there is another licence included. That could be an issue with the final reviewers also.

Documentation needed throughout. Example:
function template_preprocess_views_imBookFlip_view(&$vars)
Needs a commend header.

Please read for comments:
http://drupal.org/node/1354

Code looked more or less OK, but easier to read with comments and proper indentation and formatting.

Also you may want to consider running the coder module which can also show errors. There is an upgrade module add on that can be used to help you upgrade this module to Drupal 7, where it would see a future audience.

OK, please see comment
http://drupal.org/node/1390218#comment-5624882
and back to you.

@kentoro

Still there are so much coding style issue after PAreviews.

@ankitchauhan why did you change status? This should still be 'needs work'. And please, be polite to our applicants.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

changing git adress