Closed (works as designed)
Project:
Forward
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Apr 2007 at 16:46 UTC
Updated:
25 May 2007 at 20:33 UTC
The forward module does not check for the link type in the forward_link function.
This let displays forward links also on not correct locations.
Attached a patch to fix the issue.
Fabio Varesano
| Comment | File | Size | Author |
|---|---|---|---|
| forward_link.patch | 1.1 KB | fax8 |
Comments
Comment #1
seanrFixed in HEAD and 5.x. Thanks.
Comment #2
killes@www.drop.org commentedComment #3
arthurf commentedThe way this is implemented, the forward link/form is on by default. I think that it is generally better practice to have to turn it on per content type rather than off. This is a one digit fix, line 637 in HEAD:
I just changed
to
Thanks for your work on this!
Comment #4
seanrI'd prefer not to change this since every site I've used it on prefers to have it on for most if not all content types. It's configurable as is, and I prefer to leave it with the default that is least likely to need to be changed by the widest number of users.
Comment #5
seanrFWIW, I'm planning on looking in to adding the list of content types to the forward settings page so it can be changed there, too. That'd save someone like you a lot of clicks. ;-)