If a user (normally admin) has permissions to view an unpublished node then the nodeblock for that node will appear to them even if other users can't see it. This may well be expected behaviour but the nodeblock isn't configurable as it no longer exists in the block management page and this makes it tricky to deal with or track down.

I can see three ways to go:

  1. Blanket hiding of all unpublished nodes
  2. Leaving them configurable in the block management page
  3. Making their display configurable on a type and/or per block basis

The first is a one line change (when checking if the node is viewable in nodeblock_block_view() just add a check for status:

if (!node_access('view', $node) || $node->status == 0) {
    return;
  }

The second is a whole can of worms I'm not ready to go for, and the third option is in the attached patch.

Any thoughts on this?

CommentFileSizeAuthor
#5 1396336-leave_unpublished_blocks_in_admin-2.patch387 bytesmesr01
#4 1396336-leave_unpublished_blocks_in_admin.patch463 bytesmesr01
#3 nodeblock-module-hide-unpublished-1.patch449 bytestobyontour
nodeblock-module-hide-unpublished.patch2.97 KBtobyontour

Comments

michaellander’s picture

michaellander commented

Hmm. Good find.

I like 2 because it has the smallest chance of impacting sites already using the module(of which may be using the unpublished display). Let me look into this a bit and see what I can find. Thanks!

tobyontour’s picture

tobyontour commented

Personally I'd be keen to have option 3 in there as well as leaving them configurable if they were set to still be visible if unpublished. The reason I discovered it was because the behaviour was unexpected (although technically justifiable).

If the patch (or some similar system) was implemented then the current behaviour would be maintained unless it was set to do otherwise in the configuration.

tobyontour’s picture

tobyontour commented
StatusFileSize
new nodeblock-module-hide-unpublished-1.patch449 bytes

Just in case anyone cares, here's the patch for option 1.

mesr01’s picture

mesr01 commented
StatusFileSize
new 1396336-leave_unpublished_blocks_in_admin.patch463 bytes

And here's one for option 2.

mesr01’s picture

mesr01 commented
StatusFileSize
new 1396336-leave_unpublished_blocks_in_admin-2.patch387 bytes

Oops, error in patch header. Here's a new version.

Johnny vd Laar’s picture

Johnny vd Laar commented
Status: Active » Fixed

I've committed this option: http://drupal.org/node/1396336#comment-6266466 (option 2).

Thank you for the patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.