Closed (fixed)
Project:
Crumbs, the Breadcrumbs suite
Version:
7.x-1.0-alpha1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Jan 2012 at 17:49 UTC
Updated:
15 Mar 2012 at 22:58 UTC
Jump to comment: Most recent file
Comments
Comment #1
bforchhammer commentedHere we go...
Attached patch also fixes the debug form (was submitting to wrong path), and removes a E_NOTICE message.
Comment #2
bforchhammer commentedWell, that was too hasty. Attached is a patch that's actually working; now crumbs shows up in the user interface section on the configuration page.
Comment #3
donquixote commentedNot sure.
On the few D7 sites that I work on, the only thing I found in "User interface" was "Shortcuts". I don't see that Crumbs belongs in there.
Comment #4
bforchhammer commentedWell, tbh I didn't really know where to put it. I have "Delta blocks" and "Menu block" in the "User Interface", and with breadcrumbs being an UI element, that actually seemed to fit nicely. I don't really care either way, just though that it should appear somewhere so people don't have to know and type in the path...
Comment #5
donquixote commentedHm.
I'm going to put it into "Structure" for now. This does not make much sense either, but there it is close to "Menu". Also it is close to "Context", which at some day it could
For some reason I don't like the term "User interface". It is so generic, it could be anything.
Anyway, thanks for caring!
The next release will have this improvement, or something equivalent. Until then, you can use your own modified version.
-------
Btw, I am always happy about feedback!
Esp,
How well does this work compared to other breadcrumb-customizing modules?
Is there any use case for a breadcrumb that can not be achieved with Crumbs?
How many % of site builders understand the configuration page, with those hierarchic weights?
How easy/difficult and practical is the API ?
(can be in another issue, if you like)
Comment #6
bforchhammer commented#1399080: Feedback on crumbs 7.x
Comment #7
joelstein commentedRegardless of where you want to put it, it won't show up for anyone except user #1, because you have hook_perm(), which is D6, and you need to use hook_permission():
Comment #8
donquixote commentedWoot!
It's great having someone other than me look at this stuff.
Big thanks!
Comment #9
joelstein commentedYou're welcome. Are you going to commit it?
Comment #10
donquixote commentedOn the way.
http://drupalcode.org/project/crumbs.git/commit/716b9a424997638460f2a6e4...
Going to be released as 7.x-1.0-alpha4.
Comment #11
joelstein commentedFantastic. Thanks!
Comment #12
Sherbet commentedis it me or does Crumbs still not appear to have a config page? I'm using 7.x-1.0-alpha4
Comment #13
donquixote commentedHi,
you need to
- drush cc menu (or just drush cc all), that is. Or from the web ui, just clear the caches.
- go to the permissions page, and enable "Administer Crumbs". (if you don't already have an admin role, where this should be enabled automatically)
- the menu item should appear at Structure > Crumbs > Settings.
I have this working on two sites now, and it does ok.
Comment #14
Sherbet commentedThat seemed to fix it!
However, upon moving lines around in the textarea I get the following error:
Notice: Undefined offset: 1 in crumbs_admin_form_submit() (line 208 of C:\xampp\htdocs\final\sites\all\modules\crumbs\crumbs.admin.inc).
Comment #15
donquixote commentedIn the crumbs.admin.inc, if you replace the respective code like this, does it help?
Comment #16
donquixote commented#15 committed and release as 7.x-1.0-alpha5
Comment #17
Sherbet commentedUpdating to the latest build did not fix the issue, unfortunately.
Comment #18
donquixote commentedI updated the issue summary. Can you check?
Comment #19
Sherbet commentedI was actually referring to the issue with the offset which was supposedly fixed in alpha5, but does not seem to work for me. The initial issue of the menu not showing up was solved by clearing caches.
Comment #20
donquixote commentedOops. Ok. Can you do a bit of debugging yourself?
Comment #22
donquixote commentedJust pushed another fix for the bug reported in #14.
It had to be
+ array(NULL, NULL)instead of just+ array(NULL).This is going to be 7.x-1.0-alpha6.
Comment #22.0
donquixote commentedSteps to check, before you complain.