1. if i move the mouse over "sort" link i get an security warning in IE
2. HTML Tidy tells me 1 error, please make the code valid
3. CSS Footerlinks are very very small and unreadable - please correct this or simply and better *remove* it. i'd like the last most!
4. make all linked images local, do not load them from google or baccoubonneville. Don't give their sites a tracking hit, please!
5. remove the Googleization... make it general

Comments

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

As you can probably guess, we an unmodified XSL file created by someone else.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Category: bug » feature
darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Active » Closed (won't fix)

After looking into the license for gss.xsl, I found that we are not allowed to remove the copyright notice. See issue 140082.

hass’s picture

hass commented
Status: Closed (won't fix) » Active

sounds like we cannot remove this footer, but nevertheless we should fix the rest of the above listed bugs!

hass’s picture

hass commented
Category: feature » bug

sounds like we cannot remove this footer, but nevertheless we should fix the rest of the above listed bugs!

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Active » Closed (won't fix)

The reason I set this to "won't fix" is that we may have to remove this file entirely due to licensing issues.

hass’s picture

hass commented
Status: Closed (won't fix) » Active

so i reopen this now, while the other licensing case has been closed and the bugs are open.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

In response to the bugs as listed:

  1. I haven't gotten the XSL file working at all on IE5, the only version available to me.
  2. Why are you using HTML Tidy on an XSL file?
  3. The footer has been removed in CVS commit 67070.
  4. There would need to be a way to get the correct URLs into the gss.xsl file based on where the user installed the module.
  5. References to Google have been removed.
hass’s picture

hass commented

1. i tested with IE 6.0
2. not on the XSL, on the HTML output created by the XSL

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

The XSL file does not create HTML output. It simply manipulates the sitemap XML data. HTML Tidy does not fully support XML.

So that leaves two issues. Someone will need to work on making it compatible with IE6 (maybe you, Hass?), and we need to decide if it would be worth making all the files local. This could be done by generating gss.xsl when the module is enabled or by using menu callbacks to return the files.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Version: 5.x-1.7 » 5.x-1.x-dev
darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Active » Closed (won't fix)

Since these are not really bugs and no one has taken on this issue, I'm setting the status to "won't fix".

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Closed (won't fix) » Fixed

Fixed in CVS commit 84032. sitemaps.css is no longer available from Google. If anyone has a copy, I'll add the styles to gss.css.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)