By sumeet.pareek on

I had a few patches to submit and (like all things drupal) I wanted to do it right. Here are the questions I have -

  1. How should patches be submitted such that they are queued for testing by qa.drupal.org?

    For example the patch here was queued (http://drupal.org/node/1398664#comment-5447290), but this other was not (http://drupal.org/node/1360202#comment-5420518)

  2. Against what version of the module should the patch be made?

    Some module maintainers suggest it should be made against the HEAD so that the patches make it to the module in the process of development. If I really have modified the stable release of a module to give me more related functionality, I want others to have it too and not wait until the next stable version is out. Hence, the confusion.

⋅ Categories: Drupal 7.x, Drupal 8.x

Comments

Refineo’s picture

Refineo commented

I found the answer in Automated patch testing (qa.drupal.org):

Patches are tested if:

The issue is set to "Code Needs Review" or " Reviewed and Tested By the Community" (for more information on status settings, see status settings for an issue)
The patch file has a .patch or .diff extension
The patch has not already failed testing; you can reset manually if you think
something went wrong

Patches are skipped if the file name (before the .patch or .diff extension) ends with something like -d5 or _d4. For example somefile-d9.patch and somefile_d2.patch is skipped.

Patches are queued for testing when submitted, and also retested every 24 hours on a rotating basis (provided they previously passed all tests, and still meet the criteria listed above) to ensure they continue to work with changes to core. Under normal circumstances, test results should be returned to for any testable patches submitted within one hour.