A lot of code—especially the JavaScript—in this module could use a little once-over to help conform to Drupal's coding standards...

CommentFileSizeAuthor
#3 code-style-cleanup-1402180-3.patch20.1 KBgeerlingguy
#1 code-style-cleanup-1402180-1.patch19.8 KBgeerlingguy

Comments

geerlingguy’s picture

geerlingguy commented
Status: Active » Needs review
StatusFileSize
new code-style-cleanup-1402180-1.patch19.8 KB

Patch for Drupal 7 (untested).

geerlingguy’s picture

geerlingguy commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed to D7: http://drupalcode.org/project/wysiwyg_linebreaks.git/commit/169862e

Going to try to get the same changes into D6 now... should be almost exactly the same.

geerlingguy’s picture

geerlingguy commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new code-style-cleanup-1402180-3.patch20.1 KB

Patch for D6 attached. Testing now...

geerlingguy’s picture

geerlingguy commented
Status: Needs review » Fixed

Committed to D6: http://drupalcode.org/project/wysiwyg_linebreaks.git/commit/319c561

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.