Installation does not work

I've moved the install stuff in to its own file as suggested. I never had a problem the old way, but maybe this works for some setups?

Have committed change to CVS 5.x-dev for now.

Re-opened because AFAIKS there is no CVS 5.x-dev version available for download.
Not even on the all releases page.

The official 5.x-1.1 version on the module home page does not work at all for me - running drupal 5.3

I'm running drupal 5.5

return-path HEAD works for me after making these change to returnpath.module version 1.6

VERSION 1.6

  function drupal_mail_wrapper($mailkey, $to, $subject, $message, $headers) {
    $matches = array();
    preg_match("/return-path:?(.*)/i", $headers, $matches);
    $from = isset($matches[1]) ? "-f{$matches[1]}" : '';

LOCAL COPY CHANGES

  function drupal_mail_wrapper($mailkey, $to, $subject, $message, $from, $headers) {
    // $matches = array();
    // preg_match("/return-path:?(.*)/i", $headers, $matches);
    // $from = isset($matches[1]) ? "-f{$matches[1]}" : '';
    $from = "-f $from";

As you can see $from was not being sent to drupal_mail_wrapper and therefore not being used.

Hope this helps someone.

Due to poor reading of the issue queue AND not looking for the "HEAD" release, I coded the fix to this myself.

You can download Agaric's slightly modified version of the module here:

http://agaricdesign.com/sites/agaricdesign.com/files/returnpath-mod.zip

It just pulls out the install and uninstall functions (uninstall for this module should perhaps be in a 'disable' function if such a thing exists? As the module isn't truly disabled until it is uninstalled.) We can provide a patch from this to either the official release 1.1 or HEAD (which is broken in the different way described above).

In the meantime, if you want a download of this very nice module that just works for Drupal 5, you can grab it at the link above.

^{benjamin, Agaric Design Collective}

Thanks. Everyone should download from the link cited in #5. That properly installs the module.

PLEASE UPDATE THE OFFICIAL

Check this patch: http://drupal.org/node/242652

I downloaded the official 5.x-1.1 release and had to find out it does not work as advertised. After reading this issue, I understood why.
It's a pity that this module is maintained as it should be. Please create a new release with the patch applied from http://drupal.org/node/242652

This issue has been fixed in the latest 5.x-1.x-dev.

Full release will be out as soon as I'm satisfied with the changes.

I believe it is wrong for this issue to be closed, since the official 5.x release still does nothing after it's installed. I ended up repeating the work several posters already did - moving the install/uninstall code to a returnpath.install file - in order to make this module do anything.

I hope the maintainer releases a functioning 5.x version of this module soon.

Should have been marked as 5.x-1.x-dev.
Closed.