I wanted to reorder my mappings to get the columns in the template CSV file in the right order. But to do this I had to remove all mappings and add them again. That's not fun... so I wrote a patch that's add a weight column and tabledrag for some easy reordering.

CommentFileSizeAuthor
#2 1410296-reorder-mappings.patch4.82 KBvinmassaro
#1 feed_ui_reorder_mappings-1410296-1.patch3.46 KBlogaritmisk

Comments

logaritmisk’s picture

logaritmisk commented
Status: Active » Needs review
StatusFileSize
new feed_ui_reorder_mappings-1410296-1.patch3.46 KB
vinmassaro’s picture

vinmassaro commented
StatusFileSize
new 1410296-reorder-mappings.patch4.82 KB

This is a very helpful feature for an importer I am building with over 30+ mappings that will eventually need to be reordered. Your patch worked for me except when there were no mappings defined and I clicked 'Save' on the feed importer. It returned an error because $mappings was empty, so I added a condition to check if it's empty. I've rolled a new patch against 7.x-2.x that is git aware and combines these changes. Thanks!

anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented
Status: Needs review » Reviewed & tested by the community

Awesome, the patch in #2 works perfect, don't know what more to say. Grate job both of you!

twistor’s picture

twistor commented
Status: Reviewed & tested by the community » Needs work

Very nice!

An error is thrown when you remove a mapping because the arrays are different sizes. Also, this should have a test that goes through the basic functionality to avoid regressions.

I like it.

twistor’s picture

twistor commented
Status: Needs work » Fixed

Committed in http://drupalcode.org/project/feeds.git/commit/dde0b25.

Patch did not apply, so I re-rolled and fixed the issue I mentioned. Tests coming up next.

This could be backported.

twistor’s picture

twistor commented
Version: 7.x-2.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)
twistor’s picture

twistor commented
Version: 6.x-1.x-dev » 7.x-2.x-dev
Issue summary: View changes
Status: Patch (to be ported) » Closed (fixed)

Not backporting things at things point. If someone wants to provide a patch, go for it.