Changing the language of a simplenews node throws a PDO error

Issue Summary

To reproduce:

On a clean install, enable i18n and simplenews.

Activate at least two languages, and make the Simplenews newsletter content type translatable.

Create a newsletter node in any language.

Edit the same node, and change the language.

The following error is thrown:

This is due to the language handling of the nodes in Drupal core.

In simplenews_get_term_values() (copied below for reference), when the language has been changed, the $node->{$category_field['field_name']} property returns a two element array (or possibly more depending on how many active languages there are) which contains a valid entry for the current language, and an empty value for the old language.

So, current($taxonomy) may return an empty value.


function simplenews_get_term_values($node) {
$category_field = simplenews_get_category_field($node->type);
$taxonomy = $node->{$category_field['field_name']};
$term = current($taxonomy);
if (!empty($term)) {
return $term;
}
return FALSE;
}

I'm including a patch which prefers the term associated to the current language of the node.