I'm just playing in a vanilla Drupal install with the 1.x-dev branch as of Jan 19, and got an the following unhelpful error when trying to install only party and party_hat:

Parse error: syntax error, unexpected T_PAAMAYIM_NEKUDOTAYIM in modules/party/party.module on line 91

I'm not sure where the "T_PAAMAYIM_NEKUDOTAYIM" is coming from, but I commented out link 91 and that fixed the problem:
$set['class']::hook_entity_info_alter($entity_info[$set['entity type']]);

But I'm probably breaking something in the process.

CommentFileSizeAuthor
#12 1410882.party_.party_entity_info_alter-callable-php52.patch529 bytesjoachim
#7 party-syntax-error-in-party-module-1410882-.patch528 bytesfinn lewis

Comments

that0n3guy’s picture

that0n3guy commented

I'm also seeing this. I think its a php 5.2 issue. I changed to 5.3 and was able to install just fine.

I'm no php pro, but I think the solution would be to change:
$set['class']::hook_entity_info_alter($entity_info[$set['entity type']]);

to something like:
call_user_func($set['class'].'::'.hook_entity_info_alter($entity_info[$set['entity type']]));

I'm not sure if my syntax is right, but it seemed to work on my local install. But you said deleting it completely worked too so my fix may have done nothing.

that0n3guy’s picture

that0n3guy commented

Ok that didn't work.... after enabling party_hats and party_profile2 I got:

Fatal error: Call to undefined function hook_entity_info_alter() in sites\all\modules\party\party.module on line 91

I guess my googling wasn't as ninja as I thought. Someone wiser than I will have to look at it. For now, I'll just use php 5.3

rlmumford’s picture

rlmumford
Primary language English
Location Manchester
commented

At the moment Party is known to only work with PHP 5.3 because of the way the CRM Controller works. But i didn't realise there was a problem in party.module as well. Probably worth checking this out in more detail.

I would be happy to edit this to use call_user_func() but would only do it if it could be tested thoroughly. If one of you can test that it works with call user func I'll happily put a patch in. thanks for your interest!

joachim’s picture

joachim commented

> At the moment Party is known to only work with PHP 5.3 because of the way the CRM Controller works

I thought most of that had been removed from the controller class?

joachim’s picture

joachim commented 
call_user_func($set['class'].'::'.hook_entity_info_alter($entity_info[$set['entity type']]));

Probably want this: http://www.php.net/manual/en/language.pseudo-types.php#language.types.ca...

finn lewis’s picture

finn lewis
Location Oxford
commented

Using PHP 5.2.13 - I get the error mentioned by the OP - changing this line as per joachim's suggestion does get around this error.

I am now switching to PHP 5.3 :)

finn lewis’s picture

finn lewis
Location Oxford
commented
StatusFileSize
new party-syntax-error-in-party-module-1410882-.patch528 bytes

Patch attached

joachim’s picture

joachim commented
Status: Active » Fixed

Committed, thanks!

joachim’s picture

joachim commented

Nope, this doesn't work.

I think you have to give an array instead of a function name...

dimmech’s picture

dimmech commented

Just a heads up... this issue is currently marked as fixed and is not. Error is now on line 102.

joachim’s picture

joachim commented
Status: Fixed » Active

Indeed. Let's reopen.

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 1410882.party_.party_entity_info_alter-callable-php52.patch529 bytes

Could someone on PHP 5.2 try this patch please?

dimmech’s picture

dimmech commented

No errors with the patch in #12, Party enabled successfully!

joachim’s picture

joachim commented
Status: Needs review » Fixed

Thanks for testing! Do please report any further problems you have running Party on PHP 5.2.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

details added