Download & Extend

Remove search-result.tpl and adaptivetheme_preprocess_search_result() to allow modules to customize search results

Project:AdaptiveTheme
Version:7.x-3.x-dev
Component:CSS/HTML
Category:feature request
Priority:normal
Assigned:Jeff Burnz
Status:closed (fixed)

Issue Summary

Hi i have found that pixture reloaded 2.2. is overiding the settings i specifiy for configuring the search results page using either the custom search module http://drupal.org/project/custom_search or the search configuration module http://drupal.org/project/search_config module

if i test with bartik everything works fine could you tell me what is likeley to be cuasing the overide and provide a fix if possible

i also reported the issue here http://drupal.org/node/1412730

Comments

#1

Title:overiding search results page settings» Remove search-result.tpl and adaptivetheme_preprocess_search_result() to allow modules to customize search results
Project:Pixture Reloaded» AdaptiveTheme
Version:7.x-2.2» 7.x-2.x-dev
Category:bug report» feature request
Priority:major» normal
Assigned to:Anonymous» Jeff Burnz

I cant see anyway of using these modules with this theme without hacking the core theme, which is not good.

Really this is not a bug, its just a conflict between a module and a theme both using the same theme layer features and the fact that the theme always gets the last say in how things are processed.

This is not Pixture Reloaded issue either, its the core Adaptivetheme that is doing the damage here. The only way to really fix this is to remove the preprocess function and the search-result-tpl file from Adaptivetheme, its really as simple as that.

I think I will do this - mainly because the features that are provided by the theme are mostly replicated by one of those modules AND those are very useful modules that we should be able to work with nicely.

NOTE: have you tried the search form customization features that Custom Search module has, because this theme runs a massive form alter on the advanced search form...

#2

Beware that if you do this yourself has a hacking experiment you need to clear drupal cache before testing with a search, or else your site will crash and burn.

#3

I don’t want to hack the core adaptive theme
So I will wait for your fix and just disable advanced search for now
I am using the custom search module to limit searchable content types and alter the search block so I can filter results by taxonomy terms (meaningful groups of content types) from a pop up just like on drupal.org
I can live without this feature and the other advanced search options on the search results page for now
Its a shame these search configuration options are not available in drupal core - i cannot imagine a site that that the current available configuration options would saticfy
Thanks for a great theme by the way very simple and easy to use considering its adaptive capabilities

#4

Just wanted to make sure we where on the same page with this

it not just the presentation of results as specified by search-result.tpl.php thats being effected -
i cannot alter/overide anything on the advanced help collapisble form (at top of results page) via the custom search module

Thanks

#5

Yep, I know. Thats what I was talking about with the form alter this theme runs. I will need to think about how to tackle this because that form alter is there for a reason (accessibility), but there will be a way around this.

#6

Version:7.x-2.x-dev» 7.x-3.x-dev
Component:Code» CSS/HTML
Status:active» closed (fixed)

I did remove all custom search features in 3.x branch, the form alter is now optional also.