Hi @all,

I just found a little bug in the og_forum_db_rewrite_sql, which results in a wrong forum dropdown on the add/edit form for normal forum topics.

In the second if statement of the function you only check for arg(3), but do not verify that this is really a term id that belongs to an organic group forum... So the forum dropdown for normal forum posts do only show group forums, when coming from a link like "node/add/forum/99".

Do you see a chance to fix this problem soon? I ask, because I need this module urgent for a project, and I don't want to change it on my own, because of compatibility needs with the next version of this module.

So I'd really appreciate your fix & hopefully a new version of this module with this fix in it within the next days :-)

Thanx a lot & cheers

hctom

CommentFileSizeAuthor
#3 og_forum.fix taxonomy select on edit.patch731 bytesmarkDrupal

Comments

hctom’s picture

hctom
Primary language German
commented

ooops... I'm sorry, I had my filters turned on, so i did not see other posts for this problem.

So this is kind of a duplicate, but, what do you think, this bugfix will be merged into the new version?

Cheers

hctom

rconstantine’s picture

rconstantine commented
Version: 5.x-1.3 » 5.x-2.x-dev
Assigned: Unassigned » rconstantine
Status: Active » Closed (duplicate)
markDrupal’s picture

markDrupal commented
Status: Closed (duplicate) » Needs review
StatusFileSize
new og_forum.fix taxonomy select on edit.patch731 bytes

I was having problems where the taxonomy default value was being deleted when I tried to edit a forum post.
So if I clicked the edit button, the forum select always defaults to the lightest weight forum or container. This is the fix I applied to the CVS version of the module.

rconstantine’s picture

rconstantine commented

I've looked at the patch, but not where it goes in the code yet. To clarify: by taxonomy, do you mean the forum selector where you decide where the topic post is going? Or do you mean when someone is actually using a regular taxonomy selector on their forum topic content type?

rconstantine’s picture

rconstantine commented

I went ahead and added it. Will upload to CVS soon. The code seemed clean to me.

That same function would be where we could hide the drop down, but I haven't looked at doing it since I've done so many more modules and know a bit more about what I'm doing. I'd like to give the admin an option of forcing users to post to the forum they're in when they write a new message. This latter would activate the former. Feel free to tackle this yourself. I've appreciated your patches as you can tell.

rconstantine’s picture

rconstantine commented
Status: Needs review » Fixed
markDrupal’s picture

markDrupal commented

The taxonomy I mean was the forum selector. if you edit a post say in the "Car talk forum" the forum selector does not automatically select the "Car talk forum" instead it defaults to the lightest weight forum or container. In other words it selects whatever is at the top of the forum selector list.

rconstantine’s picture

rconstantine commented

I just noticed that I screwed up which branch I was uploading changes to. I thought I had changed to be uploading to the 5--2 branch, but I have been uploading to the 5 branch in CVS. Which explains why there hasn't been a new tarball. The 5--2 branch was still based on the 5-1-3 code, and not my new stuff. So could you recheck this bug for me? And in the future, look for my name associated with the update, or at least the age being in the last little while.

hallman’s picture

hallman commented
Priority: Critical » Normal
Status: Fixed » Active

The bug I see:

Select Drupal Forums from the left sidebar, Click on a particular forum, then Click "Post new forum topic." What you'd expect to happen is that the forum you've chosen would be the default in the parent dropdown. However, there aren't any choices in the parent dropdown. If you try to save the post, it fails.

I just installed og_forum-5.x-2.x-dev, 2007-Jun-29. It does not fix the problem. I am running Drupal 5.1. When I disable OG forum, the Drupal forums work OK.

Judy Hallman

rconstantine’s picture

rconstantine commented
Status: Active » Fixed

June 29th is the wrong one. I think you've already seen that here: http://drupal.org/node/156228, right?

hallman’s picture

hallman commented

Yes. Since I posted the problem twice, I should have posted a reply here too.

I had downloaded the older version. The problem is fixed in 1.5.2.1.2.1 2007/07/02 16:03:34.

Judy

rconstantine’s picture

rconstantine commented
Status: Fixed » Closed (fixed)