I have created a couple formatters to integrate with the static maps and streetview images from http://code.google.com/apis/maps/documentation/staticmaps/. I pushed it to a sandbox module. Do you think it would make sense as an integrated module (like geofield_maps), or should I create a separate project?

http://drupal.org/sandbox/jlyon/1415810

Comments

Brandonian’s picture

Thanks for the contribution, @jlyon! I would prefer a separate module over a submodule in Geofield.

I don't know if you're aware or not, but there's another module (http://drupal.org/project/staticmap) that does a similar job, but in a much more convoluted manner. I'm also the maintainer of that module, and if you're interested, I'd be willing to let you have git access to that module to do integration work there. I haven't had much interest in maintaining that module lately, but I do think it fills an important niche in the Drupal mapping space and would love to see somebody do something interesting with it.

jlyon’s picture

Shoot, I wish I had found that module earlier. I would be interested in doing some integration with staticmap. Are you tied to sticking with the ctools integration, or should I look into converting it over to formatters? Thanks!

Brandonian’s picture

Project: Geofield » Static Map

Not a problem, @jlyon. I've added you as a maintainer to the project.

I think simplifying the module wouldn't be a bad idea. Some of the framework that I started with this module has been superseded to the Mapping module (http://drupal.org/project/mapping), which I haven't had a chance to port over yet. If you'd like, you either start a new branch, or integrate your code into what's there now.

Thanks again for the contribution!

rooby’s picture

I wrote this patch before I realised this issue existed (stupid me).

I don't mean to step on anybody's toes who has already written code but my patch adds to staticmap's google provider, pretty much all the options that google allows.

Most useful to me being custom map styles and custom image markers, which geofield_images does not yet provide.

It would be great if both of you could take a look and tell me what you think.

I think the API style appraoch of staticmap is preferrable to the geofield_images approach - being able to create different presets, which are exportable.

What is missing is alt and title text and link, which geofield_images has but staticmap currently doesn't.

I'm happy to do some more work on staticmap, to add those features, although they are not specific to this issue 'Integration with Google Static Map API' so the link & alt & title texts should have a separate issue.

rooby’s picture

Assigned: Unassigned » rooby

Assigning to me - I'm happy to do whatever needs to be done to get this in.

rooby’s picture

Bumping for some maintainer input/review if possible.

Lazarus-Long’s picture

rooby’s picture

Thanks for the progress. I should be able to test in a couple of days.

floretan’s picture

Status: Needs review » Reviewed & tested by the community

I tested the patch and everything works great. Make sure that the path your custom icon is publicly reachable.

chrowe’s picture

Version: 7.x-1.x-dev » 7.x-1.0-alpha2

This patch does not apply to the dev release any more but does apply cleanly to 7.x-1.0-alpha2

Google Maps is still having the issue I reported in http://drupal.org/node/1864464 but the option show up and seem to work.

Open Street Map returns maps but does not seem to be respecting the map size option.

rooby’s picture

Did you test the patch in this issue in #4 or the patch at #1205540-8: Error message in admin/structure/types/manage/my-content-type/display ?

davidwhthomas’s picture

Looks like the patch in #4 should be using drupal_http_build_query

rooby’s picture

StatusFileSize
new15.38 KB

The patch in #4 is not the latest version.
The patch refered to in #7 is (although I have yet to get a chance to check it out).

This is that same patch, so people don't miss it.

Sinovchi’s picture

The patch refered to in #7 and attached in #13 is worked for me.

podarok’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Needs review

Status: Needs review » Needs work

The last submitted patch, 13: staticmap-1415814-13.patch, failed testing.