Node_Version Scheduler [#1417054]

The key feature of node version scheduler is, when editing an existing node and saving it into a new version. It is now possible to postpone the newest node version by a day or an hour or five minutes.
It means that if the newest version scheduling time is in the future, the VID on the node table is not changed until the scheduler tells it to

Comment	File	Size	Author
	node_version_publish_date.png	5.5 KB	Christian Heiberg

Comments

Comment #1

rudiedirkx commented 28 January 2012 at 05:09

Status:

Needs review

» Needs work

See step 4 of the process @ Applying for permission to create full projects (which is where you posted this issue).

At the very least we need a link to your project page.

Comment #2

jthorson commented 30 January 2012 at 06:10

Title:	Need a code walk through on my "node_version scheduler" project	» Node_Version Scheduler
Status:	Needs work	» Needs review

Sandbox link: http://drupal.org/sandbox/ChristianHeiberg/1416470

Comment #3

jthorson commented 30 January 2012 at 06:10

Assigned:

Christian Heiberg

» Unassigned

Comment #4

nmudgal commented 30 January 2012 at 07:18

Status:

Needs review

» Needs work

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

README.txt is missing, see the guidelines for in-project documentation.

Remove all old CVS $Id tags, they are not needed anymore.

node_version_scheduler.views.inc:2:// $Id: scheduler.views.inc,v 1.1.2.5 2010/12/22 14:28:57 ericschaefer Exp $

Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards

sites/all/modules/pareview_temp/test_candidate/./node_version_scheduler.views.inc:
 +2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file.

Status Messages:
 Coder found 2 projects, 2 files, 1 minor warnings, 0 warnings were flagged to be ignored

FILE: ...es/all/modules/pareview_temp/test_candidate/node_version_scheduler.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 5 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...all/modules/pareview_temp/test_candidate/node_version_scheduler.install
--------------------------------------------------------------------------------
FOUND 13 ERROR(S) AND 1 WARNING(S) AFFECTING 11 LINE(S)
--------------------------------------------------------------------------------
  9 | WARNING | Format should be "* Implements hook_foo()." or "Implements
    |         | hook_foo_BAR_ID_bar() for xyz_bar."
 10 | ERROR   | Function doc comment must end on the line before the function
    |         | definition
 12 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
 15 | ERROR   | Do not use t() in hook_schema(), this will only generate
    |         | overhead for translators
 18 | ERROR   | Do not use t() in hook_schema(), this will only generate
    |         | overhead for translators
 24 | ERROR   | Do not use t() in hook_schema(), this will only generate
    |         | overhead for translators
 30 | ERROR   | Do not use t() in hook_schema(), this will only generate
    |         | overhead for translators
 45 | ERROR   | Missing function doc comment
 45 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
 48 | ERROR   | Missing function doc comment
 48 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
 54 | ERROR   | Missing function doc comment
 54 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
 56 | ERROR   | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: .../all/modules/pareview_temp/test_candidate/node_version_scheduler.module
--------------------------------------------------------------------------------
FOUND 152 ERROR(S) AND 12 WARNING(S) AFFECTING 108 LINE(S)
--------------------------------------------------------------------------------
   2 | ERROR   | Missing file doc comment
   6 | WARNING | Format should be "* Implements hook_foo()." or "Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar."
   8 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
  17 | ERROR   | Function doc comment must end on the line before the function
     |         | definition
  19 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
  20 | ERROR   | An operator statement must be followed by a single space
  20 | ERROR   | Space before closing parenthesis of function call prohibited
  27 | ERROR   | Array indentation error, expected 8 spaces but found 6
  28 | ERROR   | Array indentation error, expected 8 spaces but found 6
  29 | ERROR   | Array indentation error, expected 8 spaces but found 6
  30 | ERROR   | Array indentation error, expected 8 spaces but found 6
  31 | ERROR   | Array indentation error, expected 8 spaces but found 6
  32 | ERROR   | Array indentation error, expected 8 spaces but found 6
  32 | WARNING | Avoid backslash escaping in translatable strings when
     |         | possible, use "" quotes instead
  33 | ERROR   | Array closing indentation error, expected 6 spaces but found 4
  34 | ERROR   | Whitespace found at end of line
  46 | WARNING | Format should be "* Implements hook_foo()." or "Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar."
  48 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
  58 | ERROR   | Array indentation error, expected 8 spaces but found 6
  59 | ERROR   | Array indentation error, expected 8 spaces but found 6
  60 | ERROR   | Array indentation error, expected 8 spaces but found 6
  61 | ERROR   | Array indentation error, expected 8 spaces but found 6
  62 | ERROR   | Array indentation error, expected 8 spaces but found 6
  63 | ERROR   | Array closing indentation error, expected 6 spaces but found 4
  65 | ERROR   | Array indentation error, expected 8 spaces but found 6
  66 | ERROR   | Array indentation error, expected 8 spaces but found 6
  67 | ERROR   | Array indentation error, expected 8 spaces but found 6
  68 | ERROR   | Array indentation error, expected 8 spaces but found 6
  69 | ERROR   | Array indentation error, expected 8 spaces but found 6
  70 | ERROR   | Array closing indentation error, expected 6 spaces but found 4
  74 | ERROR   | Inline comments must start with a capital letter
  74 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
  75 | ERROR   | You must use "/**" style comments for a function comment
  75 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
  78 | ERROR   | Line indented incorrectly; expected 2 spaces, found 6
  80 | ERROR   | Line indented incorrectly; expected 4 spaces, found 6
  83 | ERROR   | Closing brace indented incorrectly; expected 6 spaces, found 4
  87 | ERROR   | Missing function doc comment
  87 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
  95 | WARNING | Format should be "* Implements hook_foo()." or "Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar."
  96 | ERROR   | Function doc comment must end on the line before the function
     |         | definition
  98 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
 102 | ERROR   | Missing function doc comment
 102 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
 103 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 106 | ERROR   | Expected "if (...) {\n"; found "if(...) {\n"
 106 | ERROR   | Line indented incorrectly; expected 2 spaces, found 6
 107 | ERROR   | Line indented incorrectly; expected 4 spaces, found 8
 107 | ERROR   | Expected 0 spaces before closing bracket; 1 found
 110 | ERROR   | Whitespace found at end of line
 113 | ERROR   | Whitespace found at end of line
 119 | ERROR   | Expected "}\nelse {\n"; found "}\nelse {"
 119 | ERROR   | else must start on a new line
 119 | ERROR   | Line indented incorrectly; expected 2 spaces, found 6
 119 | ERROR   | Closing brace must be on a line by itself
 120 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 124 | WARNING | Format should be "* Implements hook_foo()." or "Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar."
 126 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
 128 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 129 | ERROR   | Line indented incorrectly; expected 4 spaces, found 6
 134 | ERROR   | Line indented incorrectly; expected 6 spaces, found 8
 135 | ERROR   | Concat operator must be surrounded by spaces
 135 | ERROR   | Concat operator must be surrounded by spaces
 135 | ERROR   | Concat operator must be surrounded by spaces
 135 | ERROR   | Space found before comma in function call
 135 | ERROR   | Space found before comma in function call
 135 | ERROR   | Concat operator must be surrounded by spaces
 135 | ERROR   | Concat operator must be surrounded by spaces
 138 | WARNING | Line exceeds 80 characters; contains 87 characters
 138 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 3
 138 | ERROR   | Inline comments must start with a capital letter
 138 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 139 | ERROR   | Expected "if (...) {\n"; found "if(...){"
 139 | ERROR   | An operator statement must be followed by a single space
 139 | ERROR   | Closing brace must be on a line by itself
 139 | ERROR   | Expected "}\nelse {\n"; found "}\nelse{"
 139 | ERROR   | else must start on a new line
 139 | ERROR   | Closing brace must be on a line by itself
 144 | ERROR   | Space found before comma in function call
 144 | ERROR   | Space found before comma in function call
 158 | ERROR   | You must use "/**" style comments for a function comment
 158 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
 160 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 161 | ERROR   | Whitespace found at end of line
 162 | ERROR   | Line indented incorrectly; expected 4 spaces, found 8
 163 | ERROR   | Line indented incorrectly; expected 6 spaces, found 8
 165 | ERROR   | Line indented incorrectly; expected 8 spaces, found 10
 168 | ERROR   | else must start on a new line
 168 | ERROR   | Line indented incorrectly; expected 8 spaces, found 10
 171 | ERROR   | Break statement indented incorrectly; expected 10 spaces,
     |         | found 8
 172 | ERROR   | Line indented incorrectly; expected 6 spaces, found 8
 174 | ERROR   | Whitespace found at end of line
 175 | ERROR   | Line indented incorrectly; expected 8 spaces, found 10
 176 | ERROR   | Inline comments must start with a capital letter
 176 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 177 | ERROR   | Expected "if (...) {\n"; found "if(...) {"
 177 | ERROR   | Line indented incorrectly; expected 10 spaces, found 12
 177 | ERROR   | Closing brace must be on a line by itself
 178 | ERROR   | Whitespace found at end of line
 179 | ERROR   | Expected "if (...) {\n"; found "if(...) {\n"
 179 | ERROR   | Line indented incorrectly; expected 10 spaces, found 12
 179 | ERROR   | An operator statement must be followed by a single space
 180 | WARNING | Line exceeds 80 characters; contains 129 characters
 180 | ERROR   | Inline comments must start with a capital letter
 180 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 183 | WARNING | Line exceeds 80 characters; contains 118 characters
 183 | ERROR   | Inline comments must start with a capital letter
 183 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 184 | ERROR   | Expected "if (...) {\n"; found "if(...){\n"
 184 | ERROR   | Line indented incorrectly; expected 12 spaces, found 14
 188 | ERROR   | Expected "if (...) {\n"; found "if(...){\n"
 188 | ERROR   | Line indented incorrectly; expected 14 spaces, found 16
 190 | WARNING | Line exceeds 80 characters; contains 121 characters
 190 | ERROR   | 2 spaces found before inline comment; expected "//
     |         | $node->field_log[6]['value'] = "current_revision_id
     |         | =".current_revision_id. " node id = ".$node->nid;" but found
     |         | "//  $node->field_log[6]['value'] = "current_revision_id
     |         | =".current_revision_id. " node id = ".$node->nid;"
 191 | WARNING | Line exceeds 80 characters; contains 110 characters
 194 | ERROR   | Expected "if (...) {\n"; found "if(...) {\n"
 194 | ERROR   | Line indented incorrectly; expected 12 spaces, found 14
 195 | ERROR   | Whitespace found at end of line
 196 | ERROR   | Expected "if (...) {\n"; found "if(...){\n"
 196 | ERROR   | Line indented incorrectly; expected 14 spaces, found 16
 197 | WARNING | Line exceeds 80 characters; contains 109 characters
 197 | ERROR   | Inline comments must start with a capital letter
 202 | ERROR   | Line indented incorrectly; expected 10 spaces, found 12
 206 | ERROR   | else must start on a new line
 206 | ERROR   | Line indented incorrectly; expected 8 spaces, found 10
 209 | ERROR   | Closing brace indented incorrectly; expected 10 spaces, found
     |         | 14
 209 | ERROR   | Whitespace found at end of line
 210 | ERROR   | Break statement indented incorrectly; expected 10 spaces,
     |         | found 8
 211 | ERROR   | Line indented incorrectly; expected 6 spaces, found 8
 213 | ERROR   | Break statement indented incorrectly; expected 10 spaces,
     |         | found 8
 214 | ERROR   | Line indented incorrectly; expected 6 spaces, found 8
 217 | ERROR   | Break statement indented incorrectly; expected 10 spaces,
     |         | found 8
 222 | ERROR   | You must use "/**" style comments for a function comment
 222 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
 225 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 231 | ERROR   | Missing function doc comment
 231 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
 233 | ERROR   | No space found after comma in function call
 233 | ERROR   | No space found after comma in function call
 234 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 238 | ERROR   | Expected "}\nelse {\n"; found "}\n\nelse {"
 238 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 238 | ERROR   | Closing brace must be on a line by itself
 241 | ERROR   | Missing function doc comment
 241 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
 243 | ERROR   | No space found after comma in function call
 244 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 245 | ERROR   | Line indented incorrectly; expected 4 spaces, found 6
 245 | ERROR   | Expected 0 spaces before closing bracket; 1 found
 252 | ERROR   | Expected "}\nelse {\n"; found "}\n\nelse {"
 252 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 252 | ERROR   | Closing brace must be on a line by itself
 256 | WARNING | Format should be "* Implements hook_foo()." or "Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar."
 257 | ERROR   | Function doc comment must end on the line before the function
     |         | definition
 259 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
 266 | ERROR   | Array indentation error, expected 10 spaces but found 8
 271 | ERROR   | Missing function doc comment
 271 | ERROR   | Line indented incorrectly; expected 0 spaces, found 2
 273 | ERROR   | No space found after comma in function call
 274 | ERROR   | Expected "if (...) {\n"; found "if(...) {\n"
 274 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 275 | ERROR   | Concat operator must be surrounded by spaces
 279 | ERROR   | Missing function doc comment
 283 | ERROR   | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...l/modules/pareview_temp/test_candidate/node_version_scheduler.views.inc
--------------------------------------------------------------------------------
FOUND 9 ERROR(S) AND 1 WARNING(S) AFFECTING 6 LINE(S)
--------------------------------------------------------------------------------
  2 | ERROR   | You must use "/**" style comments for a file comment
  2 | ERROR   | There must be no blank line following an inline comment
  7 | ERROR   | Function doc comment must end on the line before the function
    |         | definition
 12 | ERROR   | Inline comments must start with a capital letter
 12 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
    |         | question marks
 15 | WARNING | Line exceeds 80 characters; contains 86 characters
 15 | ERROR   | 4 spaces found before inline comment; expected "// 'field' =>
    |         | 'nid AND {node}.vid = {version_scheduler}.vid'," but found "// 
    |         |   'field' => 'nid AND {node}.vid = {version_scheduler}.vid',"
 15 | ERROR   | Comments may not appear after statements.
 16 | ERROR   | Array closing indentation error, expected 2 spaces but found 4
 18 | ERROR   | Inline comments must start with a capital letter
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview - PAReview.sh online service

Comment #5

johnpitcairn commented 30 January 2012 at 08:07

Duplicate functionality? The Revisioning module supplies a Revisioning Scheduler submodule which delays making the new revision "current" until a user-specified scheduled date/time.