adaptIC is a responsive theme for Drupal 7. It's best suited for blog type layouts but can be customized to suit any purpose. My goal is to create a very simple starting point for someone looking to create a responsive design.

http://drupal.org/sandbox/hamburgers/1417228
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/hamburgers/1417228.git adaptic

Reviews of other projects

http://drupal.org/node/1624760#comment-6167180
http://drupal.org/node/1660466#comment-6167140
http://drupal.org/node/1637712#comment-6159532

CommentFileSizeAuthor
#18 before.png83.14 KBigoen
#18 after.png107.17 KBigoen
#17 screenshot.png311.73 KBhamburgers
#3 pareview.txt9.49 KBalex dicianu
photo.PNG385.69 KBhamburgers
adaptIC.png81.04 KBhamburgers

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

You need to set the status to "needs review" if you want to get a review.

Get a review bonus and we will come back to your application sooner.

hamburgers’s picture

hamburgers commented
Status: Active » Needs review
hamburgers’s picture

hamburgers commented
Issue summary: View changes

added git clone line to description

alex dicianu’s picture

alex dicianu commented
Status: Needs review » Needs work
StatusFileSize
new pareview.txt9.49 KB

Hi,
I just launched an automatic review with this tool http://ventral.org/pareview. I've attached the report. It seems you have some code formatting issues. You should also check the coder module. I've done a quick test with it and it seems he has also found some issues.

You can also check the drupal coding standards. Generally it's a very good idea that people should write code the same way for a given application.

Looking into the code, in the file html.tpl.php, I saw:

<!DOCTYPE html>
<html>
  <head>

I think you should be more explicit with the doctype and html declaration like you've done in the maintenance page. Here is an example:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
  "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="ro" lang="ro" dir="ltr">

In the file contact-site-form.tpl.php.

print drupal_render($form['form_build_id']);
print drupal_render($form['form_token']);
print drupal_render($form['form_id']);

I think it would be better to just print print drupal_render($form); instead of the 3 lines. This would print the rest of the form elements and you won't have to worry about printing them separately.

hamburgers’s picture

hamburgers commented
Status: Needs work » Needs review

Thanks dicix!

I have gone through and cleaned up the code based on the recommendations of the coder module.
all files have been emptied from master except README.txt

I have also done some cleanup based on your suggestions

hamburgers’s picture

hamburgers commented

I have made some improvements to the theme with the addition of a left sidebar and support for larger monitors. CSS has also been improved. All code has been cleaned up to comply with Drupal coding standards. Coder module seems to come back clean and pareview comes back mostly clean with the exception of numerous occurrences of the following errors:

269 | ERROR | Blank lines are not allowed between class names
270 | ERROR | No style definition found on line; check for missing colon

Both of these errors are because of the media queries in the CSS file.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Sounds like false positives in drupalcs, can you open a bug report in the drupalcs issue queue about the media queries?

dudenhofer’s picture

dudenhofer commented

Hi hamburgers, I ran your code through the review again and it flagged your CSS spacing.
http://ventral.org/pareview/httpgitdrupalorgsandboxhamburgers1417228git-...

Check out the "properties" section here: http://drupal.org/node/302199

I also noticed some spacing issues in your template files, particularly on the page.tpl.php and html.tpl.php there are a lot of tab indents instead of 2 spaced indents
http://drupal.org/node/318#indenting

dudenhofer’s picture

dudenhofer commented
Status: Needs review » Needs work

updating status

hamburgers’s picture

hamburgers commented
Status: Needs work » Needs review

spacing issues in CSS and page.tpl.php have been resolved

hamburgers’s picture

hamburgers commented

thank you for your help dudenhofer

dudenhofer’s picture

dudenhofer commented
Status: Needs review » Needs work

Hi Hamburgers,

You might take a look at your fieldsets, particularly around the textareas with input format filters. The input formats options are pushed off to the side.

I also noticed that your aside classes "left" and "right" aren't wrapped in any sort of if statements, so there is always an aside container present. You might use a statement like if($page['left']) to wrap around those (similar to how the $title is handled in your page.tpl.php)

Lastly, multiple selectors should each be on a single line, look at lines 8, 280, 303, 309, and 329 of your style.css.

hamburgers’s picture

hamburgers commented
Status: Needs work » Needs review

I have made some changes related to dudenhofer's suggestions and some other minor CSS tweaks.

nitvirus’s picture

nitvirus commented

unable to clone the branch as it is asking for "hamburgers@git.drupal.org's password: "
also tried cloning the master but seems you have removed the file from it.

nitvirus’s picture

nitvirus commented
Issue summary: View changes

edited git clone line to replace master with proper branch

patrickd’s picture

patrickd commented

use:git clone --branch 7.x-1.x git.drupal.org:sandbox/hamburgers/1417228.git adaptic

scot.hubbard’s picture

scot.hubbard commented

Hi Hamburgers,

There still seems to be quite a few coding standards issues getting picked up (see http://ventral.org/pareview/httpgitdrupalorgsandboxhamburgers1417228git-...).

Looking at your code manually, I would say there are some minor issues regarding indentation (in some places there seems to be too much indentation).

In your template.php I would change the comment block from:

/**
 * Implements hook_preprocess_HOOK().
 */

to

/**
 * Implements hook_preprocess_html().
 */

Other than that, it seems to work well.

hamburgers’s picture

hamburgers commented

I have gone through the code and cleaned it up based on some suggestions from scot.hubbard.

I have also made some changes to the look of the theme to make it a little nicer out of the box.

DCS is finding issues with two files, both min.js files. I have reported this as a bug with the Drupal Code Sniffer module. Aside from this DCS and Coder module are coming back clean.

hamburgers’s picture

hamburgers commented
StatusFileSize
new screenshot.png311.73 KB
igoen’s picture

igoen commented
StatusFileSize
new after.png107.17 KB
new before.png83.14 KB

Just suggestion.

I think you could add some css to fix this one, see screenshots.

Css could be added:

.tabs ul.primary {
  line-height: 1.5em;
  white-space: normal;
}
igoen’s picture

igoen commented
Issue summary: View changes

correct git url

misc’s picture

misc commented
Status: Needs review » Postponed (maintainer needs more info)

It is almost RTBC for me - but one important issue - it seems that we fonts included are not GPL, is that correct? If so, they can not be included.

hamburgers’s picture

hamburgers commented

Thanks MiSc, I'm not certain about the font license, doesn't seem to be GPL. I've removed the font from the theme and made some edits to the CSS to compensate.

thanks again.

hamburgers’s picture

hamburgers commented
Status: Postponed (maintainer needs more info) » Needs review
hamburgers’s picture

hamburgers commented
Issue summary: View changes

corrected git link

hamburgers’s picture

hamburgers commented
Issue tags: +PAreview: review bonus

adding reviews bonus tag.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus

Looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

No objections in more than a week, so ...

Thanks for your contribution, hamburgers!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

adding links to reviewed projects