This is a mostly-javascript module written for Drupal 7 that adds some extra features to tabledrag-enabled tables: buttons beside the drag handles to move a row directly to the top or bottom of the table (useful with long lists) and a link to shuffle all the rows randomly.

Project page
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/jmorahan/1416402.git

The two icon images are from Tango which is public domain.

I've been coding for Drupal for several years and am quite familiar with module development, but Javascript isn't my usual area so any reviews or suggestions for improvement here would be appreciated.

CommentFileSizeAuthor
tabledragextra-screenshot.png13.16 KBjohn morahan

Comments

chx’s picture

chx commented

Just FYI, John is a security team member.

awebb’s picture

awebb commented

We (NBC iVillage) would really like to see John get a full account as he creates and helps maintain many of our Drupal contributions. These are tested by our internal QA team.

Thanks,
Adrian

john morahan’s picture

john morahan commented
Priority: Normal » Major

Raising the priority after 2 weeks

Robertas’s picture

Robertas commented

Review of the 7.x-1.x branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

</code></p><code>


FILE: ...review/sites/all/modules/pareview_temp/test_candidate/tabledragextra.js<br>
--------------------------------------------------------------------------------<br>
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)<br>
--------------------------------------------------------------------------------<br>
 50 | ERROR | Whitespace found at end of line<br>
--------------------------------------------------------------------------------<br>



Source: http://ventral.org/pareview - PAReview.sh online service

chrisroane’s picture

chrisroane commented
Status: Needs review » Reviewed & tested by the community

MANUAL REVIEW
--------------
I installed and enabled this module. I verified that it is working by testing it in the list terms area.

It looks great to me and I think this would be very useful. In fact, it would be great to see this merged into core. I marked this as "reviewed & tested by the community".

AUTO REVIEW
------------

- Ran the code through Coder and it looks good.

- I ran the code through the online PAReview utility and the same minor error came up as posted above.

john morahan’s picture

john morahan commented

Thanks! I've fixed that coding style issue now too.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Would you like to take part in the review bonus program? I personally only review/approve applications with a review bonus, but of course you can also wait for other git administrators to take a look at your code.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, John! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in minde: Commit messages - providing history and credit and Release naming conventions.

john morahan’s picture

john morahan commented

Thanks greg and everyone, I've promoted the project now at http://drupal.org/project/tabledragextra

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.