Similar to #870556: PuSH: verification fails the first time, unsubscribe requests to PuSH hubs are failing because of the transaction in node_delete. After discussing this with Crell we decided a queued unsubscribe approach would be appropriate: PuSH hubs can retry failed publish notifications but are not required to do so, and Drupal will just ignore a publish notification to a nonexistent feed importer.

The following patch is an attempt at fixing this issue.

CommentFileSizeAuthor
#1 1318382-1-feeds.patch1.9 KBelliotttf

Comments

elliotttf’s picture

elliotttf commented
StatusFileSize
new 1318382-1-feeds.patch1.9 KB

Patch to fix the issue.

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

This looks good to me on visual inspection. I don't know why Feeds is still using Job Scheduler, but that's not an issue for this thread. :-)

stevector’s picture

stevector
he/him
commented
Status: Reviewed & tested by the community » Needs review

Elliott, Did you test this against a hub? I'm working on the unsubscription functionality in Push Hub module. The unsubscribe POSTs I'm getting from Feeds contain an incorrect hub_callback variable.

[hub_callback] => http://default/feeds/importer/atom_article_importer/15

instead of 

[hub_callback] => http://example.com/feeds/importer/atom_article_importer/15

I will look deeper. I post a revised patch if I find anything.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #1 to Git.
http://drupalcode.org/project/feeds.git/commit/3516859

I don't think this needs to be backported since node_delete() for D6 doesn't use any kind of transactions.

elliotttf’s picture

elliotttf commented

I did test against a hub. Are you using drush to process the cron? If so you need to set the site URL option (-l) to whatever your dev instance is, otherwise drush will set it to default.

stevector’s picture

stevector
he/him
commented

Yeah, that was it. Thank Elliott.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.