This is a start -- placing here mostly so Steef can continue work. Pay attention to comments I placed in the drupal_common_themes() function, they're of minor importance to the really core theme implementations.

CommentFileSizeAuthor
tplify_theme.inc_.patch4.56 KBmerlinofchaos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

Documenting these templates is going to be hard. I recommend we do this:

For each module that has theme functions, create a theme.doc.php (that will never be included).

We put the empty theme_* function in this file, and include the proper doxygen. It MUST contain @ingroup themeable (or put the entire file in @group themeable if that works with doxy) and if we can figure out how to do it, give it an @see that points to the proper template. Some of this might require a little delving into api.module.

dvessel’s picture

dvessel CreditAttribution: dvessel commented

Merlin, could you provide a list to start with? I understand some functions won't need tplifying so I'd like to avoid those.

I've been working on another project so please excuse the delay. I'll start now.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

dvessel: I'll have to compile a list. In general a theme function in a .module is probably fair game; mostly it's the ones in core that need to be exampled.

To start, I submitted the forum theme functions here: http://drupal.org/node/158536

It contains a documentation style that should be discussed and, hopefully, adopted.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

In my mind, the priorities are aggregator module, book module and comment module. I've got aggregator about half done, and I'm paused for the moment.

Other high priorities include

  • user module (which has had some work done to it) -- that one is going to be tough.
  • profile module (maybe -- it may not be all that themable)
  • poll module
  • menu module (yay making menus more themable!)

After that, I'm not sure where to go.

dvessel’s picture

dvessel CreditAttribution: dvessel commented

I'm working on book.module. Actions and block is up. --Was going through it alphabetically. Started on aggregator but noticed it was broke so I skipped it.

http://drupal.org/node/159862
http://drupal.org/node/159936

All the issues I create will be named the same way.. "tplify * module".

dvessel’s picture

dvessel CreditAttribution: dvessel commented

merlinofchaos: Should there be a central issue cue to checkoff on converting these templates? Not sure if it's proper.

Anyway, here are a 2 more. book.module & comment.module.

http://drupal.org/node/160200
http://drupal.org/node/160589

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

Bumping -- need to do a reroll of this patch so it doesn't get forgotten.

dpearcefl’s picture

dpearcefl CreditAttribution: dpearcefl commented

Is this still an active issue that needs to be fixed?

Status: Active » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.