Description

Nodewords meta title is a really simple extension to the Nodewords: D6 meta tags module which makes it possible to specify the content of the <meta name="title" [...]/> tag at several parts of a Drupal 6 site.

Project page and Git repository

You can find the module in my sandbox at http://drupal.org/sandbox/scorchio/1414096. You can clone the repository with the following command:

git clone --branch 6.x-1.x http://git.drupal.org/sandbox/scorchio/1414096.git nodewords_meta_title

Drupal version and other requirements

This module is for Drupal 6. It requires and has been tested with version 6.x-1.13 of Nodewords.

Background

I've consulted with Damien (the maintainer of the Nodewords module) about turning this sandbox project into a Nodewords patch - see issue #1414174: Add mention of Nodewords Meta Title to project page & README.txt file. Damien told me to turn this into a full project, so I would like to apply.

I've pre-checked this with PAReview and fixed the issues,

Comments

eugene.ilyin’s picture

eugene.ilyin commented

Hello!
I spent a Review of your module.

I could not find defects in your module, I can only add one comment:
double "title" in your function does not look very nice,
nodewords_meta_title_title_form
nodewords_meta_title_title_prepare.

Probably best to use these names:
nodewords_meta_title_form
nodewords_meta_title_prepare_title.

eugene.ilyin’s picture

eugene.ilyin commented
Status: Needs review » Needs work

Sorry, I forgot change status to "needs work".

scorchio’s picture

scorchio commented
Status: Needs work » Needs review

Thanks for your suggestions, Eugene. I've modified the name of those functions, so now they're called nodewords_meta_title_form() and nodewords_meta_title_prepare(). (Those are hooks which are fired by the Nodewords module, so I'm not able to change the naming freely.)

Mithrandir’s picture

Mithrandir commented
Status: Needs review » Needs work

From the README.txt:
"Admin makes a permission available that allows only properly
permissioned users to make use of the admin toolbar. Users with the
'use admin toolbar' permission will be able to use the toolbar."

Which toolbar?

Confirmed that suggestions from eugene.ilyin are implemented.

patrickd’s picture

patrickd commented
Status: Needs work » Needs review

please don't block deeper reviews, it's not necessary to switch to needs work when asking questions

scorchio’s picture

scorchio commented

@Mithrandir, thanks for your suggestion - it was my mistake, I've just pushed a version without those lines.

Mithrandir’s picture

Mithrandir commented

Confirmed. No further comments from me.

luxpaparazzi’s picture

luxpaparazzi commented

No errors detected by pareview => good

Your project is really small, only 85 lines of code with 5 functions.

I don't have a D6 install, so I won't be able to test it, and I leave the status as is.

---
You can also use the online version of the PAReview.sh script to auto-check your project.
Get a review bonus and we will come back to your application sooner.
You could consider reviewing my project @ http://drupal.org/node/1302786

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

I have a feeling that naming the function nodewords_meta_title_form() would, or at least should, conflict with hook_form(), so it is recommended to rename it to avoid namespace collisions.

scorchio’s picture

scorchio commented

Thanks for your suggestion! I'll rename it as soon as possible.

scorchio’s picture

scorchio commented
Status: Needs work » Needs review

I've implemented the fix for Damien's suggestion in #9, also fixed the broken default behaviour and the issue about permissions. Please have a look.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Reviewed & tested by the community

As the Nodewords maintainer, this module gets my blessing.

patrickd’s picture

patrickd commented
Status: Reviewed & tested by the community » Fixed

I'm afraid this project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed.
However, we can promote this single project manually to a full project.

Thanks for your contribution!

I've promoted this module to a full project and now your able to create releases.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

git remote set-url origin patrickd@git.drupal.org:project/nodewords_meta_title.git

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.