Hello,

The become_user module provides an easy, natural way for administrators or users, with the right permissions, to become another user right within the user listing (/admin/user/user) page. It also logs watchdog entries any time a user becomes another user.

When I submitted the sandbox project, someone created an issue stating that this is a duplicate of the masquerade module. At a basic level I suppose it is. There are a lot of modules on Drupal that are similar but provide less functionality and less bloat. This is one of those modules. I hope you consider it.

Thanks,
Richard

Project:
http://drupal.org/sandbox/rcastera/1419442

Version:
6
Repo:
git clone --branch master rcastera@git.drupal.org:sandbox/rcastera/1419442.git
become_user
cd become_user

Comments

scorchio’s picture

scorchio commented
Status: Needs review » Needs work

After contributing a useful and working module or theme as a sandbox project, you may go through a one-time approval process to get permission to promote it (and future projects) to a full project.

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process.

- Applying for permission to create full projects

Please check out the PAReview report here: http://ventral.org/pareview/httpgitdrupalorgsandboxrcastera1419442git

About the module itself: could you please tell us the difference between your module, Masquerade and the change user functionality of Devel? This clarification might be helpful in this process.

rcastera’s picture

rcastera commented
Status: Needs work » Needs review

Hi scorchio,

Thank you for your feedback! I've updated the module to conform to Drupal standards. Regarding the module itself, it's like I mentioned earlier, there are a lot of modules on Drupal that offer similar functionality like the 2 you mentioned but mine provides this one function and less bloat.

Thanks,
Richard

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Needs work
Issue tags: +PAreview: security

#1420288: prevent changing users via csrf is a critical security issue.

rcastera’s picture

rcastera commented
Status: Needs work » Needs review

HI greggles,

Thanks for your feedback. I've updated the module to protect against CSRF attacks.

Thanks,
Richard

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Needs work

Please take a moment to make your project page follow tips for a great project page.

In particular, it would be good to document (in more detail) the differences related to this issue #1419450: duplicate of masquerade module?.

dman’s picture

dman commented

I looked at the code (and compared to masquerade).

While it is true that this module does only provide the one function - and can therefore be described as 'simpler', the single function this provides is already entirely provided by the existing masquerade module out of the box.
There is no advantage in choosing this module over masquerade, and there are some limitations.

This module just duplicates a subset of functionality that is already provided by other well-reviewed modules, and for that reason, I think it's unnecessary to create it as a new project.
By its nature, it has a high potential for security issues (though I can't personally identify all the possible exploits in the current code) and therefore it would be a risky candidate for promotion.
Sorry, but I'd vote against this one.

dman’s picture

dman commented

PS, a hint for next time:
It's not that helpful to put the INSTALL.txt type instructions in your modules HOOK_help() function :-)
In all possible worlds, that's sorta redundant.

rcastera’s picture

rcastera commented
Status: Needs work » Closed (fixed)

Thanks all for your suggestions and comments.
-Richard