Bulk Media Upload

Hi,

Welcome with you application.
I di a automatic review of the code, and you have som coding standards issues to take care about:
http://ventral.org/pareview/httpgitdrupalorgsandboxaxe3121414286git

Also you should not work in the master branch, you should work in 7.x-1-x-branch and only leave a README.txt pointing to the correct branch.

A question about "bulk upload". Do you mean an archive, multiple file entries, or reading a directory loaded via FTP? There are people wanting each approach. If you define your module use, a prospective user can decide without downloading your module.

Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

</code></p><code>

FILE: ...s/all/modules/pareview_temp/test_candidate/bulk_media_upload.upload.inc<br>
--------------------------------------------------------------------------------<br>
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)<br>
--------------------------------------------------------------------------------<br>
 18 | ERROR | Concatenating translatable strings is not allowed, use<br>
    |       | placeholders instead and only one string literal<br>
--------------------------------------------------------------------------------<br>

Source: http://ventral.org/pareview - PAReview.sh online service

No manual review given, and the minor coding style issues do not justify the "needs work" status.

The response time for a review is now approaching 4 weeks. Get a review bonus and we will come back to your application sooner.

Hi,

I made a quick look at your module which looks interesting.

However it could be interesting if you add a button in "media" which links with the "bulk media upload" form.
Also, you may consider to no restrict upload with content types but use all entities because we can add media files on every entities on a Drupal website.

Manual review

1. Global: Please check your comments. Be aware that every comments should be ending by . , ? or !
2. Global: You should put all .inc files into an "includes" directory
3. .module file

• In hook_menu, you should initialize your $items by an array variable first
• Also, a small detail, you should keep always the same order for elements in menu item, sometimes you have 'file' then 'type' and vice versa.

• '#markup' => '<p>There was no media uploaded in this session.</p>', Text should be wrap into t() function. Be aware to not include

  and

  into t()

• Remove unused code as at line 73. Also /* */ comment should not be used into a function.
• You should renamed variable $l_options at line 89 to someting more explicit
• 'status' => $node->status ? t('published') : t('not published'), Did you try what append if it use with a module which override standard status?
• You should maybe separate all steps contains in function bulk_media_upload_summary() into different functions as for the part which add operations on node or otherone like these.

• #markup should be include in t() function

First many thanks for the wonderful project.
The project will be pursued further? I have problems to create the Optional sub-directory in the destination directory of the upload, unfortunately, is not accessed it.
I would like to use the modules for my project. But I need a better structure of the data.

Many Thanks

Erstmal vielen dank für das Wunderbare Projekt.
wird das Projekt noch weiter verfolgt? Ich habe Probleme das Optionales Unterverzeichnis im Zielverzeichnis des Uploads anzulegen, leider wird nicht drauf zugegriffen.
Ich würde gerne das Module für mein Projekt verwenden. Aber ich brauche eine bessere Struktur der Daten.

Vielen Dank

if you got a specific feature request for this module, please create a separate issue in the module's issue queue.
this issue is only related for full project application of axe312

many thanks, I will do.

Haven't had a chance to check the code for standards, but in my testing it works as advertised. I would rather it create entities, but it's an endorsement from me.

Manual Review:

Most of the things are looking good except few things. :)

1) bulk_media_upload_summary(): doc block is wrong, this is not a hook, this is a form builder function. See http://drupal.org/node/1354#forms Same on bulk_media_upload_admin_validate() and others. Please check all your function documentation.
2) You can remove bulk_media_upload_upload_form_validate() funtion from bulk_media_upload.upload.inc

This module works as advertised. Remaining code cleanup can be done in the issue queue once it's a proper module.

Thanks for your contribution, axe312!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on irc in #drupal-contribute. So, come hang out and get involved!

Thanks to all the participants for your awesome reviews! Also, terrific job to those already getting involved in the project's issue queue!!

@jygastaud and @brentratliff: Re extending bulk media upload to all entity types, I posted a patch at #1678240: Enable bulk media upload for all fieldable entity types if you have time to review....

added info for the file dialog upload thing