Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Could possibly be exposed as a local task and action. Would be nice to add this once file_access('download') lands.
Comment | File | Size | Author |
---|---|---|---|
#5 | 1422260-5-file-download-callback.patch | 7.28 KB | Devin Carlson |
#4 | 1422260-4-file-download-callback.patch | 3.96 KB | Devin Carlson |
#3 | 1422260-3-file-download-callback.patch | 1.11 KB | Jackinloadup |
#1 | 1422260-file-download-callback.patch | 1.07 KB | Dave Reid |
Comments
Comment #1
Dave ReidComment #2
Dave ReidWe should also implement a lot of the functionality in http://drupal.org/project/download_file. Should also trigger headers to cause the browser to trigger a download dialog rather than display the file in-browser.
Comment #3
Jackinloadup CreditAttribution: Jackinloadup commentedHere is a reroll of the patch in #1 to work with the #1227706-78: Add a file entity access API for initial testing purposed. Full implementation still needed as stated in #2
Comment #4
Devin Carlson CreditAttribution: Devin Carlson commentedAn updated patch to accommodate the changes required due to #1227706: Add a file entity access API and to add in the functionality provided by the DownloadFile module (along with an alter hook to allow other modules to modify the file download headers).
Comment #5
Devin Carlson CreditAttribution: Devin Carlson commentedRerolled and added test coverage.
Comment #6
ParisLiakos CreditAttribution: ParisLiakos commentedawesome:)
i dont think we need something else here..i just checked this codewise and seems good to go
No manual testing but i trust devin did that already:)
Comment #7
bneil CreditAttribution: bneil commentedI manually tested this and it works for me.
Comment #8
gmclelland CreditAttribution: gmclelland commentedJust to verify, I did apply the patch in #5. I was able to receive a force download at file/49/download. I'm also seeing the new download permissions.
Comment #9
Devin Carlson CreditAttribution: Devin Carlson commentedCommitted to 7.x-1.x.
This is needed by CKEditor Link File to allow editors to easily link to file "downloads".