Closed (fixed)
Project:
Name Field
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
31 Jan 2012 at 18:01 UTC
Updated:
2 Apr 2012 at 11:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
alan d. commentedHappy to add. Do you have you any code or a patch?
Comment #2
cthiebault commentedI began to do something but I'm not familiar enough with Entity API metadata.
I had a look to fields like date, addressfield, link, etc...
I'll try to do something soon.
Comment #3
jsacksick commentedThe attached patch should be ok. The consequence of that is that you're now able to use in in Search api indexes ... and the like...
Comment #4
jsacksick commentedComment #5
alan d. commentedLikes tidy. Committed. Note that I was not sure how to test!
Thanks
Comment #6
alan d. commented@jsacksick
1) Did you test it?
Think that I covered this above - Note that I was not sure how to test! There did not appear to be any immediate danger raised by the patch, and the coding standards were above the norm, suggesting developer care, and thus testing, by yourself :)
If I had 5 hours spare to learn and write the tests for this I would. Feel free to follow up if you want. The tests for this module have not been updated for a while and will probably fail as they stand atm (although that doesn't mean that there are bugs in the module).
2) And second, are you aware of that page (http://drupal.org/node/1146430)?
Nope, thanks for pointing this out. I try to start doing this in the future. I've been using the committer identity to credit, and looking back, I was twice wrong about this; giving this to cthiebault rather than yourself. I'm working 60+ hours a week at the moment, so it is a miracle that I get any free time to look at the issue queues.
And I definitely do not take the time to play any ranking games, but I do appreciate others taking the time to help out. BTW, use "git format-patch" rather than "git diff" if this is really important to you and it removes another step from the maintainers pov.