The Social Login module allows your visitors to login and register with social networks like Twitter, Facebook, LinkedIn, Paypal, LiveJournal, Hyves, Вконтакте, Google or Yahoo. Make your site social!
Increase your drupal user engagement in a few simple steps with the Social Login Module!
The Social Login Module is maintained by OneAll, a technology company offering a set of web-delivered tools and services for establishing and optimizing a site's connection with social networks and identity providers such as Facebook, Twitter, Google, Yahoo!, LinkedIn, Paypal, Hyves amongst others.
Link to project: http://drupal.org/sandbox/oneall/1424874
Link to git repository oneall@git.drupal.org:sandbox/oneall/1424874.git
Version for drupal 7
See install.txt to install module correct .
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | backend.jpg | 108.01 KB | social login |
| #3 | frontend.jpg | 32.24 KB | social login |
Comments
Comment #1
afox commentedHi @kosmos.by,
Your project looks interesting. I'm sorry if I'm too fast (I noticed you pushed only an hour ago), but your sandbox project currently contains only info.txt and install.txt -files and an empty zip file. Don't compress the module files. Just push them as they are.
Please review http://drupal.org/node/1011698 on the full project application process and what is required. Your project should be release-ready in your sandbox when submitting this application. Reopen when your project is ready. By setting this application to "needs review", you are telling the project queue maintainers that you have something for review.
Thanks!
Comment #2
patrickd commentedwelcome!
Your module project page only contains 1 sentence, see documentation on how to make great project pages: http://drupal.org/node/997024
You did not push your module correctly as you uploaded a packed zip file,
read the documentation on how to use git with drupal: http://drupal.org/node/1013552
if you got further question, please ask!
@afox its not empty ;-)
Comment #3
social login commentedComment #4
social login commentedComment #5
social login commentedThanks for fast comments. I've remade something. Could you check now, please.
Comment #6
patrickd commentedYou're again working in the master branch instead of 7.x-1.x, but at least there is now something to work with
do checkout 7.x-1.x; push your recent code and empty your master branch (See also step 5 in http://drupal.org/node/1127732)
Your project page is not very informative, learn how to create greaat project pages: http://drupal.org/node/997024
also for readme files: http://drupal.org/node/447604
Review of the master branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
It seems to me that you have a lack of basic understanding about how to create drupal modules, please read the documentation more carefully, there's a bunch of stuff you can learn from! I'd also recomment to read a drupal book about module development,
but I'm sure you'll get this done :-)
Comment #7
social login commentedcheck please
Comment #8
anilbhatt commentedI found so many bugs and warning with your project, please rectify it first, follow the drupal coding standards,
documentations and review process is here. http://drupal.org/node/1011698
Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
sites/all/modules/pareview_temp/test_candidate/./sociallogin_core.pages.inc:
+68: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
+88: [minor] You may not want to use SELECT COUNT(*), if all you want to do is check for the existance of any rows, rather than the actual number of rows.
Status Messages:
Coder found 4 projects, 4 files, 2 minor warnings, 0 warnings were flagged to be ignored
FILE: ...l-7-pareview/sites/all/modules/pareview_temp/test_candidate/INSTALL.txt
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
8 | WARNING | Line exceeds 80 characters; contains 113 characters
--------------------------------------------------------------------------------
FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
35 | WARNING | Line exceeds 80 characters; contains 113 characters
54 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...pal-7-pareview/sites/all/modules/pareview_temp/test_candidate/admin.css
--------------------------------------------------------------------------------
FOUND 68 ERROR(S) AFFECTING 68 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
3 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
4 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
5 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
6 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
7 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
11 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
15 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
16 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
20 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
21 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
25 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
29 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
33 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
37 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
38 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
39 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
40 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
41 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
42 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
43 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
44 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
48 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
49 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
50 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
51 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
55 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
59 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
60 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
61 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
62 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
66 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
67 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
68 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
72 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
73 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
77 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
78 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
82 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
86 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
90 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
94 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
98 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
102 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
103 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
104 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
105 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
106 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
110 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
114 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
118 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
122 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
126 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
130 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
134 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
138 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
142 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
146 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
150 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
154 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
158 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
162 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
166 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
170 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
171 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
172 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
176 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
177 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...upal-7-pareview/sites/all/modules/pareview_temp/test_candidate/admin.js
--------------------------------------------------------------------------------
FOUND 61 ERROR(S) AFFECTING 51 LINE(S)
--------------------------------------------------------------------------------
17 | ERROR | Spaces must be used to indent lines; tabs are not allowed
18 | ERROR | Spaces must be used to indent lines; tabs are not allowed
19 | ERROR | Spaces must be used to indent lines; tabs are not allowed
20 | ERROR | Spaces must be used to indent lines; tabs are not allowed
21 | ERROR | Whitespace found at end of line
21 | ERROR | Spaces must be used to indent lines; tabs are not allowed
22 | ERROR | Spaces must be used to indent lines; tabs are not allowed
23 | ERROR | Spaces must be used to indent lines; tabs are not allowed
27 | ERROR | Spaces must be used to indent lines; tabs are not allowed
31 | ERROR | Spaces must be used to indent lines; tabs are not allowed
31 | ERROR | Whitespace found at end of line
32 | ERROR | Spaces must be used to indent lines; tabs are not allowed
32 | ERROR | Whitespace found at end of line
33 | ERROR | Spaces must be used to indent lines; tabs are not allowed
34 | ERROR | Whitespace found at end of line
34 | ERROR | Spaces must be used to indent lines; tabs are not allowed
35 | ERROR | Spaces must be used to indent lines; tabs are not allowed
36 | ERROR | Spaces must be used to indent lines; tabs are not allowed
37 | ERROR | Spaces must be used to indent lines; tabs are not allowed
38 | ERROR | Spaces must be used to indent lines; tabs are not allowed
39 | ERROR | Spaces must be used to indent lines; tabs are not allowed
40 | ERROR | Spaces must be used to indent lines; tabs are not allowed
41 | ERROR | Spaces must be used to indent lines; tabs are not allowed
42 | ERROR | Spaces must be used to indent lines; tabs are not allowed
43 | ERROR | Spaces must be used to indent lines; tabs are not allowed
44 | ERROR | Spaces must be used to indent lines; tabs are not allowed
45 | ERROR | Spaces must be used to indent lines; tabs are not allowed
45 | ERROR | Whitespace found at end of line
46 | ERROR | Spaces must be used to indent lines; tabs are not allowed
47 | ERROR | Spaces must be used to indent lines; tabs are not allowed
48 | ERROR | Spaces must be used to indent lines; tabs are not allowed
49 | ERROR | Spaces must be used to indent lines; tabs are not allowed
49 | ERROR | Whitespace found at end of line
50 | ERROR | Spaces must be used to indent lines; tabs are not allowed
51 | ERROR | Spaces must be used to indent lines; tabs are not allowed
52 | ERROR | Spaces must be used to indent lines; tabs are not allowed
53 | ERROR | Spaces must be used to indent lines; tabs are not allowed
54 | ERROR | Spaces must be used to indent lines; tabs are not allowed
55 | ERROR | Spaces must be used to indent lines; tabs are not allowed
56 | ERROR | Spaces must be used to indent lines; tabs are not allowed
57 | ERROR | Spaces must be used to indent lines; tabs are not allowed
58 | ERROR | Spaces must be used to indent lines; tabs are not allowed
59 | ERROR | Whitespace found at end of line
59 | ERROR | Spaces must be used to indent lines; tabs are not allowed
60 | ERROR | Spaces must be used to indent lines; tabs are not allowed
61 | ERROR | Whitespace found at end of line
61 | ERROR | Spaces must be used to indent lines; tabs are not allowed
62 | ERROR | Spaces must be used to indent lines; tabs are not allowed
63 | ERROR | Spaces must be used to indent lines; tabs are not allowed
64 | ERROR | Spaces must be used to indent lines; tabs are not allowed
65 | ERROR | Spaces must be used to indent lines; tabs are not allowed
66 | ERROR | Spaces must be used to indent lines; tabs are not allowed
67 | ERROR | Spaces must be used to indent lines; tabs are not allowed
68 | ERROR | Spaces must be used to indent lines; tabs are not allowed
68 | ERROR | Whitespace found at end of line
69 | ERROR | Whitespace found at end of line
69 | ERROR | Spaces must be used to indent lines; tabs are not allowed
70 | ERROR | Spaces must be used to indent lines; tabs are not allowed
71 | ERROR | Spaces must be used to indent lines; tabs are not allowed
72 | ERROR | Spaces must be used to indent lines; tabs are not allowed
73 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...-7-pareview/sites/all/modules/pareview_temp/test_candidate/settings.php
--------------------------------------------------------------------------------
FOUND 70 ERROR(S) AND 12 WARNING(S) AFFECTING 48 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Missing file doc comment
5 | ERROR | There must be no space between the Array keyword and the
| | opening parenthesis
6 | ERROR | Spaces must be used to indent lines; tabs are not allowed
6 | ERROR | There must be no space between the Array keyword and the
| | opening parenthesis
7 | ERROR | Spaces must be used to indent lines; tabs are not allowed
8 | ERROR | Spaces must be used to indent lines; tabs are not allowed
8 | WARNING | A comma should follow the last multiline array item. Found:
| | true
8 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
9 | ERROR | Spaces must be used to indent lines; tabs are not allowed
10 | ERROR | Spaces must be used to indent lines; tabs are not allowed
10 | ERROR | There must be no space between the Array keyword and the
| | opening parenthesis
11 | ERROR | Spaces must be used to indent lines; tabs are not allowed
12 | ERROR | Spaces must be used to indent lines; tabs are not allowed
12 | WARNING | A comma should follow the last multiline array item. Found:
| | true
12 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
13 | ERROR | Spaces must be used to indent lines; tabs are not allowed
14 | ERROR | Spaces must be used to indent lines; tabs are not allowed
14 | ERROR | There must be no space between the Array keyword and the
| | opening parenthesis
15 | ERROR | Spaces must be used to indent lines; tabs are not allowed
16 | ERROR | Spaces must be used to indent lines; tabs are not allowed
16 | WARNING | A comma should follow the last multiline array item. Found:
| | true
16 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
17 | ERROR | Spaces must be used to indent lines; tabs are not allowed
18 | ERROR | Spaces must be used to indent lines; tabs are not allowed
18 | ERROR | There must be no space between the Array keyword and the
| | opening parenthesis
19 | ERROR | Spaces must be used to indent lines; tabs are not allowed
20 | ERROR | Spaces must be used to indent lines; tabs are not allowed
20 | WARNING | A comma should follow the last multiline array item. Found:
| | true
20 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
21 | ERROR | Spaces must be used to indent lines; tabs are not allowed
22 | ERROR | Spaces must be used to indent lines; tabs are not allowed
22 | ERROR | There must be no space between the Array keyword and the
| | opening parenthesis
23 | ERROR | Spaces must be used to indent lines; tabs are not allowed
24 | ERROR | Spaces must be used to indent lines; tabs are not allowed
24 | WARNING | A comma should follow the last multiline array item. Found:
| | true
24 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
25 | ERROR | Spaces must be used to indent lines; tabs are not allowed
26 | ERROR | Spaces must be used to indent lines; tabs are not allowed
26 | ERROR | There must be no space between the Array keyword and the
| | opening parenthesis
27 | ERROR | Spaces must be used to indent lines; tabs are not allowed
28 | ERROR | Spaces must be used to indent lines; tabs are not allowed
28 | WARNING | A comma should follow the last multiline array item. Found:
| | true
28 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
29 | ERROR | Spaces must be used to indent lines; tabs are not allowed
30 | ERROR | Spaces must be used to indent lines; tabs are not allowed
30 | ERROR | There must be no space between the Array keyword and the
| | opening parenthesis
31 | ERROR | Spaces must be used to indent lines; tabs are not allowed
32 | ERROR | Spaces must be used to indent lines; tabs are not allowed
32 | WARNING | A comma should follow the last multiline array item. Found:
| | true
32 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
33 | ERROR | Spaces must be used to indent lines; tabs are not allowed
34 | ERROR | Spaces must be used to indent lines; tabs are not allowed
34 | ERROR | There must be no space between the Array keyword and the
| | opening parenthesis
35 | ERROR | Spaces must be used to indent lines; tabs are not allowed
36 | ERROR | Spaces must be used to indent lines; tabs are not allowed
36 | WARNING | A comma should follow the last multiline array item. Found:
| | false
36 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
37 | ERROR | Spaces must be used to indent lines; tabs are not allowed
38 | ERROR | Spaces must be used to indent lines; tabs are not allowed
38 | ERROR | There must be no space between the Array keyword and the
| | opening parenthesis
39 | ERROR | Spaces must be used to indent lines; tabs are not allowed
40 | ERROR | Spaces must be used to indent lines; tabs are not allowed
40 | WARNING | A comma should follow the last multiline array item. Found:
| | false
40 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
41 | ERROR | Spaces must be used to indent lines; tabs are not allowed
42 | ERROR | Spaces must be used to indent lines; tabs are not allowed
42 | ERROR | There must be no space between the Array keyword and the
| | opening parenthesis
43 | ERROR | Spaces must be used to indent lines; tabs are not allowed
44 | ERROR | Spaces must be used to indent lines; tabs are not allowed
44 | WARNING | A comma should follow the last multiline array item. Found:
| | false
44 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
45 | ERROR | Spaces must be used to indent lines; tabs are not allowed
46 | ERROR | Spaces must be used to indent lines; tabs are not allowed
46 | ERROR | There must be no space between the Array keyword and the
| | opening parenthesis
47 | ERROR | Spaces must be used to indent lines; tabs are not allowed
48 | ERROR | Spaces must be used to indent lines; tabs are not allowed
48 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
49 | ERROR | Spaces must be used to indent lines; tabs are not allowed
49 | WARNING | A comma should follow the last multiline array item. Found: 'To
| | enable cyrillic usernames, you might need this
| | plugin'
50 | ERROR | Spaces must be used to indent lines; tabs are not allowed
50 | WARNING | A comma should follow the last multiline array item. Found: )
52 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...ew/sites/all/modules/pareview_temp/test_candidate/sociallogin.admin.inc
--------------------------------------------------------------------------------
FOUND 94 ERROR(S) AND 15 WARNING(S) AFFECTING 89 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Missing file doc comment
3 | ERROR | Missing function doc comment
8 | WARNING | Line exceeds 80 characters; contains 90 characters
8 | ERROR | No space before comment text; expected "//
| | $form['#attached']['js'][] = drupal_get_path('module',
| | 'sociallogin') . '/admin.js';" but found
| | "//$form['#attached']['js'][] = drupal_get_path('module',
| | 'sociallogin') . '/admin.js';"
8 | ERROR | There must be no blank line following an inline comment
15 | ERROR | Array indentation error, expected 6 spaces but found 8
16 | ERROR | Array indentation error, expected 6 spaces but found 8
18 | ERROR | Array indentation error, expected 6 spaces but found 8
22 | ERROR | Array indentation error, expected 6 spaces but found 8
23 | ERROR | Array indentation error, expected 6 spaces but found 8
24 | ERROR | Array indentation error, expected 6 spaces but found 8
25 | ERROR | Array indentation error, expected 6 spaces but found 8
26 | ERROR | Array indentation error, expected 6 spaces but found 8
27 | ERROR | Array indentation error, expected 6 spaces but found 8
31 | ERROR | Array indentation error, expected 6 spaces but found 8
32 | ERROR | Array indentation error, expected 6 spaces but found 8
33 | ERROR | Array indentation error, expected 6 spaces but found 8
34 | ERROR | Array indentation error, expected 6 spaces but found 8
35 | ERROR | Array indentation error, expected 6 spaces but found 8
36 | ERROR | Array indentation error, expected 6 spaces but found 8
40 | ERROR | Array indentation error, expected 6 spaces but found 8
41 | ERROR | Array indentation error, expected 6 spaces but found 8
42 | ERROR | Array indentation error, expected 6 spaces but found 8
43 | ERROR | Array indentation error, expected 6 spaces but found 8
44 | ERROR | Array indentation error, expected 6 spaces but found 8
45 | ERROR | Array indentation error, expected 6 spaces but found 8
49 | ERROR | Array indentation error, expected 6 spaces but found 10
50 | ERROR | Array indentation error, expected 6 spaces but found 10
51 | ERROR | Array indentation error, expected 6 spaces but found 10
52 | WARNING | A comma should follow the last multiline array item. Found:
| | 'oa_social_login_api_test_result'
53 | ERROR | Array indentation error, expected 6 spaces but found 12
57 | ERROR | Array indentation error, expected 6 spaces but found 8
58 | ERROR | Array indentation error, expected 6 spaces but found 8
59 | ERROR | Array indentation error, expected 6 spaces but found 8
60 | ERROR | Array indentation error, expected 6 spaces but found 8
61 | ERROR | Array indentation error, expected 6 spaces but found 8
61 | WARNING | Line exceeds 80 characters; contains 89 characters
61 | ERROR | Comments may not appear after statements.
68 | ERROR | Array indentation error, expected 6 spaces but found 8
69 | ERROR | Array indentation error, expected 6 spaces but found 8
72 | ERROR | "require_once" is a statement not a function; no parentheses
| | are required
72 | ERROR | Space before opening parenthesis of function call prohibited
74 | ERROR | Expected "foreach (...) {\n"; found "foreach (...)\n {\n"
74 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
74 | ERROR | AS keyword must be lowercase; expected "as" but found "AS"
77 | ERROR | Concat operator must be surrounded by spaces
78 | ERROR | Array indentation error, expected 10 spaces but found 12
78 | ERROR | Space before opening parenthesis of function call prohibited
79 | ERROR | Array indentation error, expected 10 spaces but found 12
80 | ERROR | Array indentation error, expected 10 spaces but found 12
83 | ERROR | Concat operator must be surrounded by spaces
83 | WARNING | A comma should follow the last multiline array item. Found:
| | $key
87 | WARNING | A comma should follow the last multiline array item. Found:
| | 'margin: 5px;'
88 | WARNING | A comma should follow the last multiline array item. Found: )
89 | ERROR | Array indentation error, expected 10 spaces but found 12
92 | ERROR | Concat operator must be surrounded by spaces
93 | ERROR | Array indentation error, expected 10 spaces but found 12
94 | ERROR | Array indentation error, expected 10 spaces but found 12
94 | ERROR | Space before opening parenthesis of function call prohibited
95 | ERROR | Array indentation error, expected 10 spaces but found 12
95 | ERROR | Concat operator must be surrounded by spaces
97 | ERROR | Array indentation error, expected 10 spaces but found 12
99 | WARNING | A comma should follow the last multiline array item. Found:
| | 'margin: 15px;'
100 | WARNING | A comma should follow the last multiline array item. Found: )
101 | ERROR | Array indentation error, expected 10 spaces but found 12
105 | ERROR | Concat operator must be surrounded by spaces
106 | ERROR | Array indentation error, expected 10 spaces but found 12
107 | ERROR | Array indentation error, expected 10 spaces but found 12
109 | WARNING | A comma should follow the last multiline array item. Found:
| | 'clear: both;'
110 | WARNING | A comma should follow the last multiline array item. Found: )
111 | ERROR | Array indentation error, expected 10 spaces but found 12
120 | ERROR | Array indentation error, expected 6 spaces but found 8
121 | ERROR | Array indentation error, expected 6 spaces but found 8
128 | ERROR | You must use "/**" style comments for a function comment
130 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 0
134 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 0
136 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 0
137 | WARNING | Line exceeds 80 characters; contains 98 characters
138 | WARNING | Line exceeds 80 characters; contains 86 characters
139 | WARNING | Line exceeds 80 characters; contains 92 characters
140 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 0
141 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 0
145 | WARNING | Line exceeds 80 characters; contains 86 characters
147 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 0
151 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
152 | ERROR | Line indented incorrectly; expected 4 spaces, found 8
162 | WARNING | Line exceeds 80 characters; contains 81 characters
168 | ERROR | You must use "/**" style comments for a function comment
180 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
180 | ERROR | Expected 1 space before "=>"; 0 found
180 | ERROR | Expected 1 space after "=>"; 0 found
182 | ERROR | Concat operator must be surrounded by spaces
182 | ERROR | Concat operator must be surrounded by spaces
182 | ERROR | Concat operator must be surrounded by spaces
182 | ERROR | Concat operator must be surrounded by spaces
188 | ERROR | Missing function doc comment
190 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
190 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
192 | ERROR | Concat operator must be surrounded by spaces
192 | ERROR | Concat operator must be surrounded by spaces
204 | ERROR | Missing function doc comment
206 | ERROR | Concat operator must be surrounded by spaces
206 | ERROR | Concat operator must be surrounded by spaces
209 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
213 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
213 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
216 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
217 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
221 | ERROR | More than 2 empty lines are not allowed
--------------------------------------------------------------------------------
FILE: ...areview/sites/all/modules/pareview_temp/test_candidate/sociallogin.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
4 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...view/sites/all/modules/pareview_temp/test_candidate/sociallogin.install
--------------------------------------------------------------------------------
FOUND 4 ERROR(S) AFFECTING 4 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Missing file doc comment
3 | ERROR | Missing function doc comment
26 | ERROR | Missing function doc comment
29 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...eview/sites/all/modules/pareview_temp/test_candidate/sociallogin.module
--------------------------------------------------------------------------------
FOUND 130 ERROR(S) AND 3 WARNING(S) AFFECTING 86 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Missing file doc comment
3 | ERROR | Missing function doc comment
12 | WARNING | A comma should follow the last multiline array item. Found:
| | 'sociallogin.admin.inc'
16 | ERROR | Array indentation error, expected 6 spaces but found 8
17 | ERROR | Array indentation error, expected 6 spaces but found 8
18 | ERROR | Array indentation error, expected 6 spaces but found 8
26 | ERROR | Function doc comment must end on the line before the function
| | definition
30 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | Line indented incorrectly; expected 4 spaces, found 8
32 | ERROR | Concat operator must be surrounded by spaces
32 | ERROR | Concat operator must be surrounded by spaces
33 | ERROR | Break statement indented incorrectly; expected 10 spaces,
| | found 12
37 | ERROR | Missing function doc comment
39 | ERROR | Array indentation error, expected 6 spaces but found 8
39 | WARNING | Line exceeds 80 characters; contains 83 characters
39 | ERROR | No space before comment text; expected "// The name that will
| | appear in the block list." but found "//The name that will
| | appear in the block list."
39 | ERROR | Comments may not appear after statements.
40 | ERROR | Array indentation error, expected 6 spaces but found 8
40 | ERROR | No space before comment text; expected "// Default" but found
| | "//Default"
40 | ERROR | Comments may not appear after statements.
45 | ERROR | You must use "/**" style comments for a function comment
45 | ERROR | Expected 1 space between the closing parenthesis and the
| | opening brace; found 0
45 | ERROR | No space before comment text; expected "// $display argument
| | is new." but found "//$display argument is new."
45 | ERROR | Comments may not appear after statements.
46 | ERROR | No space before comment text; expected "// Get today's date."
| | but found "//Get today's date."
48 | ERROR | No space before comment text; expected "// Calculate midnight
| | a week ago." but found "//Calculate midnight a week ago."
49 | ERROR | No space found after comma in function call
49 | ERROR | No space found after comma in function call
50 | ERROR | No space before comment text; expected "// Get all posts from
| | one week ago to the present." but found "//Get all posts from
| | one week ago to the present."
55 | ERROR | No space before comment text; expected "// Use Database API to
| | retrieve current posts." but found "//Use Database API to
| | retrieve current posts."
58 | ERROR | No space before comment text; expected "// Published." but
| | found "//Published."
58 | ERROR | Comments may not appear after statements.
60 | ERROR | No space before comment text; expected "// Most recent first.
| | Query paused here." but found "//Most recent first. Query
| | paused here."
60 | ERROR | There must be no blank line following an inline comment
60 | ERROR | Comments may not appear after statements.
62 | ERROR | Expected "if (...) {\n"; found "if (...){\n"
62 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
65 | ERROR | No space before comment text; expected "// Now proceeds to
| | execute()." but found "//Now proceeds to execute()."
66 | ERROR | No space before comment text; expected "// If called by page,
| | query proceeds directly to execute()." but found "//If called
| | by page, query proceeds directly to execute()."
66 | ERROR | There must be no blank line following an inline comment
71 | ERROR | You must use "/**" style comments for a function comment
73 | ERROR | Expected "switch (...) {\n"; found "switch(...){\n"
73 | ERROR | Line indented incorrectly; expected 2 spaces, found 6
74 | ERROR | Line indented incorrectly; expected 4 spaces, found 10
76 | ERROR | Expected "if (...) {\n"; found "if(...){\n"
76 | ERROR | Line indented incorrectly; expected 6 spaces, found 14
77 | ERROR | No space before comment text; expected "// Retrieve and
| | process data here." but found "//Retrieve and process data
| | here."
81 | ERROR | No space before comment text; expected "// Use our custom
| | function to retrieve data." but found "//Use our custom
| | function to retrieve data."
83 | ERROR | No space before comment text; expected "// Array to contain
| | items for the block to render." but found "//Array to contain
| | items for the block to render."
85 | ERROR | No space before comment text; expected "// Iterate over the
| | resultset and format as links." but found "//Iterate over the
| | resultset and format as links."
86 | ERROR | Expected "foreach (...) {\n"; found "foreach (...){\n"
86 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
88 | ERROR | Array indentation error, expected 10 spaces but found 12
91 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
91 | ERROR | No space before comment text; expected "// No content in the
| | last week." but found "//No content in the last week."
91 | ERROR | Comments may not appear after statements.
93 | ERROR | else must start on a new line
93 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
94 | ERROR | No space before comment text; expected "// Pass data through
| | theme function." but found "//Pass data through theme
| | function."
102 | ERROR | You must use "/**" style comments for a function comment
102 | ERROR | Expected 1 space between the closing parenthesis and the
| | opening brace; found 0
106 | ERROR | Array indentation error, expected 10 spaces but found 12
107 | WARNING | A comma should follow the last multiline array item. Found: )
112 | ERROR | Missing function doc comment
116 | ERROR | No space before comment text; expected "// Array to contain
| | items for the page to render." but found "//Array to contain
| | items for the page to render."
118 | ERROR | No space before comment text; expected "// Iterate over the
| | resultset and format as links." but found "//Iterate over the
| | resultset and format as links."
119 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
121 | ERROR | Array indentation error, expected 10 spaces but found 12
125 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
125 | ERROR | No space before comment text; expected "// No content in the
| | last week." but found "//No content in the last week."
125 | ERROR | Comments may not appear after statements.
127 | ERROR | No space before comment text; expected "// Title serves as
| | page subtitle" but found "//Title serves as page subtitle"
127 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
128 | ERROR | Array indentation error, expected 10 spaces but found 12
129 | ERROR | Array indentation error, expected 10 spaces but found 12
134 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
136 | ERROR | Array indentation error, expected 10 spaces but found 12
137 | ERROR | Array indentation error, expected 10 spaces but found 12
138 | ERROR | No space before comment text; expected "// Theme hook with
| | suggestion." but found "//Theme hook with suggestion."
139 | ERROR | Array indentation error, expected 10 spaces but found 12
145 | ERROR | You must use "/**" style comments for a function comment
147 | ERROR | No space before comment text; expected "// Check if all fields
| | have been filled out" but found "//Check if all fields have
| | been filled out"
147 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
148 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
148 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
156 | ERROR | No space before comment text; expected "// Subdomain" but
| | found "//Subdomain"
156 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
157 | ERROR | Space before opening parenthesis of function call prohibited
157 | ERROR | Space before opening parenthesis of function call prohibited
159 | ERROR | No space before comment text; expected "// Full domain
| | entered" but found "//Full domain entered"
159 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
160 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
160 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
160 | ERROR | Space before opening parenthesis of function call prohibited
165 | ERROR | No space before comment text; expected "// Check subdomain
| | format" but found "//Check subdomain format"
165 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
166 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
166 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
166 | ERROR | Space before opening parenthesis of function call prohibited
174 | ERROR | No space before comment text; expected "// Domain" but found
| | "//Domain"
174 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
177 | ERROR | No space before comment text; expected "// Key" but found
| | "//Key"
177 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
180 | ERROR | No space before comment text; expected "// Secret" but found
| | "//Secret"
180 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
183 | ERROR | No space before comment text; expected "// Ping" but found
| | "//Ping"
183 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
184 | ERROR | Space before opening parenthesis of function call prohibited
185 | ERROR | Space before opening parenthesis of function call prohibited
186 | ERROR | Space before opening parenthesis of function call prohibited
187 | ERROR | Space before opening parenthesis of function call prohibited
188 | ERROR | Space before opening parenthesis of function call prohibited
189 | ERROR | Space before opening parenthesis of function call prohibited
190 | ERROR | Space before opening parenthesis of function call prohibited
191 | ERROR | Space before opening parenthesis of function call prohibited
192 | ERROR | Space before opening parenthesis of function call prohibited
194 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
194 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
194 | ERROR | Space before opening parenthesis of function call prohibited
194 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
196 | ERROR | Space before opening parenthesis of function call prohibited
204 | ERROR | No space before comment text; expected "// Success" but found
| | "//Success"
204 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
205 | ERROR | Space before opening parenthesis of function call prohibited
206 | ERROR | Space before opening parenthesis of function call prohibited
208 | ERROR | No space before comment text; expected "// Authentication
| | Error" but found "//Authentication Error"
208 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
209 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
209 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
216 | ERROR | Expected "}\nelseif (...) {\n"; found "}\n\nelseif (...)\n
| | {\n"
216 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
223 | ERROR | Expected "}\nelseif (...) {\n"; found "}\n\nelseif (...)\n
| | {\n"
223 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
--------------------------------------------------------------------------------
FILE: ...ew/sites/all/modules/pareview_temp/test_candidate/sociallogin_core.info
--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
5 | ERROR | It's only necessary to declare files[] if they declare a class or
| | interface.
6 | ERROR | It's only necessary to declare files[] if they declare a class or
| | interface.
7 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: .../sites/all/modules/pareview_temp/test_candidate/sociallogin_core.module
--------------------------------------------------------------------------------
FOUND 251 ERROR(S) AND 3 WARNING(S) AFFECTING 142 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Missing file doc comment
4 | ERROR | Missing function doc comment
6 | ERROR | Array indentation error, expected 6 spaces but found 8
7 | ERROR | Array indentation error, expected 6 spaces but found 8
8 | ERROR | Array indentation error, expected 6 spaces but found 8
9 | ERROR | Array indentation error, expected 6 spaces but found 8
10 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
10 | ERROR | 7 spaces found before inline comment; expected "// 'file' =>
| | 'rpx_core.pages.inc'," but found "// 'file' =>
| | 'rpx_core.pages.inc',"
15 | ERROR | You must use "/**" style comments for a function comment
18 | ERROR | An operator statement must be followed by a single space
20 | ERROR | No space before comment text; expected "// Callback Handler"
| | but found "//Callback Handler"
20 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
20 | ERROR | There must be no blank line following an inline comment
24 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
24 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
27 | ERROR | No space before comment text; expected "// Read settings" but
| | found "//Read settings"
34 | ERROR | No space before comment text; expected "// API Settings" but
| | found "//API Settings"
34 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
39 | ERROR | No space before comment text; expected "// Get user profile"
| | but found "//Get user profile"
39 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
40 | ERROR | Space before opening parenthesis of function call prohibited
41 | ERROR | Space before opening parenthesis of function call prohibited
42 | ERROR | Space before opening parenthesis of function call prohibited
43 | ERROR | Space before opening parenthesis of function call prohibited
44 | ERROR | Space before opening parenthesis of function call prohibited
45 | ERROR | Space before opening parenthesis of function call prohibited
46 | ERROR | Space before opening parenthesis of function call prohibited
47 | ERROR | Space before opening parenthesis of function call prohibited
48 | ERROR | Space before opening parenthesis of function call prohibited
50 | ERROR | No space before comment text; expected "// Process" but found
| | "//Process"
50 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
51 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
51 | ERROR | Line indented incorrectly; expected 4 spaces, found 8
51 | ERROR | Space before opening parenthesis of function call prohibited
51 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
53 | ERROR | No space before comment text; expected "// Close connection"
| | but found "//Close connection"
53 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
54 | ERROR | Space before opening parenthesis of function call prohibited
56 | ERROR | No space before comment text; expected "// Decode" but found
| | "//Decode"
56 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
57 | ERROR | Space before opening parenthesis of function call prohibited
59 | ERROR | No space before comment text; expected "// User Data" but
| | found "//User Data"
59 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
60 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
60 | ERROR | Line indented incorrectly; expected 6 spaces, found 12
60 | ERROR | Space before opening parenthesis of function call prohibited
65 | ERROR | No space before comment text; expected "// Identity" but found
| | "//Identity"
65 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
69 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
69 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
70 | ERROR | No space before comment text; expected "// Firstname" but
| | found "//Firstname"
70 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
73 | ERROR | Expected "}\nelseif (...) {\n"; found "}\n\nelseif(...) {\n"
73 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
74 | ERROR | No space before comment text; expected "// Firstname" but
| | found "//Firstname"
74 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
77 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
81 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
81 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
82 | ERROR | No space before comment text; expected "// Lastname" but found
| | "//Lastname"
82 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
85 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
89 | ERROR | No space before comment text; expected "// Fullname" but found
| | "//Fullname"
89 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
91 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
91 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
91 | ERROR | Expected 0 spaces after opening bracket; 1 found
95 | ERROR | Expected "}\nelseif (...) {\n"; found "}\n\nelseif (...)\n
| | {\n"
95 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
95 | ERROR | Expected 0 spaces after opening bracket; 1 found
99 | ERROR | Expected "}\nelse {\n"; found "}\n\nelse\n {\n"
99 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
101 | ERROR | Space before opening parenthesis of function call prohibited
101 | ERROR | Concat operator must be surrounded by spaces
101 | ERROR | Concat operator must be surrounded by spaces
104 | ERROR | No space before comment text; expected "// Email" but found
| | "//Email"
104 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
106 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
106 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
106 | ERROR | Space before opening parenthesis of function call prohibited
106 | ERROR | Space before opening parenthesis of function call prohibited
108 | ERROR | Expected "foreach (...) {\n"; found "foreach (...)\n
| | {\n"
108 | ERROR | Line indented incorrectly; expected 10 spaces, found 20
108 | ERROR | AS keyword must be lowercase; expected "as" but found "AS"
115 | ERROR | No space before comment text; expected "// Thumbnail" but
| | found "//Thumbnail"
115 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
117 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
117 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
117 | ERROR | Expected 0 spaces after opening bracket; 1 found
119 | ERROR | Space before opening parenthesis of function call prohibited
122 | ERROR | No space before comment text; expected "// User Website" but
| | found "//User Website"
122 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
124 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
124 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
124 | ERROR | Expected 0 spaces after opening bracket; 1 found
128 | ERROR | Expected "}\nelseif (...) {\n"; found "}\n\nelseif (...)\n
| | {\n"
128 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
128 | ERROR | Expected 0 spaces after opening bracket; 1 found
133 | ERROR | No space before comment text; expected "// Preferred Username"
| | but found "//Preferred Username"
133 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
135 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
135 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
135 | ERROR | Expected 0 spaces after opening bracket; 1 found
139 | ERROR | Expected "}\nelseif (...) {\n"; found "}\n\nelseif (...)\n
| | {\n"
139 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
143 | ERROR | Expected "}\nelseif (...) {\n"; found "}\n\nelseif (...)\n
| | {\n"
143 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
148 | ERROR | Space before opening parenthesis of function call prohibited
150 | ERROR | No space before comment text; expected "// $user_id = '';" but
| | found "//$user_id = '';"
150 | ERROR | There must be no blank line following an inline comment
152 | ERROR | No space before comment text; expected "// Try to link to
| | existing account" but found "//Try to link to existing
| | account"
152 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
153 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
153 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
153 | ERROR | Space before opening parenthesis of function call prohibited
155 | ERROR | No space before comment text; expected "// Linked enabled?"
| | but found "//Linked enabled?"
156 | ERROR | Expected "if (...) {\n"; found "if (...)\n
| | {\n"
156 | ERROR | Line indented incorrectly; expected 10 spaces, found 20
156 | ERROR | Expected 0 spaces after opening bracket; 1 found
158 | ERROR | No space before comment text; expected "// Only of email is
| | verified" but found "//Only of email is verified"
158 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
159 | ERROR | Expected "if (...) {\n"; found "if (...)\n
| | {\n"
159 | ERROR | Line indented incorrectly; expected 12 spaces, found 24
159 | ERROR | Expected 0 spaces after opening bracket; 1 found
159 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
162 | ERROR | No space before comment text; expected "// Read existing user"
| | but found "//Read existing user"
162 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
163 | ERROR | Expected "if (...) {\n"; found "if (...)\n
| | {\n"
163 | ERROR | Line indented incorrectly; expected 14 spaces, found 28
163 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
166 | ERROR | Expected "if (...) {\n"; found "if (...)\n
| | {\n"
166 | ERROR | Line indented incorrectly; expected 16 spaces, found 32
166 | ERROR | Space before opening parenthesis of function call prohibited
169 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "NULL" but
| | found "null"
169 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
170 | ERROR | Space before opening parenthesis of function call prohibited
171 | ERROR | Space before opening parenthesis of function call prohibited
172 | ERROR | Space before opening parenthesis of function call prohibited
174 | ERROR | Expected "if (...) {\n"; found "if (...)\n
| | {\n"
174 | ERROR | Line indented incorrectly; expected 18 spaces, found 36
174 | ERROR | Expected 0 spaces after opening bracket; 1 found
176 | ERROR | Space before opening parenthesis of function call prohibited
184 | ERROR | No space before comment text; expected "// New User" but found
| | "//New User"
184 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
185 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
185 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
185 | ERROR | Expected 0 spaces after opening bracket; 1 found
185 | ERROR | Space before opening parenthesis of function call prohibited
188 | ERROR | No space before comment text; expected "// Username is
| | mandatory" but found "//Username is mandatory"
188 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
189 | ERROR | Expected "if (...) {\n"; found "if (...)\n
| | {\n"
189 | ERROR | Line indented incorrectly; expected 10 spaces, found 20
189 | ERROR | Expected 0 spaces after opening bracket; 1 found
191 | ERROR | Concat operator must be surrounded by spaces
194 | ERROR | No space before comment text; expected "// Username must be
| | unique" but found "//Username must be unique"
194 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
195 | ERROR | Expected "if (...) {\n"; found "if (...)\n
| | {\n"
195 | ERROR | Line indented incorrectly; expected 10 spaces, found 20
195 | ERROR | Space before opening parenthesis of function call prohibited
199 | ERROR | Expected "do {\n...} while (...);\n"; found "do\n
| | {\n...} while (...);\n"
199 | ERROR | Line indented incorrectly; expected 12 spaces, found 24
201 | ERROR | Concat operator must be surrounded by spaces
202 | ERROR | Space before opening parenthesis of function call prohibited
206 | ERROR | No space before comment text; expected "// Email must be
| | unique" but found "//Email must be unique"
206 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
207 | ERROR | Expected "if (...) {\n"; found "if (...)\n
| | {\n"
207 | ERROR | Line indented incorrectly; expected 10 spaces, found 20
207 | ERROR | Expected 0 spaces after opening bracket; 1 found
214 | ERROR | Calling class constructors must always include parentheses
218 | WARNING | The opening paranthesis of an array should not be followed by
| | a white space
221 | ERROR | There must be no space between the Array keyword and the
| | opening parenthesis
227 | ERROR | Expected 1 space between "2" and double arrow; 0 found
227 | ERROR | Expected 1 space between double arrow and "1"; 0 found
227 | ERROR | Expected 1 space between "3" and double arrow; 0 found
227 | ERROR | Expected 1 space between double arrow and "0"; 0 found
236 | WARNING | A comma should follow the last multiline array item. Found:
| | $user_email
241 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
251 | ERROR | There must be no blank line following an inline comment
253 | ERROR | Expected "if (...) {\n"; found "if (...)\n
| | {\n"
253 | ERROR | Line indented incorrectly; expected 10 spaces, found 20
255 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "NULL" but
| | found "null"
255 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
256 | ERROR | Space before opening parenthesis of function call prohibited
257 | ERROR | Space before opening parenthesis of function call prohibited
258 | ERROR | Space before opening parenthesis of function call prohibited
260 | ERROR | Expected "if (...) {\n"; found "if (...)\n
| | {\n"
260 | ERROR | Line indented incorrectly; expected 12 spaces, found 24
260 | ERROR | Expected 0 spaces after opening bracket; 1 found
262 | ERROR | Space before opening parenthesis of function call prohibited
270 | ERROR | 20 spaces found before inline comment; expected "// echo
| | "";" but found "// echo "";"
270 | ERROR | Inline comments must start with a capital letter
271 | ERROR | There must be no blank line following an inline comment
273 | ERROR | No space before comment text; expected "// $user =&
| | JFactory::getUser($user_id);" but found "//$user =&
| | JFactory::getUser($user_id);"
273 | ERROR | There must be no blank line following an inline comment
275 | ERROR | Expected "if (...) {\n"; found "if (...)\n {\n"
275 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
277 | ERROR | Expected 1 space between "'uid'" and double arrow; 0 found
277 | ERROR | Expected 1 space between double arrow and "$inserted_user"; 0
| | found
283 | ERROR | No space before comment text; expected "// Set current user"
| | but found "//Set current user"
283 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
284 | ERROR | Expected "}\nelse {\n"; found "}\n //Set
| | current user\n\nelse\n {\n"
284 | ERROR | Line indented incorrectly; expected 8 spaces, found 16
286 | ERROR | Expected 1 space between "'uid'" and double arrow; 0 found
286 | ERROR | Expected 1 space between double arrow and "$user_id"; 0 found
299 | ERROR | You must use "/**" style comments for a function comment
300 | ERROR | Opening brace should be on the same line as the declaration
301 | ERROR | Expected "do {\n...} while (...);\n"; found "do\n
| | {\n...} while(...);\n"
301 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
303 | ERROR | No space found after comma in function call
303 | ERROR | Concat operator must be surrounded by spaces
309 | ERROR | Missing function doc comment
310 | ERROR | Concat operator must be surrounded by spaces
310 | ERROR | Concat operator must be surrounded by spaces
310 | ERROR | Concat operator must be surrounded by spaces
310 | ERROR | Concat operator must be surrounded by spaces
318 | WARNING | A comma should follow the last multiline array item. Found:
| | $meta_value
325 | ERROR | Missing function doc comment
329 | ERROR | Missing function doc comment
329 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
330 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
330 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
331 | ERROR | Concat operator must be surrounded by spaces
331 | ERROR | Concat operator must be surrounded by spaces
331 | ERROR | Concat operator must be surrounded by spaces
331 | ERROR | Concat operator must be surrounded by spaces
338 | ERROR | More than 2 empty lines are not allowed
339 | ERROR | Missing function doc comment
339 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
339 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
341 | ERROR | Inline control structures are not allowed
343 | ERROR | Inline control structures are not allowed
347 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
347 | ERROR | Space found after opening bracket of FOR loop
347 | ERROR | Space found before closing bracket of FOR loop
354 | ERROR | Missing function doc comment
358 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
359 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
361 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
366 | ERROR | Missing function doc comment
368 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
369 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
371 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
372 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
376 | ERROR | Missing function doc comment
377 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
377 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
378 | ERROR | Concat operator must be surrounded by spaces
378 | ERROR | Concat operator must be surrounded by spaces
381 | ERROR | Line indented incorrectly; expected 4 spaces, found 8
386 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
386 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
389 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
390 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
392 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...tes/all/modules/pareview_temp/test_candidate/sociallogin_core.pages.inc
--------------------------------------------------------------------------------
FOUND 51 ERROR(S) AND 1 WARNING(S) AFFECTING 35 LINE(S)
--------------------------------------------------------------------------------
14 | ERROR | Function doc comment must end on the line before the function
| | definition
17 | ERROR | More than 2 empty lines are not allowed
18 | ERROR | More than 2 empty lines are not allowed
20 | ERROR | Opening brace should be on the same line as the declaration
21 | ERROR | Expected "do {\n...} while (...);\n"; found "do\n
| | {\n...} while(...);\n"
21 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | No space found after comma in function call
23 | ERROR | Concat operator must be surrounded by spaces
29 | ERROR | Missing function doc comment
30 | ERROR | Concat operator must be surrounded by spaces
30 | ERROR | Concat operator must be surrounded by spaces
30 | ERROR | Concat operator must be surrounded by spaces
30 | ERROR | Concat operator must be surrounded by spaces
38 | WARNING | A comma should follow the last multiline array item. Found:
| | $meta_value
45 | ERROR | Missing function doc comment
49 | ERROR | Missing function doc comment
49 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
50 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
50 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
51 | ERROR | Concat operator must be surrounded by spaces
51 | ERROR | Concat operator must be surrounded by spaces
51 | ERROR | Concat operator must be surrounded by spaces
51 | ERROR | Concat operator must be surrounded by spaces
58 | ERROR | More than 2 empty lines are not allowed
59 | ERROR | Missing function doc comment
59 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
59 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
61 | ERROR | Inline control structures are not allowed
63 | ERROR | Inline control structures are not allowed
67 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
67 | ERROR | Space found after opening bracket of FOR loop
67 | ERROR | Space found before closing bracket of FOR loop
74 | ERROR | Missing function doc comment
78 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
79 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
81 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
86 | ERROR | Missing function doc comment
88 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
89 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
91 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
92 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
96 | ERROR | Missing function doc comment
97 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
97 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | Concat operator must be surrounded by spaces
98 | ERROR | Concat operator must be surrounded by spaces
101 | ERROR | Line indented incorrectly; expected 4 spaces, found 8
106 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
106 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
109 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
110 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
113 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...sites/all/modules/pareview_temp/test_candidate/sociallogin_widgets.info
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
5 | ERROR | It's only necessary to declare files[] if they declare a class or
| | interface.
7 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...tes/all/modules/pareview_temp/test_candidate/sociallogin_widgets.module
--------------------------------------------------------------------------------
FOUND 31 ERROR(S) AND 2 WARNING(S) AFFECTING 22 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Missing file doc comment
9 | ERROR | Missing function doc comment
14 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | Missing function doc comment
25 | ERROR | Expected "foreach (...) {\n"; found "foreach(...) {\n"
25 | ERROR | Line indented incorrectly; expected 2 spaces, found 8
25 | ERROR | Expected 1 space before "=>"; 0 found
25 | ERROR | Expected 1 space after "=>"; 0 found
27 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
27 | ERROR | Line indented incorrectly; expected 4 spaces, found 12
27 | ERROR | No space found after comma in function call
27 | ERROR | No space found after comma in function call
28 | ERROR | No space found after comma in function call
32 | ERROR | No space found after comma in function call
36 | ERROR | Missing function doc comment
39 | ERROR | Concat operator must be surrounded by spaces
39 | ERROR | Concat operator must be surrounded by spaces
44 | ERROR | Space before opening parenthesis of function call prohibited
46 | ERROR | Concat operator must be surrounded by spaces
46 | ERROR | Concat operator must be surrounded by spaces
47 | ERROR | Concat operator must be surrounded by spaces
47 | ERROR | Concat operator must be surrounded by spaces
49 | ERROR | Concat operator must be surrounded by spaces
49 | ERROR | Concat operator must be surrounded by spaces
74 | ERROR | Concat operator must be surrounded by spaces
75 | ERROR | Array indentation error, expected 6 spaces but found 8
75 | ERROR | Concat operator must be surrounded by spaces
76 | ERROR | Array indentation error, expected 6 spaces but found 8
77 | ERROR | Array indentation error, expected 6 spaces but found 8
79 | WARNING | A comma should follow the last multiline array item. Found:
| | 'oneall_social_login_providers'
80 | WARNING | A comma should follow the last multiline array item. Found: )
81 | ERROR | Array indentation error, expected 6 spaces but found 8
82 | ERROR | Array indentation error, expected 6 spaces but found 8
Comment #9
anilbhatt commentedComment #10
social login commentedCheck it now, please
Comment #11
millow commentedI'm really looking forward to this plugin. When will it be released?
Comment #12
ankitchauhan commented@anil, please do not paste the output of the review script in comment, a link or attached file is much better.
Comment #14
millow commentedThank you, but I need a professional solution. We already have a very big Wordpress Blog working with the Oneall Social Login Wordpress plugin and we want to stick with these guys.
Comment #16
millow commentedAlready tried, didn't suit my needs. Thank you.
Comment #17
misc commented@carie, seems that you are just doing advertising for another solution. Please do not do that here.
Comment #18
attiks commented@millow: please don't change category and priority
Comment #19
attiks commentedSome general remarks:
1/ You have functions with the same name ('sociallogin_oa_social_login_create_rand_email') in 2 different files:
2/ There's a file named settings.php: http://drupalcode.org/sandbox/oneall/1424874.git/blob/refs/heads/7.x-1.x...
3/ Start all your file with your module name sociallogin.admin.css, not admin.css
4/ There are still some spacing issue, try checking with coder on minor
Comment #20
social login commentedfixed but don't understand what is " ... checking with coder on minor" ?
Comment #21
attiks commentedHave a look at coder, it does check for coding standards, like spacing, comments, ...
Comment #22
social login commentedfixed
Comment #23
weebpal commentedReview of the 7.x-1.x branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
Source: http://ventral.org/pareview - PAReview.sh online service
Manual review:
- Could we improve the readability of our project, especially is the whitespace, for example sociallogin.admin.js.
Comment #24
patrickd commentedAww, please don't paste these ugly reports into issues.
please edit and provide a link instead :>
Also coding style is no reason for setting to needs work
Comment #25
bhamrick commentedIs there any particular reason you need to rely on cURL? Review drupal_http_request as it may increase your compatibility.
Your JS in sociallogin.admin.js should be properly indented to increase readability. Also, you should probably make use of Drupal Behaviors.
Comment #26
sylvain lecoy commentedManual review:
I'm not sure about your .install file, using a schema is the recommanded way to describe your database structure. Have a look at http://drupal.org/node/146939 for implementing correctly your schema.
You should indent your .admin.js, its not really readable and you must indent your code according to drupal best practises.
You should really avoid
$sql = "SELECT value FROM {sociallogin_settings} WHERE setting = '" . $field . "'";, use the db_select() function instead.Same remark for the sociallogin_core module.
I put this as Need work.
Comment #27
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.
Comment #27.0
klausiadded description