This new module provides functionality for translating content using transifex (http://www.transifex.org). That way, you can separate the process of writing the original content and translating it into different languages using an free, open source tool.

Drupal 6 only compatible.

git clone http://git.drupal.org/sandbox/sawidis/1423120.git transifex
cd transifex

Sandbox: http://drupal.org/sandbox/sawidis/1423120

Comments

vaibhavjain’s picture

vaibhavjain
he/him
Primary language Hindi
Location Delhi
commented
Status: Needs review » Needs work

Please follow the guidelines to apply for full project. http://drupal.org/node/1011698
provide the link to your sandbox project.

sawidis’s picture

sawidis commented

Hey vaibhavjain, tx for the quick reply. I apologize for missing that point. If you have any other comments, it would be great if you could share them with me =)

vaibhavjain’s picture

vaibhavjain
he/him
Primary language Hindi
Location Delhi
commented

Please check an automated review of you code here http://ventral.org/pareview/httpgitdrupalorgsandboxsawidis1423120git. You can also use this for future reviews as well.

sawidis’s picture

sawidis commented

I've adjusted the code to the results of the automated tool.

Btw, do you know if I can delete some commits residing in the remote repo? I've kinda polluted my history trying to reduce the number of errors I got from the automated tool. I know it's never a good idea to delete commits from the remote repo but currently I'm the only one who works on it. It would be great if there was a way to push the squashed version of them.

sawidis’s picture

sawidis commented
Status: Needs work » Needs review
bart.hanssens’s picture

bart.hanssens commented
Status: Needs review » Needs work

Hi, some recommendations:

  • you should not use the master branch on git, use 6.x-... instead (see http://drupal.org/node/1015226)
  • transifex.module contains define's like "DRUPAL_APP_URL", best practice is to start these with the name of your module (so, TRANSIFEX_APP...) to avoid name collisions
  • perhaps DRUPAL_APP_URL (or rather TRANSIFEX....) should be configurable instead of being hard-coded
  • the code contains db_query("INSERT...") and db_query("UPDATE..."), which is technically ok, but the preferred Drupal way is using drupal_write_record (http://api.drupal.org/api/drupal/includes!common.inc/function/drupal_wri...)
sawidis’s picture

sawidis commented

Oh, I've just seen the reply. Thanks bart, I'll take a look as soon as possible.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

add sandbox link