Moneybookers Payment Module

Hello tahiralmas,

Please follow the guidelines to apply for full project access. http://drupal.org/node/1011698
Also, you have used master branch to include all your code, please use version specific branches like for D7 use 7.x-1.x

These files do not belong in the repository, and should be removed:

.uc_moneybookers.module.swl
.uc_moneybookers.module.swm
.uc_moneybookers.module.swn
.uc_moneybookers.module.swo
.uc_moneybookers.module.swp
LICENSE.txt
translations
uc_moneybookers.module~

As @vaibhavjain said, you should not have all the code in the master branch. For more info see http://drupal.org/node/1127732

Is CheckPaymentOptions.js your code or is it Moneybooker's code? Third-party code doesn't belong in the repository, so please clarify this issue. If it's yours, it should be renamed to agree with your module name.

You need to change your code to conform to Drupal's Coding Standards.

Hei your module needs more that 1000 coding style fixes.
I know thats a lot and pain in the ass the fix, but after you understand and think about these this will be easier.
If I would be you I would use http://drupal.org/project/drupalcs This helped me on the road :p

You haven't addressed *any* of the issues I raised in #3...

Manual review (of branch 7.x-1.x):

Master Branch

It appears you are working in the "master" branch in git. You should only be working in a version specific branch. The most direct documentation on this is . For additional resources please see the documentation about release naming conventions and creating a branch in git.

Maintain info in the README

Please remove maintain info from all the files. This is just needed in the README. Also remove the info about signing up from the .module

No $Id$

Please remove $Id$, they are not needed

Strange access permission?

The access permission uc_moneybookers_access seem strange to me - it always return TRUE, what kind of check is that?

Licensing issues

Are the images included in the module created by you or licensed some how?

Naming of php variables

I think it is quite confusing to have variables like $title2 and $title23, you should really name them in a better way

Hard coded $data?

In uc_moneybookers_vmail_submit you have:

  $url = 'https://www.moneybookers.com/app/email_check.pl';
  $email = $form_state['values']['uc_moneybookers_sea'];
  $data = 'email=' . $email . '&';
  $data .= 'cust_id=6999381&password=a4ce5a98a8950c04a3d34a2e2cb8c89f';

You have a hard coded cust_id and password here, why?

Hard coded cust_id

You have again a hard coded cust_id in uc_moneybookers_validate_sw_submit, why?

Hard coded adress to moneybookers

should it not be better to have the default email adress to moneybookers is a default value, instead of hard coded in php? It maybe could change, and if it changes you have to edit the module code

wla_logging

You function wla_logging should really not be in this module, should it?

This is not a fully manually review, I think there are more stuff to work on, but you should look into the issues above to get this further. Please participate in the Review bonus program to get faster responses.

You should not assign applications to yourself, here we only assign issues to users who are doing manual reviews, so nobody else start doing that during the time. Also added security tag for the access permissions on hook_menu.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Added link to sandbox and repo to clone.