Reviewed & tested by the community
Project:
Text Resize
Version:
7.x-1.9
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
4 Feb 2012 at 07:27 UTC
Updated:
13 Feb 2015 at 19:17 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dlsmore commentedI also would love this feature to be added! It seems like the changes would be easy to make, although I am not a php coder so I'm not sure how it would actually be done...
Can anyone suggest how to make this change?
Comment #2
dlsmore commentedOk, turns out it was easier than I expected. Just some minor modifications to sites/all/modules/text_resize/text_resize.js
I don't know how to make patches and whatnot, but here's the modified code:
Now you can input multiple CSS ids/classes into the scope field (comma-separated), and they will all be changed at the same time.
Comment #3
W.M. commentedThanks dlsmore, I will test the suggested modifications in the near future
Comment #4
attheshow commentedHere are instructions on how to create a patch:
http://drupal.org/patch/create
Comment #5
W.M. commentedI have tried this but it looks like it is not working as specified..
Comment #6
Tyler the Creator commentedHey, I believe that I've managed to fix #2's code. Let me know if this works..
Comment #7
si.mon commentedHey, I've managed to apply tpeppers patch and it seems to work.
I also changed the way the selectors are used. With the attached patch, classic jquery selectors can be used as for instance:
#main, .node-page pCould someone take a look at this ?
Comment #8
si.mon commentedWoops, wrong patch sorry !
Fixed patch attached.
Comment #9
mrpauldriver commentedI am struggling to this working.
Can a patch be made available for 1.8?
Comment #10
socialnicheguru commentedPatch in #8 does not apply
git apply text_resize-js-7.x-1.7_1.patch
text_resize-js-7.x-1.7_1.patch:10: trailing whitespace.
attach: function(context) {
text_resize-js-7.x-1.7_1.patch:11: trailing whitespace.
var element_to_resize = [];
text_resize-js-7.x-1.7_1.patch:23: trailing whitespace.
var text_resize_scope_array = text_resize_scope.split(", ");
text_resize-js-7.x-1.7_1.patch:24: trailing whitespace.
for (i=0; i text_resize-js-7.x-1.7_1.patch:25: trailing whitespace.
if ($(text_resize_scope_array[i]).length > 0) {
fatal: corrupt patch at line 192
Comment #11
socialnicheguru commented#2 does work
Comment #12
si.mon commentedCreated a new patch file which should work.
I would really like to see this commited, could someone review this ?
Thanks :)
Comment #13
si.mon commentedComment #14
jannis commentedjust about to post my own patch -- tried your patch in #12 -- all works well with v1.8 here. Nice work and thanks!
Comment #15
si.mon commentedThanks for the feedback !
Could some else test it so we can change the status to RTBC ?
Comment #16
Tyler the Creator commentedTested #12 with ids, classes and elements and everything worked as planned.
Comment #17
si.mon commentedGreat thanks #16
Could you change this issue to RTBC ?
Comment #18
Tyler the Creator commentedPatch #12 tested by multiple users and looks good.
Comment #19
dcampos commentedOnly the reset button needed some work.
I created some fields to enter the default values of line-height and font-size, separating it from minimum size field.
Comment #20
dcampos commentedNow the patch I've talked at #19
Comment #21
rcodina@dcampos, reroll patch please, it needs to cleanly apply to dev branch. Thanks!
Comment #22
rcodinaI have rerolled patch to apply to dev, please review it.
Comment #23
rcodinaComment #24
rcodinaSorry, patch on #22 doesn't correclty apply. Try this new one.
Comment #25
rcodinaComment #26
Tyler the Creator commentedBlast from the past! I just tested this patch on a new site and it all works. Would be nice to get this committed one day.
Patch on #24 works with 7.x-1.9 and 7.x-1.x-dev.
Comment #27
Tyler the Creator commentedComment #28
Tyler the Creator commentedJust realized that the patch removes the persistency of the resize when changing pages/reloading. Will have to look into seeing where that code it overwritten.
Comment #29
Tyler the Creator commentedSorry for the spam... just realized that the cookie storing is now part of the config -_-;