Wysiwyg Setup

The response time for a review is now approaching 4 weeks. Get a review bonus and we will come back to your application sooner.

The module seems to be as intended but i noticed the following problems:

1. You need to remove the commented out code on line 13 in wysiwyg_setup.module
2. I'm not quite sure why you split the code in two modules, they can't work without each other so it should be quite easy to merge them into one.
3. On line 145 fe_wysiwy.features.wysiwyg.inc you refer hardcoded to sites/all/modules/custom/wysiwyg_setup/wysiwyg.css. you should replace it by a drupal_get_path instead.
4. You should review the errors in the automated report attached in the previous comment

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Review of the master branch:

• ./fe_wysiwyg/fe_wysiwyg.features.wysiwyg.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  
  

  <br>
  function fe_wysiwyg_wysiwyg_default_profiles() {<br>
  

• ./fe_wysiwyg/fe_wysiwyg.features.user_role.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  
  

  <br>
  function fe_wysiwyg_user_default_roles() {<br>
  

• ./fe_wysiwyg/fe_wysiwyg.features.user_permission.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  
  

  <br>
  function fe_wysiwyg_user_default_permissions() {<br>
  

• ./fe_wysiwyg/fe_wysiwyg.features.filter.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  
  

  <br>
  function fe_wysiwyg_filter_default_formats() {<br>
  

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

</code></p><code>
<p>FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt<br>
--------------------------------------------------------------------------------<br>
FOUND 1 ERROR(S) AND 2 WARNING(S) AFFECTING 3 LINE(S)<br>
--------------------------------------------------------------------------------<br>
  8 | WARNING | Line exceeds 80 characters; contains 81 characters<br>
 26 | WARNING | Line exceeds 80 characters; contains 81 characters<br>
 47 | ERROR   | Files must end in a single new line character<br>
--------------------------------------------------------------------------------</p>
<p>FILE: .../pareview_temp/test_candidate/fe_wysiwyg/fe_wysiwyg.features.filter.inc<br>
--------------------------------------------------------------------------------<br>
FOUND 8 ERROR(S) AFFECTING 8 LINE(S)<br>
--------------------------------------------------------------------------------<br>
  13 | ERROR | Inline comments must end in  full-stops, exclamation marks, or<br>
     |       | question marks<br>
  38 | ERROR | Array indentation error, expected 10 spaces but found 0<br>
  39 | ERROR | Array indentation error, expected 10 spaces but found 0<br>
  40 | ERROR | Array indentation error, expected 10 spaces but found 0<br>
  41 | ERROR | Array indentation error, expected 10 spaces but found 0<br>
  42 | ERROR | Array indentation error, expected 10 spaces but found 0<br>
  43 | ERROR | Array indentation error, expected 10 spaces but found 0<br>
 173 | ERROR | Inline comments must end in  full-stops, exclamation marks, or<br>
     |       | question marks<br>
--------------------------------------------------------------------------------</p>
<p>FILE: ...review_temp/test_candidate/fe_wysiwyg/fe_wysiwyg.features.user_role.inc<br>
--------------------------------------------------------------------------------<br>
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)<br>
--------------------------------------------------------------------------------<br>
 13 | ERROR | Inline comments must end in  full-stops, exclamation marks, or<br>
    |       | question marks<br>
--------------------------------------------------------------------------------</p>
<p>FILE: ...s/all/modules/pareview_temp/test_candidate/fe_wysiwyg/fe_wysiwyg.module<br>
--------------------------------------------------------------------------------<br>
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)<br>
--------------------------------------------------------------------------------<br>
 5 | ERROR | Files must end in a single new line character<br>
--------------------------------------------------------------------------------</p>
<p>FILE: ...l-7-pareview/sites/all/modules/pareview_temp/test_candidate/wysiwyg.css<br>
--------------------------------------------------------------------------------<br>
FOUND 5 ERROR(S) AFFECTING 3 LINE(S)<br>
--------------------------------------------------------------------------------<br>
  4 | ERROR | Whitespace found at end of line<br>
 18 | ERROR | Expected exactly one new line after opening brace of class<br>
    |       | definition<br>
 18 | ERROR | Class definition is empty<br>
 20 | ERROR | Expected exactly one new line before closing brace of class<br>
    |       | definition<br>
 20 | ERROR | Files must end in a single new line character<br>
--------------------------------------------------------------------------------</p>
<p>FILE: ...iew/sites/all/modules/pareview_temp/test_candidate/wysiwyg_setup.module<br>
--------------------------------------------------------------------------------<br>
FOUND 2 ERROR(S) AFFECTING 1 LINE(S)<br>
--------------------------------------------------------------------------------<br>
 13 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 0<br>
 13 | ERROR | 8 spaces found before inline comment; expected "//<br>
    |       | dpm($settings);" but found "//        dpm($settings);"<br>
--------------------------------------------------------------------------------</p>

FILE: ...review/sites/all/modules/pareview_temp/test_candidate/wysiwyg_styles.js<br>
--------------------------------------------------------------------------------<br>
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)<br>
--------------------------------------------------------------------------------<br>
 1 | ERROR | Comments may not appear after statements.<br>
 9 | ERROR | Whitespace found at end of line<br>
--------------------------------------------------------------------------------<br>

Source: http://ventral.org/pareview - PAReview.sh online service

@Robertas
please don't paste these automated reports into issue, they're cluttering the issue and can be quite demotivating as applicants feel like "hitting the wall of errors".

@shunitben
Correcting coding standards of features output makes no sense as, once you're doing some changes and have to re-export it, it's ugly again. So you can ignore these issues.

This worked perfectly for me

Thanks for your contribution, shunitben! Welcome to the community of project contributors on drupal.org.

I have promoted this Feature for you: http://drupal.org/project/wysiwyg_setup

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.