Comments

Jeff Burnz’s picture

Assigned: Unassigned » Jeff Burnz

OK ok I will fix it, lol, cheers for the kick in the pants ;)

Jeff Burnz’s picture

Component: Admin theme » CSS/HTML

Hmm, what browser/version and OS are you using?

joachim’s picture

Firefox 9.0.1 on OS X 10.6.8.

Jeff Burnz’s picture

I don't have access to any OSX machine at the moment, soon but not right now.

Can you tell me what the top and left values are for div#autocomplete inline styles? They will or should be something like top: 45px; left: 0px, I suspect the left value will be 15px in your browser...

Now, Seven does not apply any left or right padding to the .form-item .fieldset-wrapper, whereas AT Admin does, in fact it adds 15px, this is the only padding I can logically see that might be causing this issue, however it makes me wonder if the problem is with a) the theme, b) autocomplete.js or c) jQuery method .position()

Just gonna thow this out there and if you are able please test this, I am not very hopeful it will work but its worth a crack, add this to the end of at_admin.css. The first two declarations will fix the annoying misaligned throbber and last will put a position: relative on the field-item wrapper - what I am interested in is if this will trigger the correct left value in the inline styles:

html.js input.form-autocomplete {
  background-position: 100% 4px;
}
html.js input.throbbing {
  background-position: 100% -16px;
}
div.form-type-textfield {
  position: relative;
}
nikkubhai’s picture

Component: CSS/HTML » AT Admin
StatusFileSize
new36.72 KB

I am having similar problem. I am using Corolla + Adaptive Theme. Thanks. Please see the screenshot

joachim’s picture

Those extra rules fix the problem.

Should I be looking for something elsewhere that they might be breaking?

Jeff Burnz’s picture

I made a mistake in #4. The 15px padding is added to the .fieldset-wrapper.

AFAICT jQuery .position() method calculates the position of the dynamic element relative to the parent element, but I am not sure if this is meant to be the input or the wrapper (in this case div.form-item), either way it seems that adding padding to the grandparent element (.fieldset-wrapper) is messing this up in FF OS X.

So, if using position: relative on the .form-item wrapper fixes the misaligned autocomplete drop down, I am pretty happy with that, but it does indicate either a problem with .position(), or Drupal cores implementation of it in autocomplete.js, I can't see anything in the docs for .position() that indicates padding on the grandparent element should be taken into consideration when using this.

Jeff Burnz’s picture

@nikkubhai, yes I am dealing with that in another issue: #1349168: Autocomplete widget background is transparent

pvhee’s picture

StatusFileSize
new6.56 KB

The solution in #4 with the correction in #7 still does not solve the throbber misalignment in the autocomplete, using FF on OSX, see image.

This is after applying the css from #1349168: Autocomplete widget background is transparent

Any help greatly appreciated!

Jeff Burnz’s picture

Status: Active » Fixed

#4 is not a complete fix for Corolla, what i did in the end was reduce the padding on all inputs from 6px down to 4px, this actually solved a lot of other small niggly issues with forms. I committed to dev the other day, so this should be fixed, fingers crossed, I don't have an OSX machine handy atm.

joachim’s picture

Status: Fixed » Active

Not sure which version I should look at to check the fix works for me. I assume 7.x-3.x-dev since that's the only one with commits newer than 29 Feb. Anyway, I can to report that with 3.x-dev and a cache clear, it still looks the same. Sorry!

joachim’s picture

Status: Active » Fixed

Sorry -- my mistake. I had the dev and local copy of the site open in tabs in the same window. Sorry for the confusion! All looks fine.

Jeff Burnz’s picture

Be weary of devving on 7.x-3.x, its a big monster in transition, its turning into a rewrite, but should still be backwards compatibly, mostly...

joachim’s picture

The date of the 7.x-2.x-dev release is 2012-Feb-17 which is earlier than your 'fixed' comment, so I assume it's only fixed in 3.x?

Jeff Burnz’s picture

Version: 7.x-2.1 » 7.x-2.x-dev
Status: Fixed » Active

I think so, will back-port it. Up to my ears in code right now, lol.

Jeff Burnz’s picture

Status: Active » Closed (fixed)

OK, I will commit a fix to the 2.x branch shortly, aka:

This seems to fix the issues in the core theme.

/* Fix autocomplete drop downs */
#autocomplete {
  background: #fff;
}
#autocomplete li {
  display: block;
  color: #000;
}
grincon’s picture

It looks like this also affects 7.3 is this fix there already? Should it be?