When using shipping notification, the workflow status isn't updated to to "shipped", which creates extra work and really defates the purpose of the function.

The fix comes in 2 parts

  • The change to shipping/shipping.module simply forces the workflow to be updated (desired behaviour imo)
  • The change in store/store.module add a hidden form value when the update is forced, which is checked in the submit callback

I found both fixes were required to resolve the bug, hence the single patch

CommentFileSizeAuthor
#3 fix-shipping-workflow-flux3.patch1.06 KBdjflux
#2 fix-shipping-workflow-flux2.patch1.75 KBdjflux
#1 fix-shipping-workflow-flux.patch1.1 KBdjflux
fix-shipping-workflow.patch1.11 KBskwashd

Comments

djflux’s picture

djflux commented
StatusFileSize
new fix-shipping-workflow-flux.patch1.1 KB

I'm still having an issue even after applying this patch. When I click on 'shipping notify' I still receive and error

Mail template for shipping_notification could not be found!

I believe the ECMAIL_TYPE_SHIP_NOTICE in the '+' line in the patch should be changes to MAILVAR_SHIP_NOTICE

I've modified your patch to indicate this change. However it only partially works for me.

If I do not check the "Notify Customer" box then I am returned to whatever page the "destination" variable points and the workflow is updated to 'shipped.' However, if I check the notify box then I'm not returned to the destination page and the workflow is not updated.

djflux’s picture

djflux commented
StatusFileSize
new fix-shipping-workflow-flux2.patch1.75 KB

The store_transaction_mail_form_submit function (in store/store.module) is never called when the submit button is pressed on the shipping notification. The ec_mail_send_varmail function (in ec_mail/ec_mail.module) seems to be called when the Submit button is pressed. For some reason something gets "stuck" in ec_mail_send_varmail.

If I add 

store_transaction_mail_form_submit($form_id, $fv);

as the last line in ec_mail_send_varmail then the transaction workflow is updated.

I've attached another patch that seems to make everything (except the Preview button) work as expected (no shipping notification error, workflows update, destinations work, emails work). Being a Drupal newb, this patch may be another hack, but it builds on the one that skwashd submitted above.

djflux’s picture

djflux commented
StatusFileSize
new fix-shipping-workflow-flux3.patch1.06 KB

Updated patch to apply to 5.x-3.x-dev tarball as of 2007-06-05. Works along with patch here:

http://drupal.org/node/150228

brmassa’s picture

brmassa commented
Status: Needs review » Patch (to be ported)

Guys,

fixed on eCommerce 4. eC3 still needs the patch.

regards,

massa

gordon’s picture

gordon commented
Status: Patch (to be ported) » Fixed

ported to 5.x-3.x-dev

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
crossbow’s picture

crossbow commented
Status: Closed (fixed) » Active

hey guys I know it's been a while and that you are not really supporting ec3 any more but I really need this as I'm using it along with openresort for online booking. Basically I've tried the patches (in clean install) and they are not working....The workflow doesn't change for shipping and no mail is being send. I can change the workflow to shipped via the edit button, but it's not really helping as the mail is not being sent (I need it of openresort).

I've tried both 5.x-3.4 and 5.x-3.x-dev...any help would be really appreciated it

davea’s picture

davea commented
Status: Active » Postponed (maintainer needs more info)

crossbow- can you confirm this still exists?

Thanks,
DaveA