This bug is spread across ec_mail, store, and shipping.

1. The various txn tokens aren't substituted in shipping notifications because the type isn't registered in the store module.
2. A non-existent token is used in the shipping notification mail: [txn-billing-name], should probably be [txn-billing-firstname]. (This might be a bug in the translation code from the old-style mail templates, but I didn't look into that.)
3. When you try to send a shipping notification, it sends the mail but dumps you back to the notification form because it's testing for ec_mail_send_mail returning true, and it returns nothing.

Patch attached fixing all this.

CommentFileSizeAuthor
#2 mail_10.patch3.22 KBdjflux
#1 mail_9.patch4.08 KBkemayo
mail_8.patch4.07 KBkemayo

Comments

kemayo’s picture

kemayo commented
StatusFileSize
new mail_9.patch4.08 KB

I'd missed on broken token ([items]) in the default mail. Thus I upload a new patch.

djflux’s picture

djflux commented
StatusFileSize
new mail_10.patch3.22 KB

token [txn-order_date] should be [txn-order-date] ('-' instead of '_')

dman’s picture

dman commented
Status: Needs review » Reviewed & tested by the community

Thanks for this patch, it appears to be behaving better than before!

On investigation (and possibly unrelated, due to hybrid versions) I had to run 

shipping_mail_reset(ECMAIL_TYPE_SHIP_NOTICE);

in order to get the updated mail template actually recognised.
I was getting "Cannot find template for shipping_notify" or words to that effect.

Thanks heaps. I patched by hand (I don't trust Win the platform I'm on today)
but a +1 critical for this repair.

brmassa’s picture

brmassa commented
Status: Reviewed & tested by the community » Patch (to be ported)

Guys,

its fixed on eCommerce4. eC3 still needs the patch.

regards,

massa

gordon’s picture

gordon commented
Status: Patch (to be ported) » Fixed

Ported to 5.x-3.x-dev and 4.7.x-3.x-dev

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
crossbow’s picture

crossbow commented
Status: Closed (fixed) » Active

hey guys I know it's been a while and that you are not really supporting ec3 but I really need this as I'm using it along with openresort for online booking. Basically I've tried the patches (in clean install) and they are not working....There is no mail being sent and the workflow doesn't change...

I've tried both 5.x-3.4 and 5.x-3.x-dev...any help would be really appreciated it

davea’s picture

davea commented
Status: Active » Closed (fixed)

duplicate of http://drupal.org/node/143245 so I am closing this one.

Thanks,
DaveA