Followed this to http://drupal.org/node/1354202 to add files with node.create. It works for me to create, but if I follow the same method for adding new files to my node on update, they will only be created (added to file_managed) but not connected to the node. But if I update title or description on an existing file it will be updated. It seems like you only can specify fid for the files when creating, not updating. It will skip those files.

It seems like the form_builder method strips the field_files from the new files when I do node.update?

Here is the array for the PUT. fid 185 was added one node.create and here I changed the title and the title for that file is updated. But the other file which is new for the update request, it is not added to the node when updated. Any ideas? Do I need to set a flag on the node or the field for it to store "new files"?

[field_files] => Array
(
  [und] => Array
  (
    [0] => Array
      (
        [fid] => 185
        [display] => 1
        [title] => My name
        [description] =>
      )
    
    [1] => Array
      (
        [fid] => 186
        [display] => 1
        [title] => 
        [description] => My description
      )
  )
)
CommentFileSizeAuthor
#14 services-node_user_updates_ignore_new_files-1433254-14.patch1.42 KBruloweb
#11 user.update_fid_fix-1433254-11.patch798 byteslex0r

Comments

kylebrowning’s picture

kylebrowning commented
Version: 7.x-3.1 » 7.x-3.x-dev
Category: support » bug
drewschmaltz’s picture

drewschmaltz commented

workaround:

foreach($form_state['values'] as $key => $value) {
  if(array_key_exists($key,$old_node)) {
    $old_node->{$key} = $value;
  }
}
jyloo’s picture

jyloo commented

wow, i used a whole night trying to troubleshoot this problem until i found your code here.Work like charm!!
Now my update page can delete and add in new item well.

thanks.

btw if i use this code, would the field still perform the validation part correctly?

farhadhf’s picture

farhadhf commented

Hi,
I'm having the same problem, where should I put the code in #2? I have this code right now:

function mymodule_node_submit($node, $form, $form_state) {
  foreach($form_state['values'] as $key => $value) {
    if(array_key_exists($key,$node)) {
      $info = field_info_field($key);
      if ($info && ($info['type'] == 'image' || $info['type'] == 'file')) {
        $new_values = array(LANGUAGE_NONE => array());
        // $value contains an item with fid=0, we don't wanna insert an empty file into file_managed table. taking it out!
        foreach ($value[LANGUAGE_NONE] as $item) {
          if (isset($item['fid']) && $item['fid'] > 0) {
            $new_values[LANGUAGE_NONE][] = $item;
          }
        }
        $node->{$key} = $new_values;
      }
    }
  }
}

but it's not working.

Thanks!

emilkarl’s picture

emilkarl commented

My guess is you should update the node resource in Services module...

File: services/resources/node_resource.inc
Function: _node_resource_update
Line: No idea?

emilkarl’s picture

emilkarl commented

Where should this go? Is it fixed in 7.x-3.3?

farhadhf’s picture

farhadhf commented

Hi,
I changed my code and now it's working, maybe this will help someone later!

/**
 * Implements hook_node_submit().
 */
function mymodule_node_submit($node, $form, $form_state) {
  foreach($form_state['input'] as $key => $value) {
    if(array_key_exists($key,$node)) {
      $info = field_info_field($key);
      if ($info && ($info['type'] == 'image' || $info['type'] == 'file')) {
        $new_values = array(LANGUAGE_NONE => array());
        foreach ($value[LANGUAGE_NONE] as $item) {
          if (isset($item['fid']) && $item['fid'] > 0 && file_load($item['fid'])) {
            $new_values[LANGUAGE_NONE][] = $item;
          }
        }
        $node->{$key} = $new_values;
      }
    }
  }
}
farhadhf’s picture

farhadhf commented
Issue summary: View changes

More accurate description

wedge’s picture

wedge commented
Issue summary: View changes

For the archives: I put the code from #2 (thanks drewschmaltz) right before the call to drupal_form_submit($node_type . '_node_form', $form_state, $old_node); in _node_resource_update().

And that seems to work.

lex0r’s picture

lex0r commented
Priority: Major » Critical

I can't believe this major issue is still active and without a patch :)
I can confirm I see the same situation with user.update, which can promote this issue to "critical". I will post a patch for user.update here later.

lex0r’s picture

lex0r commented
Title: Node.update ignores new files » Node.update and user.update ignores new files
lex0r’s picture

lex0r commented
StatusFileSize
new user.update_fid_fix-1433254-11.patch798 bytes

Here is a patch for 7.x-3.11 that handles user file updates. Use it very cautiously as it's not a proper way of fixing the issue. It was impossible to bind to hook_user_submit() like above, because this hook just doesn't exist.

kylebrowning’s picture

kylebrowning commented
Status: Active » Needs review
kylebrowning’s picture

kylebrowning commented
Status: Needs review » Needs work

Yeah this patch only works for user update, we need it for nodes too....

ruloweb’s picture

ruloweb commented
StatusFileSize
new services-node_user_updates_ignore_new_files-1433254-14.patch1.42 KB

Hi guys, I spended a lot of time debugging this issue and these contributions help me to solve it.

I created a patch which merges #2 and #11, it applies on 3.x-dev and 3.12.

Thanks!

kylebrowning’s picture

kylebrowning commented
Status: Needs work » Needs review
kylebrowning’s picture

kylebrowning commented

Can anyone verify this latest patch works?

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Closed (won't fix)

Dude to this being label as use cautiously, and no support for a new patch, closing as wont fix.