Tweejet

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Review of the master branch:
Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
Remove "version" from the info file, it will be added by drupal.org packaging automatically.
Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project.

Hi Alesr

• You should create a tweejet.install file. In your module you define variable from your configuration form. In your install file you must implement hook_uninstall() and remove your variable tweejet_* . See Writing .install files

Hi, alesr

Your module works fine. Just two very little comments :

1/ in tweejet_menu() title and description should not use t().

Change

$items['admin/config/content/tweejet'] = array(
    'title' => t('Tweejet settings'),
    'description' => t('Tweejet main configuration'),
    'page callback' => 'drupal_get_form',
    'page arguments' => array('_tweejet_settings'),
    'access arguments' => array('access administration pages'),
    'type' => MENU_NORMAL_ITEM,
  );

by

$items['admin/config/content/tweejet'] = array(
    'title' => 'Tweejet settings',
    'description' => 'Tweejet main configuration',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('_tweejet_settings'),
    'access arguments' => array('access administration pages'),
    'type' => MENU_NORMAL_ITEM,
  );

2/ In automated review :

FILE: ...pareview/sites/all/modules/pareview_temp/test_candidate/tweejet.install
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 20 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

Just another remarks :

• In line 80 of your tweejet module, you use json_decode. You should use drupal_json_decode(). You should read this page about PHP wrapper functions
• I d'ont think it is an error but why you use t() function in line 102 & 110 (in tweejet.module) ?

After this should do it ;)

Hi Alesr,

Apparently you have not commited your modification on git ?

Hi Alesr,

Sorry is my fault, but where you run Pareview.sh I have this error in line 102....

--------------------------------------------------------------------------------
 102 | ERROR | The $text argument to l() should be enclosed within t() so that
     |       | it is translatable
--------------------------------------------------------------------------------

It is the username link... So not translatable... Just correct this for other validation.

But It is correct for me. No error, and the module work as supposed. So RTBC.

Good work ;)

Would you like to take part in the review bonus program? I personally only review/approve applications with a review bonus, but of course you can also wait for other git administrators to take a look at your code.

I'm not sure how this module differs from the tons of existing twitter modules (eg. Twitter DB, Twitter, Twitter Profile widget and Twitter Block)

Please give us an idea of how your module does differ from these and why your module is needed. (Just want to make sure we don't do the 'yet another twitter module' duplication here).
If your module does not differ from those above, I'd appreciate if you think about joining forces with the maintainers and help them enhancing the module that comes nearest to yours.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.