I've installed (and patched, yes) the latest cvs build of this module with both 4.5.0, 4.5.1 and the cvs builds of drupal. The new "Create" option works a charm!

Unfortunately...

Now it would seem that the "view" portion is broken ;-) It allows all users (including the "anonymous", not logged in user) to view all terms.

I've duplicated this behaviour among 2 different sites, running 3 different versions fo drupal (4.5.0 4.5.1 and cvs-dec13).

Perhaps it's a small fix?

cheers,

Kieran

CommentFileSizeAuthor
#12 taxonomy_access_rid0_sql.patch660 bytesnjivy

Comments

Kieran Huggins’s picture

Kieran Huggins commented
Title: Anonnymous access to all terms » Tipe-Oh

sorry about the typo.. don't I feel foolish!

Kieran Huggins’s picture

Kieran Huggins commented
Title: Tipe-Oh » Anonymous, unrestricted access to all terms
Project: Taxonomy Access Control » Attachment

typo fixed, please disregard. (could I dig myself much deeper? ;-)

pyromanfo’s picture

pyromanfo commented

Fixed in CVS, grantbow nailed it.

Kieran Huggins’s picture

Kieran Huggins commented
Project: Attachment » Taxonomy Access Control

somehow the project associated with this issue became "attachment".. trying to reset, not working... ack!

at any rate, the issue was fixed by grantbow in the cvs buid, if anyone wants to know...

issue thread seems to be stuck here: http://drupal.org/node/14367

Kieran Huggins’s picture

Kieran Huggins commented

patch complains that the new patch is malformed:

patch: **** malformed patch at line 84: @@ -474,7 +492,10 @@

I don't know enough about patches to debug :-(

pyromanfo’s picture

pyromanfo commented

That's what I get for manually editing a patch file :(

It should actually be fixed now.

Kieran Huggins’s picture

Kieran Huggins commented

this is probably either my ignorance or a fault with the cvs system, but there hasn't been a change in the cvs download since before the fix this morning at 10 am... am I looking in the wrong place?

pyromanfo’s picture

pyromanfo commented

http://cvs.drupal.org/viewcvs/drupal/contributions/modules/taxonomy_acce...

Kieran Huggins’s picture

Kieran Huggins commented

I'm convinced I must be retarted.... i can't seem to get this patch successfully downloaded and installed. I thought I had at one point, but the problem persisted! Could someone please graciously attach the current patch (1.7 I think) to a reply?

tia, k

pyromanfo’s picture

pyromanfo commented

Okay, that was my bad. I put the files in the wrong order in the diff command, whoops :)

I tested it this time and it does work.

Kieran Huggins’s picture

Kieran Huggins commented

I was able to patch the file before using the -R flag (for just such occasions), but the hidden terms are still "view"able :-( perhaps there's another bug somewhere?

njivy’s picture

njivy commented
StatusFileSize
new taxonomy_access_rid0_sql.patch660 bytes

http://drupal.org/node/13902#comment-17191

I think this is the same bug. The default is 'viewable', we perform a logical OR of the default with the current user, and the result will always be 'viewable'. If I edit the SQL in taxonomy_access() near line 313, things work better for me. I am using Drupal 4.5.1.

(Oh, and it would be nice if the files had CVS IDs in them so we could easily tell which version we're working with. ;)

pyromanfo’s picture

pyromanfo commented

I wasn't seeing this problem anyway, as they were hidden on mine before the patch.

However, since 4.5.1 has been out a while, I went ahead and applied the patch and updated the sql to not add those default 'view all' entries since they no longer make any sense after removing the default category and having to install the module from settings.

Kieran Huggins’s picture

Kieran Huggins commented

I think I'm starting to nail down the problem... It seems that anonymous AND authenticated users are being given the same permissions, being the sum (OR) of the two.

The same problem doesn't exist for newly created roles...

any ideas?

Kieran Huggins’s picture

Kieran Huggins commented

I think I may have something here...

in taxonomy_access.module commenting out the following part of the taxonomy_access() function (line 294) seems to do the trick!

/*  if ($taxonomy == NULL)
    $tid = 0;  // check the default access
  else */if (is_numeric($taxonomy))
    $tid = $taxonomy;
  else if ($taxonomy->tid)
    $tid = $taxonomy->tid;
  else return FALSE;

this seems to work for me.. does it make sense to you guys?

cheers,
kieran

Kieran Huggins’s picture

Kieran Huggins commented

let me clarify.. it works on one site, not on the other... ack! I'm thoroughly confused now...

ron_mahon’s picture

ron_mahon commented

Let me add to the confusion when using the taxonomy_context module, I have a problem where the right side bar is inside of the content frame.

The effect is to squeeze the contents of the content frame. The sidebar table is side of the content table.

“

”

If you call the page up directly it displays normally

It is width sensitive some pages display fine. On a page with a lot of info the effect is that the side bar is so small you cant read it.

You can see it at
http://intensive-care-Ministries.com/?q=taxonomy/term/8

There is no side bar until you get towards the bottom of the page

Running 4.5.1

Regards
Ron Mahon

pyromanfo’s picture

pyromanfo commented

You should start another issue, though taxonomy_access outputs nothing to the screen. This is a problem for the taxonomy_context guys. We cannot be causing this directly anyway, if they don't support taxonomy_access hiding taxonomies then they might have a bug.

As to the other problem, since you're only having this problem on one site try disabling then uninstalling the module and deleting everything from term_access in the DB. Then reinstall and see if it goes away.

Kieran Huggins’s picture

Kieran Huggins commented

my problem.... I finally tracked down the issue to my users_roles table... had uid 0 set to rid 2 instead of 1.. not sure why, but it's fixed now!

thanks a bunch for your help, and this module in general!

cheers,

kieran

Anonymous’s picture

(not verified) commented