see http://drupal.org/node/143916 for the background -- someone foolishly added a cvs watch on some files in the contrib repo, even though the repo isn't configured to notify anyone for watch activity, anyway. this meant that the .info file was being checked out by the packaging script chmod 444, so fix_info_file_version() couldn't open the file for writing to append the version, datestamp, etc.

a) at the very least, we should chmod any .info file before we try to open it, to defend against this sort of thing in the future.
b) we should consider doing a find-based chmod (or something) to ensure sane file permissions in the tree before we create a tarball.

CommentFileSizeAuthor
#1 package-release-nodes-info-chmod.patch.txt853 bytesdww

Comments

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » dww
Status: Active » Needs review
StatusFileSize
new package-release-nodes-info-chmod.patch.txt853 bytes
dww’s picture

dww
we/he/they
commented

i re-created the bug with the cvs watch on one of my projects, and tested a copy of this on d.o -- all worked fine. so, the only question is if this patch is sufficient, or we should do a more thorough chmod() solution when creating the tarballs. anyone?

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Reviewed & tested by the community

looks good to me.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Fixed

commited to HEAD and installed on d.o.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)