After the last update - any image with size - is now getting the original image.

For example - I've got the following filter:

[flickr-photo:id=5752211501,size=-]

And that's generating:

http://farm3.staticflickr.com/2263/5752211501_86502e85c9_o.jpg

The _o here seems wrong.

All other sizes seem to work OK.

CommentFileSizeAuthor
#6 flickr-more-sizes-1440918-6.patch5.91 KBlolandese
#2 flickr-more-sizes-1440918-0.patch3.62 KBlolandese

Comments

guguss’s picture

guguss commented

Facing the same issue with the "Medium 500" size... The images displayed are the original images.

lolandese’s picture

lolandese commented
Status: Active » Needs review
StatusFileSize
new flickr-more-sizes-1440918-0.patch3.62 KB

Patch solves the issue. Furthermore it adds some image sizes, most interesting a Large Square (150px) and Small 320 (320px on longest side). It also exposes the available image sizes up to 500px in the filter tips (bigger is hardly ever used inside the content body). In the README-new.txt you find all sizes.

Off topic:
Using Colorbox? Go to http://drupal.org/node/1637464.

lolandese’s picture

lolandese commented
Status: Needs review » Reviewed & tested by the community

No objections for some time, thus changing status.

Anonymous’s picture

Anonymous (not verified) commented

I had a problem applying the patch ..

git apply -v flickr-more-sizes-1440918-0.patch
flickr-more-sizes-1440918-0.patch:94: trailing whitespace.
The filter format is: [flickr-photo:id=230452326,size=s] and 
Checking patch flickr.inc...
error: while searching for:
  return array(
    's' => array(
      'label' => 'Square',
      'description' => t('75x75 pixel square'),
    ),
    't' => array(
      'label' => 'Thumbnail',
      'description' => t('100 pixels on longest side'),
    ),
    'm' => array(
      'label' => 'Small',
      'description' => t('240 pixels on longest side'),
    ),
    '-' => array(
      'label' => 'Medium 500',
      'description' => t('500 pixels on longest side'),
    ),
    'z' => array(
      'label' => 'Medium 640',
      'description' => t('640 pixels on longest side'),
    ),

    'b' => array(
      'label' => 'Large',
      'description' => t('1024 pixels on longest side'),
    ),
    'o' => array(
      'label' => 'Original',

error: patch failed: flickr.inc:17
error: flickr.inc: patch does not apply
Checking patch flickr_filter.module...
error: flickr_filter.module: No such file or directory
Checking patch README-new.txt...

Would you also roll your instructions into the README.txt.

Thanks, Paul

lolandese’s picture

lolandese commented

I have it applied without errors:

martin@martin-Extensa-5635Z:~/test/flickr$ patch -p1 < flickr-more-sizes-1440918-0.patch
patching file flickr.inc
patching file filter/flickr_filter.module
patching file README-new.txt
martin@martin-Extensa-5635Z:~/test/flickr$

Make sure you:

  • use the git-version
  • don't use the Master branch (change the default branch, see http://drupal.org/node/1659588)
  • use a p level. The p level instructs patch to ignore parts of the path name so that it can identify the files correctly.
lolandese’s picture

lolandese commented
StatusFileSize
new flickr-more-sizes-1440918-6.patch5.91 KB

Re-rolled the patch with README.txt and based on latest dev version. Tested.

lolandese’s picture

lolandese commented
Status: Reviewed & tested by the community » Fixed

Committed. http://drupal.org/commitlog/commit/2102/40e80f22e1a634a0fd07e1aba55e664f...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.