It has been some years now using the location module on many different implementations of websites using drupal and its time to update the location.inc file line:
'mk' => t('Macedonia'),
to
'mk =>t('FYROM'),
Since the name for the Former Yugoslanic Republic has been changed and according to court decisions we should all call it 'Former Yugoslavic Republic of Macedonia' aka FYROM, i think we owe to change that one. In addition there is a location.gr.inc file in the 'supported/' folder that makes proper use of the name 'Macedonia' for the northern provinences of Greece, ex 'Central Macedonia', 'Western Macedonia' etc. Leaving it like that is unfair and it forcefully leads to the misuse of the name without any formal decision, since the case has been resolved into using the 'FYROM' word. It might not make any sence to you but we are having problems when location is used in conjuction with ecommerce modules when people select Macedonia and wait for the parcel to be send in Greece. The Greek contributors of Drupal would kindly request you to change it accordingly.
Also on 'geocoding/' folder in the google.inc file there is a comment on line 51 where it should again read to FYROM instead of Macedonia.
Thank you in advance.
| Comment | File | Size | Author |
|---|---|---|---|
| #36 | iso-countries-documentation-1446414.patch | 550 bytes | aaronbauman |
Comments
Comment #1
kirev commentedPal, keep the politics out of here. There are no Court decisions to change the name. On the contrary. Macedonia is good.
Comment #2
delazaren commentedSince the internationally recognised name of the country is F.Y.R.O.M the information in the location file should be changed to that.
Comment #3
nevron commentedTo commenter #1. Since major institutions like Cambridge and Oxford and Yale Universities confirms and backs up my feature request for location module in terms of historical content and while if you check what google, bing and openmaps uses you can see that it's not politics i am discussing over here, on the contrary. We can discuss politics if you want, but that is not my issue here. My issue is that there is a major problem with ecommerce addons for drupal we have been facing with problems regarding the Macedonia territories not being selected whenever someone registers his address. We have been always overidding the location.inc file contents but it has to be formalised, if you want to be historicly, scientificly, territorialwise sound. There are plenty of Greek drupalers and our market holds a very good and increasing 25% of ecommerce websites build using this technology, we want to fix this problem and move on.
Comment #4
theodorosploumis+1 for FYROM. We must keep official location names.
Comment #5
xarisd commentedI agree also. 'FYROM' should be used.
Comment #6
mazdakaps commented+1 FYROM is much better choice at that time.
Comment #7
kirev commentedBullcrap. No Cambridge no Yale... Here are my passports, where are yours?
Republic of Macedonia
Comment #8
nevron commentedMy passport is in Greek letters and resides in Macedonia. Your passport is in Slavic language and resides in Vardarska. The passport in the picture you show is a forgery of intellectual information since it still contains the name Macedonia end the effects of it are miseducation in history for the young generations of the world. If you believe you are more knowledgable on the matter that all the historians out there then you just have to prove it starting by trying to have a polite discussion in the first place. Here is a little bit of reading for you http://en.wikipedia.org/wiki/Macedonia_%28Greece%29 . You are currently 5:1 and even if all former yugoslavian people post a comment we are still outnumbering you, not to mention the beliefs of the international community. Show me by facts and make me believe you, until then this has to be change to FYROM, if you asked me i'd say it would have to be changed to Vardarska but since FYROM is the final appropriate name decided we all have to go with the rules, why should you be any different from the rest? Just by declaring myself being from a certain time and space in the world doesn't necceserily mean that everyone agrees with me. Macedonia is a territory belonging to Greece, that is a fact, i would recommend you to see the accompaning territories file for Greece in this modules data. At the end of the day there is no harm done since we all override the modules code to show FYROM instead, but this has to stop and change now. Let's leave the job of deciding the future of the request to the module maintainers, if they don't change it we will have to be overriding for as long as we are using it. Try to convince them not to change it but don't try this to me because is simply disagree with you for now.
Comment #9
mazdakaps commentedWe all have to be reasonable and play by the rules. Trying to stand up yourself by showing passports and beeing aggresive wont make anyone change his mind. Just the opposite. Also it isnt polite for the maintainers of this module to see cases like these. I believe we all just have to agree that we must follow the laws and rules for such a sensitive case. Both users and maintainers of this module. Nevron just made a reasonable point.
Cheers
Comment #10
kirev commentedMy passports show the official name of my country. I am not aggressive at all. YOU are aggressive. Cut the discussion about other people's countries. YOU have no right to christen others. My right is to breath. My right is to call myself as I wish. My right is to call my country as I wish.
Comment #11
nevron commentedUntil the dispute is resolved through discussions FYROM is the official name to use, if you as a single person do not agree with that then it is not up to you to discuss it any further, this can only be done by educated academic people. As far as the rights you are claiming, these are undeniable for every living thing on earth, not just for you. Our Macedonian ancestors were not just great in names, they have fought hard to let us inherit their legends, stories and culutre, in return they granted us with the responsibility of maintaining their history over the years, if it was not for so many generations of our ancestors that lived the Macedonian way you would not even know them. How about your ancestors, where did they came from, what language do they speak, do they know Greek gods by their names, have they cherished their ancestors history, have you got any folklore sayings about Macedonian legends passed from one generation to the other? Ofcourse you are of Slavic descent, you dont speak or are able to read Greek, you are mostly Muslims playing Turkey's game thus aligning with them because of your religion. You named your airport 'Alexander the Great', you built a statue of him, you teach your children in schools that FYROM's borders are as far as the Aeagan sea, you tried to incorporate Bulgarian heros too in the past, Albanian culture as well, everything you claim to be is fabricated, your mafia goverment is commiting crimes as we speak, all these in the last 10 years or so, suddenly, were you've been all that long?. Say that we let you 'be' like us Macedonians and 'lend' our history to you, will you be able to maintain the facts as they are for like 2.000 years? What have your people fought in the past for? Who can trust you anyway when you are brainwashing your own children? And for you information every passport like these fake ones you showed that comes into a country that is either part of NATO, EU or UN is being cancelled. Why don't you cancel any Greek passport or Buglarian or Albanian or Serbian that comes into FYROM? Thats because you need us, you cant put it up with all of you neighbours, we need to be friends, we can be better, we have cultural bridges to build, things to share, you need to accept what history has led you to, you need to cherish you culture, being Slav is great, living in Vardarska is also great, be yourself, be free, your people have been through harsh times, you should know better, you can be a nation, you can claim ethnicity, teach your children about love, about friendship, let your ancestors rejoice by letting the world know who you really are, all their hardships will go in vain otherwise, overthrow your goverment that is causing so much trouble to you, and for what, we want healthy Balkans, isn't that what you want too? Stop being a cancer, resist your mafia goverment of the third reich, be you, be Slav, be free. We can help, all you need to do is to believe in freedom and we will fix everything together, be wise my friend, just like our ancestors did.
Comment #12
kirev commentedNo Macedonian passports are canceled because of the name. This is propaganda and lies. Official name of my country is Macedonia, the language Macedonian. Case closed.
Comment #13
nevron commentedNo FYROM passports are allowed with the name 'Macedonia' in Greece. You are full of propaganda and lies. Official name of my country is Greece, the language Greek. Official name of Northern Greece is Macedonia, the language Greek. Official name of people of Northern Greece is Macedonians, language Greek. Official name of ancient Macedonia is Macedonia, language Greek. Official name of FYROM is Vardarska, language Slavic. Case closed.
Comment #14
mazdakaps commentedI am Macedonian from Greece. All the historical facts proves that. You dont have any historical facts just copy ours and sell them as yours. Having the name of Macedonia on your passports isnt a facts of your ancestry. Is a fact of stealling and if you were a company you would be sued for stealling of copywrite material. You are a mix of ethnicities with no relation with Greece therefore Macedonia. Not talking for Alexander the Great. You think he was talking Slav? Angient Slav or whatever?
This is hillarius. This is something they sell you to justice your existance as a country with no history at all.
I am free breathing Greek Macedonian. Dont still my history and my ancestry. Try to get along on your own and create things dont copy them.
Comment #15
kirev commentedRidiculous claims. You've never been to the border, but you know. I come to Greece with my passport every year. Give me links of your passports. You cannot be Hellenoi, Graekoi, Romaoi and Makedonoi at the same time. Seems pretty confusing identity, isn't it? BTW, your passport says Hellenic Republic. You might want to change the name of your country to Hellenic and Macedonian Republic, but, well, it will still be different than Republic of Macedonia.
Case closed. Keep your ancestry just follow common law - use the official name for my country. Republic of Macedonia and language Macedonian.
(first you claim some court decisions without references, then you claim this and that, again, without references. my reference is simple - my passport)
Comment #16
ankur commentedBecause the location module takes the list of names from the core country_get_list() function (defined in includes/locale.inc), this is a Drupal core issue.
I should note that the ISO standard uses "The Former Yugoslavic Republic of". See http://www.iso.org/iso/country_names_and_code_elements
I think the resolution to this should simply be a question of: Should we go with (1) what the country itself wants to be called or (2) what the international authorities (if the UN can be labeled as such) have agreed to call the country or (3) what is used by ISO-3166?
My suggestion is that we avoid debating over any details about history, ethnicity, nationality or anything like that. That discussion might be more appropriate elsewhere, perhaps at the venues where the above-mentioned naming standards are agreed to. Over here, I would urge us to focus on what is correct purely from a technical and standards-based perspective.
Comment #17
chx commentedAlthough the former comment mentions the UN, the UN and the ISO are not the same, however the United Nations uses http://www.un.org/en/members/index.shtml#t "The former Yugoslav Republic of Macedonia" in the Member State list. Also see the header of http://www.un.org.mk/
Comment #18
chx commentedThe file in question, in D8 is includes/standard.inc. The doxygen says * Get an array of all country code => country name pairs as laid out in ISO 3166-1 alpha-2. There is no political question, the standard list is at http://www.iso.org/iso/country_names_and_code_elements and calls it MACEDONIA, THE FORMER YUGOSLAV REPUBLIC OF. That's what this file should return. Someone should countercheck the whole file. MD, PS, TW and VE is wrong too. There might be more. All comma separated values?
Comment #19
chx commentedComment #20
chx commentedComment #21
tim.plunkettThis is a straight dump of the list, it includes changes like:
and
If desired, I can reroll it without changes like that, but I thought that this would be a good start.
Comment #23
tim.plunkettDidn't account for apostrophes in strings. Also fixing capitalization.
Comment #24
ZenDoodles commentedLooks great to me. Ship it!
Comment #25
tim.plunkettQuick reroll:
This is an unnecessary change
So I lowercased this to "Dutch part".
Leaving at RTBC.
Comment #26
tim.plunkettWhoops, dreditor bounced it back because I used it to show my changes :)
Comment #27
chx commentedI would hold this , just a little bit. Despite yes that's the standard I would like to talk a bit here, you know I would've thought the country is called British Virgin Islands not Virgin Islands, British.
Comment #28
tr commentedThere's already an issue open for this: #1068840: core/includes/standard.inc contains inaccurate country data
Comment #29
alan d. commentedThe other issue appears to be a bit held up, like for over a year now.
For D7, we have had been granted string freeze exception for the new strings. The Drupal 7 minimal patch simply adds the new country strings, so it is very painful that it is being held up.
The issues holding this up more complete patches:
Possible issue with sorting due to the change:
Without the addition of additional sorting mechanisms in core, this will result in the country being listed last in the list. In this regards, I personally do not think that this addition should be added. In the countries module, I have bypassed this issue using a custom array sort based on a simple character mapping. I'm not sure if Drupal 7 core should have a overly simplified transliteration function built in, but huge "yes please" for Drupal 8. I know of custom implementations in at least 10 modules.
Possible data loss due to dropping AN
We already of 1 of the 3 new countries added due to the constitutional changes here, so IMHO, leave this in to bypass arguments, and in Drupal 8, drop this country and document a policy that during major upgrades Drupal core will drop countries that have been deleted from the ISO standard. Since this is a 1 country to 3 country change it is physically impossible to do an update script for this! Or maybe a best fit, pick the most populous country and assign all AN codes to this.
This short summary excludes a lot of related noise that is not directly related to the primary focus of the thread. :(
Note 1: The ISO and UN are related. From the ISO FAQ
See http://www.iso.org/iso/country_codes/iso_3166-faqs/iso_3166_faqs_general...
Note 2: If you do not want to hack core, use hook_countries_alter() [or the countries module] and you can happy bypass all of the related noise over this. The other thread has a complete list of the changes required to make this up to date with the ISO standard.
Comment #30
xxronis commentedYes man chill, its not bad to be a Slav, right?
Just gathered after 2300 years and resurrected an ancient nation, come on
-- Macedonian language?get real my friend -- go educate yourself
its ΜΑΚΕΔΟΝΙΑ and its written in Greek, u cant even pronounce your country's name correctly, you dont know what this greek word means
We go for the standards offcourse , this is information technology not the balkan news,
Comment #31
jddeli commentedMAKEDONIA IS GREEK
In greece the place is makedonia in greek μακεδονία.
There is no language Makedonian.
In Μακεδονία the language is greek.
Comment #32
tim.plunkettFeel free to discuss on the other issue mentioned in #28.
Comment #33
Niklas Fiekas commentedAs TR said in #28: There is already an issue for this: #1068840: core/includes/standard.inc contains inaccurate country data. Can you follow that and check if the proposed changes there would be correct? (I am not sure, but as per the issue priority guidelines I'd say that (too) wouldn't qualify as critical.)
Comment #34
aaronbauman#1068840: core/includes/standard.inc contains inaccurate country data was closed, and discussion of incorrect country names was dismissed.
I understand that the country strings are long-frozen, but can we update the documentation at least?
The list does not match ISO 3166-1 alpha-2.
Comment #36
aaronbaumanComment #37
tr commentedThis issue has been closed for 4 years - please open another issue for your bug report.
But be aware that new issues need to be fixed in D8 first, so if you want to open a D7 issue make sure first that D8 doesn't have the same problem.
Comment #38
aaronbauman#2688383: iso.inc claims to match ISO 3166-1 alpha-2, does not