help needed with overriding user profile layout

It is explained on the rest of that page:
http://drupal.org/node/11811

Each stub is the piece of code which tells phptemplate about your override.

The profile module contains the following theme_ function:

function theme_profile_profile($user, $fields = array()) {
     
  $output  = "<div class=\"profile\">\n";
  $output .= theme('user_picture', $user);
  $output .= ' <div class="name">'. format_name($user) ."</div>\n";
      
  foreach ($fields as $field) {
    if ($value = profile_view_field($user, $field)) {
      $output .= " <div class=\"field\">$value</div>\n";
    }
  }
  
  $output .= "</div>\n";
   
  return $output;
}

As mentioned on the page that Steven referenced, you'll want to override that theme in your template.php file. It would look something like this:

/**
* Catch the theme_profile_profile function, and redirect through the template api
*/
function phptemplate_profile_profile($user, $fields = array()) {
  // Pass to phptemplate, including translating the parameters to an associative array. The element names are the names that the variables
  // will be assigned within your template.

  /* potential need for other code to extract field info */

  return _phptemplate_callback('profile_profile', array('user' => $user, 'fields' => $fields));
}

Now you can create that magic profile_profile.tpl.php file and design the layout. You have the $user and $fields variables to work with. You will likely need to do some logic on the fields array to get the ordering you want.

So, the key learning here is to look at the functions in the target module that begin with "theme_" -- these are the ones that can be overriden, and in general always control the output of the module.

Another thing to consider is optional fields - for example:

<?php if($user->profile_bio !=""): ?>
<div class="user_bio"><?php print $user->profile_bio ?></div>
<? endif ?>

would only show the field if it were filled in.

I'm having trouble getting this to work with the 'freeform lists' when they are left blank.

<?php if($user->profile_employer !=""): ?>
<div class="user_employer"><?php print $user->profile_employer ?></div>
<? endif ?>

produces

array

when left blank. it works with it filled in though. can anyone offer any tips for this?

... ps - it's also good code form I guess because phptemplate is coded with if / endif statements.

[]+][+][+[]
erik mallinson
http://coacalina.org

Okay, first of all I made a mistake in what was printing array. It was actually printing 'array' when I was trying to print a 'birthdate' line, using the same formatting as the previous lines. I didn't think it was that because directly afterwards I had 'astrological sign' - which when I looked at it was similar enough to 'birthdate' that my brain didn't filter the problem. :) So the date field isn't printing basically.

The two different methods of calling the array for the freeform list seem to work the same, which is cool:

			<?php if (! is_array($user->profile_employer)): ?>
			<div class="user_employer"><?php print $user->profile_employer ?></div>
			<?php endif ?>

and this one:

			<?php if ($user->profile_employer !=""): ?>
			<div class="user_employer"><?php print $user->profile_employer ?></div>
			<?php endif ?>

Now onto the problem of printing each line or CSV of the freeform list. I can't seem to get foreach to output anything. for example:

			<?php if ($user->profile_profession !=""):?>
			<div class="user_profession">
				<? print $user->profile_profession ?>
				<ul>
				<?php foreach ($user->profile_profession as $profession_link):?>
				<li><a href="/profile/profile_profession/<? print $profession_link ?>" title="title here"><? print $profession_link ?></a></li>
				<?php endforeach ?>
				</ul>
			</div>
			<?php endif ?>

You'll notice on the third line I have it just print the contents of the freeform list, that's for testing purposes, to make sure it prints. But anything within the foreach it will not print.

I also noticed that I was getting error messages in the log for this problem,

warning: Invalid argument supplied for foreach() in /"my account path"/public_html/themes/griffin_phptemplate/user_profile.tpl.php on line 22.

Line 22 being the beginning of the foreach statement. I've looked over the foreach documentation quite a bit and haven't noticed anything that would tell me that I'm doing something wrong. The only thing I could think of is that it's not being stored as an array. If I just wrap the print $user->profile_profession it links to the whole thing as a link. But drupal is obviously got it right, so what am I missing?

[]+][+][+[]
erik mallinson
http://coacalina.org

I am the designer of phptemplate, and I have looked at your problem.. here is the theme you are overriding :

function theme_profile_profile($user, $fields = array()) {

  $output  = "<div class=\"profile\">\n";
  $output .= theme('user_picture', $user);
  $output .= ' <div class="name">'. format_name($user) ."</div>\n";

  foreach ($fields as $field) {
    if ($value = profile_view_field($user, $field)) {
      $output .= " <div class=\"field\">$value</div>\n";
    }
  }

  $output .= "</div>\n";

  return $output;
}

Now!. the permissions trick here are the lines :

    if ($value = profile_view_field($user, $field)) {
      $output .= " <div class=\"field\">$value</div>\n";
    }

If you furthermore look at the profile_view_field() function :
[?
function profile_view_field($user, $field) {
// Only allow browsing of private fields for admins
$browse = user_access('administer users') || $field->visibility != PROFILE_PRIVATE;

?]

This means to get the permissions working as they are presently, you need to check if the profile_view_field function returns anything. You can completely avoid the output if that's what you require (although it might be practical to use it for everything other than the specifically overridden fields).

--
The future is so Bryght, I have to wear shades.

Jason -

Could you post your final profile.module solution for the benefit of the group? Like you were in December, I'm coming at this "bamboozled, baffled & braindead."

- matthew | nautis.com

As of Sept. 6, the problem where overriding the profile.module's theme functions led to user access violations is fixed. You can now use the $fields variable however you want without having to perform additional checks.

- Robert Douglass

-----
Rate the value of this post: http://rate.affero.net/robertDouglass/
I recommend CivicSpace: www.civicspacelabs.org
My sites: www.hornroller.com, www.robshouse.net

subscribe

Hey Guys,

I'm having a big problem.

I'm using the profile override statement as many of you are

<?php
/**
* Catch the theme_user_profile function, and redirect through the template api
*/
function phptemplate_user_profile($user, $fields = array()) {
  // Pass to phptemplate, including translating the parameters to an associative array. The element names are the names that the variables
  // will be assigned within your template.
  /* potential need for other code to extract field info */
return _phptemplate_callback('user_profile', array('user' => $user, 'fields' => $fields));
  }
?>

and now when I try to click on another persons profile listing to go to their profile, it goes to their URL but all the content is still my own even though they have created content. EX: Even though the url says "localhost:8888/user/addie-black" it's administrator's content, because I'm logged in as administrator. If I were logged in as addie black, all users profiles that addie navigated to would be her own profile content (picture, bio, links.. everything.)

How can I fix this so that users can view other peoples profiles?

Perhaps it's something in my actual profile layout> http://pastie.textmate.org/225770

Thanks.

Jon.